diff options
| author | dmauro <dmauro@google.com> | 2021-06-18 19:32:08 (GMT) |
|---|---|---|
| committer | dinord <dinor@google.com> | 2021-06-22 13:30:21 (GMT) |
| commit | f7902802f1a61140e188223fb6d1c95925cbec4a (patch) | |
| tree | 73aecd1bfa254110860db67b662b2f1f551d4cc8 /googletest/cmake/internal_utils.cmake | |
| parent | 7153098229e88295f9655ff1d3b0e2fa9eada5f8 (diff) | |
| download | googletest-f7902802f1a61140e188223fb6d1c95925cbec4a.zip googletest-f7902802f1a61140e188223fb6d1c95925cbec4a.tar.gz googletest-f7902802f1a61140e188223fb6d1c95925cbec4a.tar.bz2 | |
Googletest export
Remove -Werror from the CMake compiler flags
We should not force warnings as errors on users.
Sometimes compilers introduce new warnings which
will break builds.
Instead, we manually turn this flag on in our continuous integration
scripts so we can catch these errors, but not force them on our users.
Fixes #3447
PiperOrigin-RevId: 380241852
Diffstat (limited to 'googletest/cmake/internal_utils.cmake')
| -rw-r--r-- | googletest/cmake/internal_utils.cmake | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/googletest/cmake/internal_utils.cmake b/googletest/cmake/internal_utils.cmake index 8d8d60a..58fc9bf 100644 --- a/googletest/cmake/internal_utils.cmake +++ b/googletest/cmake/internal_utils.cmake @@ -84,13 +84,13 @@ macro(config_compiler_and_linker) # Ensure MSVC treats source files as UTF-8 encoded. set(cxx_base_flags "${cxx_base_flags} -utf-8") elseif (CMAKE_CXX_COMPILER_ID STREQUAL "Clang") - set(cxx_base_flags "-Wall -Wshadow -Werror -Wconversion") + set(cxx_base_flags "-Wall -Wshadow -Wconversion") set(cxx_exception_flags "-fexceptions") set(cxx_no_exception_flags "-fno-exceptions") set(cxx_strict_flags "-W -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wredundant-decls") set(cxx_no_rtti_flags "-fno-rtti") elseif (CMAKE_COMPILER_IS_GNUCXX) - set(cxx_base_flags "-Wall -Wshadow -Werror") + set(cxx_base_flags "-Wall -Wshadow") if(NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 7.0.0) set(cxx_base_flags "${cxx_base_flags} -Wno-error=dangling-else") endif() |