diff options
| author | Abseil Team <absl-team@google.com> | 2023-10-05 21:12:08 (GMT) |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2023-10-05 21:13:04 (GMT) |
| commit | 2dd1c131950043a8ad5ab0d2dda0e0970596586a (patch) | |
| tree | bd04fa69b2e3d1b8f85b7bfb43c07ca5bafd3e5d /googletest/test | |
| parent | beb552fb47e9e8a6ddab20526663c2dddd601ec6 (diff) | |
| download | googletest-2dd1c131950043a8ad5ab0d2dda0e0970596586a.zip googletest-2dd1c131950043a8ad5ab0d2dda0e0970596586a.tar.gz googletest-2dd1c131950043a8ad5ab0d2dda0e0970596586a.tar.bz2 | |
Fix RE::Init for Android and NetBSD.
This is a somewhat recent change for Android (I'm not clear on whether it's a recent change for NetBSD, or if Android was just very behind on its implementation), so while this worked fine as recently as API 32 devices, REG_GNU is required for API 34 (API 33 untested).
A test actually caught this, but https://github.com/google/googletest/pull/4334 "fixed" the test rather than the implementation. This CL also reverts the test change so it can catch the failure.
PiperOrigin-RevId: 571126374
Change-Id: I420dfcedea58f2c8b605f699515d744006c0a9d9
Diffstat (limited to 'googletest/test')
| -rw-r--r-- | googletest/test/googletest-port-test.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/googletest/test/googletest-port-test.cc b/googletest/test/googletest-port-test.cc index 8d21026..9f05a01 100644 --- a/googletest/test/googletest-port-test.cc +++ b/googletest/test/googletest-port-test.cc @@ -418,8 +418,8 @@ TYPED_TEST(RETest, ImplicitConstructorWorks) { const RE simple(TypeParam("hello")); EXPECT_STREQ("hello", simple.pattern()); - const RE normal(TypeParam(".*([[:alnum:]_]+)")); - EXPECT_STREQ(".*([[:alnum:]_]+)", normal.pattern()); + const RE normal(TypeParam(".*(\\w+)")); + EXPECT_STREQ(".*(\\w+)", normal.pattern()); } // Tests that RE's constructors reject invalid regular expressions. |