diff options
author | Tom Hughes <tomhughes@google.com> | 2023-04-21 17:40:36 (GMT) |
---|---|---|
committer | Copybara-Service <copybara-worker@google.com> | 2023-04-21 17:41:25 (GMT) |
commit | 783d00fd19865fcbc3065e3fb3e17144761fcf5a (patch) | |
tree | bb27246918f3fcdea0cb619a37ac43ccb1abeac0 /googletest/test | |
parent | baf182e006bcb82ef5e0b407e350a1d4c444b76a (diff) | |
download | googletest-783d00fd19865fcbc3065e3fb3e17144761fcf5a.zip googletest-783d00fd19865fcbc3065e3fb3e17144761fcf5a.tar.gz googletest-783d00fd19865fcbc3065e3fb3e17144761fcf5a.tar.bz2 |
Use '=default' to define trivial constructor/destructorsrefs/pull/4221/head
https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html
PiperOrigin-RevId: 526079054
Change-Id: Ia4db21e3e5f58b90de05d52fd94b291ed06d785d
Diffstat (limited to 'googletest/test')
-rw-r--r-- | googletest/test/googletest-port-test.cc | 4 | ||||
-rw-r--r-- | googletest/test/googletest-printers-test.cc | 6 | ||||
-rw-r--r-- | googletest/test/gtest_repeat_test.cc | 2 | ||||
-rw-r--r-- | googletest/test/gtest_unittest.cc | 2 |
4 files changed, 7 insertions, 7 deletions
diff --git a/googletest/test/googletest-port-test.cc b/googletest/test/googletest-port-test.cc index 94bb8e3..32a2a7b 100644 --- a/googletest/test/googletest-port-test.cc +++ b/googletest/test/googletest-port-test.cc @@ -97,7 +97,7 @@ class Base { explicit Base(int n) : member_(n) {} Base(const Base&) = default; Base& operator=(const Base&) = default; - virtual ~Base() {} + virtual ~Base() = default; int member() { return member_; } private: @@ -982,7 +982,7 @@ TEST(ThreadLocalTest, SingleParamConstructorInitializesToParam) { class NoDefaultConstructor { public: explicit NoDefaultConstructor(const char*) {} - NoDefaultConstructor(const NoDefaultConstructor&) {} + NoDefaultConstructor(const NoDefaultConstructor&) = default; }; TEST(ThreadLocalTest, ValueDefaultContructorIsNotRequiredForParamVersion) { diff --git a/googletest/test/googletest-printers-test.cc b/googletest/test/googletest-printers-test.cc index e667e8f..f44f29a 100644 --- a/googletest/test/googletest-printers-test.cc +++ b/googletest/test/googletest-printers-test.cc @@ -108,7 +108,7 @@ class UnprintableTemplateInGlobal { // A user-defined streamable type in the global namespace. class StreamableInGlobal { public: - virtual ~StreamableInGlobal() {} + virtual ~StreamableInGlobal() = default; }; inline void operator<<(::std::ostream& os, const StreamableInGlobal& /* x */) { @@ -216,7 +216,7 @@ class PathLike { using value_type = char; using const_iterator = iterator; - PathLike() {} + PathLike() = default; iterator begin() const { return iterator(); } iterator end() const { return iterator(); } @@ -749,7 +749,7 @@ AssertionResult HasPrefix(const StringType& str, const StringType& prefix) { struct Foo { public: - virtual ~Foo() {} + virtual ~Foo() = default; int MyMethod(char x) { return x + 1; } virtual char MyVirtualMethod(int /* n */) { return 'a'; } diff --git a/googletest/test/gtest_repeat_test.cc b/googletest/test/gtest_repeat_test.cc index 73fb8dc..f67b788 100644 --- a/googletest/test/gtest_repeat_test.cc +++ b/googletest/test/gtest_repeat_test.cc @@ -61,7 +61,7 @@ int g_environment_tear_down_count = 0; class MyEnvironment : public testing::Environment { public: - MyEnvironment() {} + MyEnvironment() = default; void SetUp() override { g_environment_set_up_count++; } void TearDown() override { g_environment_tear_down_count++; } }; diff --git a/googletest/test/gtest_unittest.cc b/googletest/test/gtest_unittest.cc index 57041f0..1fde827 100644 --- a/googletest/test/gtest_unittest.cc +++ b/googletest/test/gtest_unittest.cc @@ -4951,7 +4951,7 @@ TEST(ComparisonAssertionTest, AcceptsUnprintableArgs) { // both in a TEST and in a TEST_F. class Foo { public: - Foo() {} + Foo() = default; private: int Bar() const { return 1; } |