summaryrefslogtreecommitdiffstats
path: root/googletest
diff options
context:
space:
mode:
authorMario Voorsluys <mvoorsluys@lely.com>2020-03-26 14:03:32 (GMT)
committerMario Voorsluys <mvoorsluys@lely.com>2020-03-26 14:03:32 (GMT)
commitd28d05cc6473fd2f4a96ce0fd1cba4dd63102649 (patch)
tree64dca99b45790f52bc0ee3617a0d47b6cd0d9a81 /googletest
parent59e5b401a512a453204b9059c6a75e199a8dd8be (diff)
downloadgoogletest-d28d05cc6473fd2f4a96ce0fd1cba4dd63102649.zip
googletest-d28d05cc6473fd2f4a96ce0fd1cba4dd63102649.tar.gz
googletest-d28d05cc6473fd2f4a96ce0fd1cba4dd63102649.tar.bz2
Only write ">\n" once when there is failure and skipped tests.
Diffstat (limited to 'googletest')
-rw-r--r--googletest/src/gtest.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/googletest/src/gtest.cc b/googletest/src/gtest.cc
index 58da0f1..d6aef6a 100644
--- a/googletest/src/gtest.cc
+++ b/googletest/src/gtest.cc
@@ -4085,7 +4085,7 @@ void XmlUnitTestResultPrinter::OutputXmlTestInfo(::std::ostream* stream,
for (int i = 0; i < result.total_part_count(); ++i) {
const TestPartResult& part = result.GetTestPartResult(i);
if (part.failed()) {
- if (++failures == 1) {
+ if (++failures == 1 && skips == 0) {
*stream << ">\n";
}
const std::string location =
@@ -4099,7 +4099,7 @@ void XmlUnitTestResultPrinter::OutputXmlTestInfo(::std::ostream* stream,
OutputXmlCDataSection(stream, RemoveInvalidXmlCharacters(detail).c_str());
*stream << "</failure>\n";
} else if (part.skipped()) {
- if (++skips == 1) {
+ if (++skips == 1 && failures == 0) {
*stream << ">\n";
}
const std::string location =