diff options
| author | Tom Hughes <tomhughes@google.com> | 2023-01-31 19:36:17 (GMT) |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2023-01-31 19:37:10 (GMT) |
| commit | d9251171f5a42eaf993395e7ef127546af5814b0 (patch) | |
| tree | 1c19a276a84d6d0d9607e65e93f55afb891ebf3c /googletest | |
| parent | 4fb7039fda3f6588c7ca9664176f8c9e0a023b4a (diff) | |
| download | googletest-d9251171f5a42eaf993395e7ef127546af5814b0.zip googletest-d9251171f5a42eaf993395e7ef127546af5814b0.tar.gz googletest-d9251171f5a42eaf993395e7ef127546af5814b0.tar.bz2 | |
Fix sign conversion warning from clang:
googletest/samples/prime_tables.h:81:57: error:
implicit conversion changes signedness: 'int' to 'unsigned long'
[-Werror,-Wsign-conversion]
: is_prime_size_(max + 1), is_prime_(new bool[max + 1]) {
~~~ ~~~~^~~
PiperOrigin-RevId: 506065360
Change-Id: Ida4550562531012c089e2f9fcf530b3a78889fa3
Diffstat (limited to 'googletest')
| -rw-r--r-- | googletest/samples/prime_tables.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/googletest/samples/prime_tables.h b/googletest/samples/prime_tables.h index 7c0286e..08ad949 100644 --- a/googletest/samples/prime_tables.h +++ b/googletest/samples/prime_tables.h @@ -78,8 +78,9 @@ class PreCalculatedPrimeTable : public PrimeTable { public: // 'max' specifies the maximum number the prime table holds. explicit PreCalculatedPrimeTable(int max) - : is_prime_size_(max + 1), is_prime_(new bool[max + 1]) { - CalculatePrimesUpTo(max); + : is_prime_size_(std::max(1, max + 1)), + is_prime_(new bool[static_cast<size_t>(is_prime_size_)]) { + CalculatePrimesUpTo(is_prime_size_ - 1); } ~PreCalculatedPrimeTable() override { delete[] is_prime_; } |