summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix typorefs/pull/4158/headVũ Phạm2023-02-191-1/+1
|
* Fix link in ReportUninterestingCall messageAbseil Team2023-02-163-6/+6
| | | | | | | | | | This CL changes the link in the ReportUninterestingCall message from .../gmock_cook_book.md#knowing-when-to-expect to .../gmock_cook_book.md#knowing-when-to-expect-useoncall. This is necessary following https://github.com/google/googletest/commit/31ff597. PiperOrigin-RevId: 510138974 Change-Id: Ic98c84b07751d27dfc95eddbe7874f76d68b456f
* Remove strdup usageAbseil Team2023-02-154-115/+54
| | | | | PiperOrigin-RevId: 509947007 Change-Id: I31e1274afa889776829c877c40c9af589298dcf2
* Remove some filesystem APIs and tests under !GTEST_HAS_FILE_SYSTEMAbseil Team2023-02-142-1/+10
| | | | | PiperOrigin-RevId: 509537606 Change-Id: I68f7054e34b1fe76c1fd85099fffa4ee3c2b00c0
* Avoid reliance on <any> header without RTTI on MSVCAbseil Team2023-02-131-1/+2
| | | | | | Fixes: #4144 PiperOrigin-RevId: 509322023 Change-Id: I52bdf6c25ff433327e174d3f9583b3d50b872d58
* Fix _MSC_VER checkTom Hughes2023-02-081-1/+1
| | | | | | | | Use "#if defined(_MSC_VER)" instead of "#if _MSC_VER" to be consistent with other usages in googletest and to work with the "-Wundef" warning. PiperOrigin-RevId: 508087630 Change-Id: I29c16fd2fa51a9dfecd55e10362a020318318956
* Remove GTEST_USES_PCRE referencesTom Hughes2023-02-072-32/+2
| | | | | | | | | | | | | Nothing defines GTEST_USES_PCRE anymore. It was only meant for internal use, so nothing public should be relying on it: https://github.com/google/googletest/issues/2735#issuecomment-644849438. Found when compiling with "-Wundef". Fixes #2735. PiperOrigin-RevId: 507823660 Change-Id: Ie19e576ff01dc3b16381338578ece92adccfc09b
* Fix GTEST_HAS_ABSL define check for [-Werror=undef] compilationsMartijn Vels2023-02-071-2/+2
| | | | | PiperOrigin-RevId: 507788664 Change-Id: Ib8cfbf3102a38e210fdae8a548fd84f0723ccc10
* Add support for the alternative base64 encoding in RFC 4648 section 5 to ↵Abseil Team2023-02-063-2/+10
| | | | | | | `WhenBase64Unescaped`. PiperOrigin-RevId: 507527786 Change-Id: Ie5e088b1814981f6c760d7e25418a430172705ec
* Fix compiler flags in Linux presubmitTom Hughes2023-02-021-1/+1
| | | | | | | | | | CXX_FLAGS should be CXXFLAGS and the quoting was wrong. As a result, "-Werror -Wdeprecated" was not being applied. https://cmake.org/cmake/help/latest/envvar/CXXFLAGS.html PiperOrigin-RevId: 506656655 Change-Id: Ic5e861be3b9c32257eb9aabb845c931f3cba7122
* Fix -Wsign-conversion warningsTom Hughes2023-02-025-16/+50
| | | | | | | | | | | | | | | | | | | | | | googletest/test/gtest_xml_outfile2_test_.cc:48:39: warning: implicit conversion turns floating-point number into integer: 'float' to 'int64_t' (aka 'long') [-Wfloat-conversion] RecordProperty("TestFloatProperty", float_prop); ~~~~~~~~~~~~~~ ^~~~~~~~~~ googletest/test/gtest_xml_outfile2_test_.cc:51:40: warning: implicit conversion turns floating-point number into integer: 'double' to 'int64_t' (aka 'long') [-Wfloat-conversion] RecordProperty("TestDoubleProperty", double_prop); ~~~~~~~~~~~~~~ ^~~~~~~~~~~ googletest/test/gtest_xml_outfile2_test_.cc:57:39: warning: implicit conversion changes signedness: 'size_t' (aka 'unsigned long') to 'int64_t' (aka 'long') [-Wsign-conversion] RecordProperty("TestSizetProperty", size_t_prop); ~~~~~~~~~~~~~~ ^~~~~~~~~~~ PiperOrigin-RevId: 506644143 Change-Id: I9c2cd5f52daebe25e73bb97f696687797ed2cabf
* Remove unneccessary "#if _MSC_VER"Tom Hughes2023-02-022-6/+2
| | | | | | | | | The GTEST_DISABLE_MSC_WARNINGS macros already have an _MSC_VER check. This change also adds a missing GTEST_DISABLE_MSC_WARNINGS_POP_ in gtest-typed-test_test.cc. PiperOrigin-RevId: 506636248 Change-Id: Ifdc044528f5448fbf0175887d1671f1e1f3040b9
* Add a trailing decimal point to FormatTimeInMillisAsSeconds() output when inputAbseil Team2023-02-024-5/+24
| | | | | | | is an exact N seconds. PiperOrigin-RevId: 506610898 Change-Id: Idcd705c719e0e721148c350c8a14f27b9eb5c4f7
* Fix include orderTom Hughes2023-02-011-2/+2
| | | | | PiperOrigin-RevId: 506424617 Change-Id: If7f0beb92022589523db204a6b5cbe9249cebf62
* Remove GMOCK_RENAME_MAINTom Hughes2023-02-011-7/+0
| | | | | | | GMOCK_RENAME_MAIN appears unused. PiperOrigin-RevId: 506387823 Change-Id: I732c1f64f9038991a5c9aea1f2ad6fff07622afa
* Build gmock Python tests when building with cmakeTom Hughes2023-02-011-2/+4
| | | | | | | Fixes #4124. PiperOrigin-RevId: 506379032 Change-Id: Ibc44ffce1012bbf313565728a3d9e5e6e56ba660
* Fix gmock_output_test when using MSVCTom Hughes2023-02-012-4/+9
| | | | | | | | | | | | | std::pair is printed as "struct std::pair<int,bool>" when using MSVC vs "std::pair<int,bool>" with other compilers. Switch to "std::tuple", which is the same for all compilers. See https://learn.microsoft.com/en-us/cpp/standard-library/pair-structure https://learn.microsoft.com/en-us/cpp/standard-library/tuple-class PiperOrigin-RevId: 506340295 Change-Id: Ib4ce2f74d54888a4e4173f42da1b55cc5583f7d4
* Fix sign conversion warning from clang:Tom Hughes2023-01-311-2/+3
| | | | | | | | | | | googletest/samples/prime_tables.h:81:57: error: implicit conversion changes signedness: 'int' to 'unsigned long' [-Werror,-Wsign-conversion] : is_prime_size_(max + 1), is_prime_(new bool[max + 1]) { ~~~ ~~~~^~~ PiperOrigin-RevId: 506065360 Change-Id: Ida4550562531012c089e2f9fcf530b3a78889fa3
* Use GTEST_DISABLE_MSC_WARNINGS macros to disable warningsTom Hughes2023-01-3017-149/+72
| | | | | | | | | Prior to this change we had a mixture of pragmas and GTEST_DISABLE_MSC_WARNINGS; this change consolidates all instances to use the macros. PiperOrigin-RevId: 505786926 Change-Id: I2be8f6304387393995081af42ed32c2ad1bba5a7
* Use explicit short to fix MSVC compiler warningTom Hughes2023-01-301-4/+4
| | | | | | | | warning C4244: 'initializing': conversion from 'int' to 'short', possible loss of data PiperOrigin-RevId: 505774670 Change-Id: I3524040334a4b265bae12cfacdd2b615cbb1cfc8
* Merge pull request #4115 from SunBlack:codespellCopybara-Service2023-01-301-2/+2
|\ | | | | | | | | PiperOrigin-RevId: 505740434 Change-Id: I963f6a6b667a030c87f211173f578f7c35733e68
| * Fix typos found by codespellrefs/pull/4115/headSunBlack2023-01-041-2/+2
| |
* | Test current behavior of doubles and floats in RecordPropertyTom Hughes2023-01-273-4/+21
| | | | | | | | | | PiperOrigin-RevId: 505104193 Change-Id: I4c2758f22ee1321ed6b6662ab2668f6c5b6aa661
* | Fix formatting in Python filesTom Hughes2023-01-265-84/+158
| | | | | | | | | | PiperOrigin-RevId: 504890435 Change-Id: Ia9a89d0d7a07fe70c12f7f0202c8256c94d2f118
* | Fix Python docstrings to match style guideTom Hughes2023-01-267-33/+88
| | | | | | | | | | | | | | https://google.github.io/styleguide/pyguide.html#s3.8.3-functions-and-methods PiperOrigin-RevId: 504857416 Change-Id: I7815ce27e454a120b3974ae7e2bea952108b836c
* | Make document and example code more clear in the caveat section for ↵Abseil Team2023-01-261-5/+11
| | | | | | | | | | | | | | potential memory leak with `SetUpTestSuite`. PiperOrigin-RevId: 504706717 Change-Id: I5842a4569f81f6c0d636099b5cdaabe778996949
* | Use more specific assertLess instead of assertTrueTom Hughes2023-01-251-2/+1
| | | | | | | | | | PiperOrigin-RevId: 504670738 Change-Id: Ib68b676403204098e89f536f9b8317f9f717c24d
* | Fix pylint warningTom Hughes2023-01-251-15/+23
| | | | | | | | | | | | | | | | | | Possible unbalanced tuple unpacking with sequence defined at line N: left side has 1 label(s), right side has 0 value(s) [unbalanced-tuple-unpacking] PiperOrigin-RevId: 504640001 Change-Id: If8d6038a9acf74a409cb6b6ee30cea7745b4b303
* | Remove pylint disable comments that no longer trigger warningsTom Hughes2023-01-253-12/+3
| | | | | | | | | | PiperOrigin-RevId: 504633130 Change-Id: I3fdbc83975fea97aa53f7325d323adead0a30e24
* | Mention `DescribeMatcher` in matchers.mdAbseil Team2023-01-251-0/+12
| | | | | | | | | | PiperOrigin-RevId: 504591836 Change-Id: I48c93490d0c3b7c6bfaceceb1cef5eedeacfe6c6
* | Fix formatting in subset of Python filesTom Hughes2023-01-2524-1349/+1481
| | | | | | | | | | | | | | | | These files were formatted with automated tools. The remaining Python files require some manual fix ups, so they will be fixed separately. PiperOrigin-RevId: 504579820 Change-Id: I3923bd414bffe3ded6163ec496cd09ace3951928
* | Replace numeric lints with their string equivalentTom Hughes2023-01-252-6/+6
| | | | | | | | | | PiperOrigin-RevId: 504570278 Change-Id: Iab9c988b3a781eaafbdd97c924a74c2269125799
* | Fix formatting of C++ filesTom Hughes2023-01-2415-85/+84
| | | | | | | | | | PiperOrigin-RevId: 504325204 Change-Id: Iaa1d6d0ab1dccaaeef26f9cb109d530835499240
* | Fix formatting of Markdown filesTom Hughes2023-01-242-15/+39
| | | | | | | | | | PiperOrigin-RevId: 504308485 Change-Id: Ia4ae97b2173b44b89aa5d987ddefd6e0c1488386
* | Remove FloatingPoint::Max() in favor of std::numeric_limits::max()Derek Mauro2023-01-242-15/+3
| | | | | | | | | | | | | | | | | | | | | | In #4113 a user says Max clashes with a macro. Since it is only used in a test, use std::numeric_limits::max() instead. Note that in headers, the macro issue can be mitigated with parenthesis like this: `(std::numeric_limits<T>::max)()` PiperOrigin-RevId: 504284906 Change-Id: Ibf430caec1a6afdf6b303534fec6a4fd00a6373f
* | Mention using MockFunction as a way to mock free functions.Abseil Team2023-01-181-0/+4
| | | | | | | | | | PiperOrigin-RevId: 502901538 Change-Id: I0cf351b9ad1411ae9c45e09550c24e006a24e179
* | Replace deprecated python callsTom Hughes2023-01-1715-186/+272
| | | | | | | | | | | | | | | | assert_ -> assertTrue/assertFalse/assertIn/assertNotIn assertEquals -> assertEqual PiperOrigin-RevId: 502654909 Change-Id: I25d30095a83c3806606cb80d676b3c979495e6bd
* | Announce that GitHub actions are not GoogleTest's canonical CIDino Radakovic2023-01-171-0/+7
| | | | | | | | | | PiperOrigin-RevId: 502654465 Change-Id: I51269e8c389ad63f3737132feec1b6d20dc4c314
* | Fix -Wimplicit-int-float-conversion warningTom Hughes2023-01-171-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're intentionally losing precision in this case, so add a cast. googletest/googletest/include/gtest/gtest-printers.h:532:9: error: implicit conversion from 'int32_t' (aka 'int') to 'float' may lose precision [-Werror,-Wimplicit-int-float-conversion] if (static_cast<int32_t>(val * mulfor6 + 0.5) / mulfor6 == val) return 6; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~ googletest/googletest/include/gtest/gtest-printers.h:544:9: error: implicit conversion from 'int32_t' (aka 'int') to 'float' may lose precision [-Werror,-Wimplicit-int-float-conversion] if (static_cast<int32_t>(val / divfor6 + 0.5) * divfor6 == val) return 6; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~ PiperOrigin-RevId: 502646042 Change-Id: I05989ee42675b531a9907616c9582a5a7c77bed6
* | Update documentation for v1.13.0Derek Mauro2023-01-172-6/+5
| | | | | | | | | | PiperOrigin-RevId: 502644180 Change-Id: Id20b5e4eec22035da278f1767002657f66dbe79c
* | Bump version to 1.13.0 in preparation for releasev1.13.0-prev1.13.0v1.13.xDerek Mauro2023-01-171-1/+1
| | | | | | | | | | PiperOrigin-RevId: 502626077 Change-Id: I3aad27a8b725cf73163e52ef2e28e6cdfc13082b
* | gmock_output_test: normalize golden file output to unix line endingsAbseil Team2023-01-171-0/+3
| | | | | | | | | | | | | | | | When checked out on Windows, the repo might use \r\n line endings, and so the golden output has them. Adjust for that. PiperOrigin-RevId: 502577222 Change-Id: Iabfe537f6d95a49bf6bdcb934e855d28c65f6f89
* | Fix -Wshadow warningsTom Hughes2023-01-121-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ../googlemock/test/gmock-actions_test.cc:687:36: warning: declaration of ‘v’ shadows a member of ‘testing::{anonymous}::ReturnTest_SupportsReferenceLikeReturnType_Test::TestBody()::Result’ [-Wshadow] 687 | Result(const std::vector<int>& v) : v(&v) {} // NOLINT | ~~~~~~~~~~~~~~~~~~~~~~~~^ ../googlemock/test/gmock-actions_test.cc:686:29: note: shadowed declaration is here 686 | const std::vector<int>* v; | ^ ../googlemock/test/gmock-actions_test.cc: In constructor ‘testing::{anonymous}::ReturnTest_PrefersConversionOperator_Test::TestBody()::Out::Out(int)’: ../googlemock/test/gmock-actions_test.cc:720:28: warning: declaration of ‘x’ shadows a member of ‘testing::{anonymous}::ReturnTest_PrefersConversionOperator_Test::TestBody()::Out’ [-Wshadow] 720 | explicit Out(const int x) : x(x) {} | ~~~~~~~~~~^ ../googlemock/test/gmock-actions_test.cc:718:9: note: shadowed declaration is here 718 | int x; | ^ PiperOrigin-RevId: 501580618 Change-Id: I584710fbbe440ec724f88746e51f3be5653c32d5
* | Add an explicit #error that C++ versions less than C++14 are not supportedDerek Mauro2023-01-121-0/+13
| | | | | | | | | | PiperOrigin-RevId: 501568410 Change-Id: I0f78cd96dc9204c8ec97a1cdd09a9d63a613cc5b
* | Update GoogleTest dependenciesDerek Mauro2023-01-111-24/+20
| | | | | | | | | | PiperOrigin-RevId: 501282034 Change-Id: I0314ac566dc5e117db5a06c97d303e5cf8822d61
* | Fix GTEST_OS_ESP8266 checkTom Hughes2023-01-051-1/+1
| | | | | | | | | | | | | | | | Everywhere else in the code, we check the value of GTEST_OS_ESP8266, not just whether it is defined. PiperOrigin-RevId: 499946909 Change-Id: I86f7e8947abb4e928fc24d1416d8237987b27845
* | IWYU: Add missing std includesTom Hughes2023-01-0522-0/+38
| | | | | | | | | | PiperOrigin-RevId: 499893032 Change-Id: I33304802b7c82ae2d008f3ee89df38866e5f57ba
* | Workaround for GCC12 bug illustrated by https://godbolt.org/z/Pe5aE59xGDerek Mauro2023-01-041-1/+2
|/ | | | | | | Fixes #4108 PiperOrigin-RevId: 499556061 Change-Id: I1cb1564f9b77e1825fddc9236965f4a3b661d96a
* Fix _MSC_VER checkTom Hughes2023-01-041-1/+1
| | | | | | | Use "#if defined(_MSC_VER)" instead of "#if _MSC_VER" to be consistent with other usages in the file and to work with the "-Wundef" warning. PiperOrigin-RevId: 499471290 Change-Id: I34a9442eecf266afd74d4332cab7d39766df4ed9
* Use a more recent commit of googletest that uses OS constraints fromAbseil Team2022-12-221-7/+6
| | | | | | | | | | | | | @platforms//os:* instead of from @build_tools//platforms:* See https://github.com/bazelbuild/bazel/issues/8622 Necessary to fix #4096 Also need the fix for #4098 PiperOrigin-RevId: 497182073 Change-Id: Ifd568b088d2f779755dd20264edfd5dad12ca9cc