| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Refactor function GetNextPrime so that the loop precondition is checked before
loop instead of during every loop run. Also by removing the loop condition,
it shows that the only exit from the loop is the return statement.
PiperOrigin-RevId: 293932783
|
|
|
|
|
|
|
|
| |
Get rid of gmock-generated-matchers.h and gmock-generated-matchers.h.pump.
Stop using pump for MATCHER* macroses generation.
PiperOrigin-RevId: 293878808
|
|
|
|
|
|
|
|
| |
Tag the function generated by MATCHER with GTEST_ATTRIBUTE_UNUSED_ to fix CI builds of gmock-matchers_test.cc vs. -Wunused-function.
See https://github.com/google/googletest/pull/2697 for breakage.
PiperOrigin-RevId: 293669752
|
|
|
|
|
|
|
|
|
| |
Get rid of gmock-generated-function-mockers.h and
gmock-generated-function-mockers.h.pump.
Stop using pump for GMOCK_METHOD* macroses generation.
PiperOrigin-RevId: 293454519
|
|
|
|
|
|
| |
...text exposed to GitHub repo https://www.github.com/google/googletest
PiperOrigin-RevId: 293438092
|
|
|
|
|
|
|
|
| |
Pass method's parameters count to internal GMOCK_METHOD* macro.
This will help removing copypaste in every GMOCK_METHOD* macro in future.
PiperOrigin-RevId: 292932554
|
|
|
|
|
|
| |
Fix std::move to std::forward where appropriate to support reference types.
PiperOrigin-RevId: 292923058
|
|
|
|
|
|
|
|
|
|
| |
Disable warning C4800 for Visual Studio 2019.
The compiler warning C4800 is disabled by default in Visual Studio 2019,
but it can be enabled on the command line. The only version of
Visual Studio that does not support warning C4800 is Visual Studio 2017.
PiperOrigin-RevId: 292624510
|
|
|
|
|
|
|
| |
Fix use of reserved names.
Minimize code duplication needed for explict-vs-nonexplicit constructor.
PiperOrigin-RevId: 292555014
|
|
|
|
|
|
| |
Add documentation for ASSERT_DEBUG_DEATH/EXPECT_DEBUG_DEATH
PiperOrigin-RevId: 292138974
|
|
|
|
|
|
| |
Add includes for type_traits and utility to gmock-function-mocker.h: macros in the file require these headers.
PiperOrigin-RevId: 291782497
|
|
|
|
|
|
|
|
|
|
|
| |
Create implementation macroses for matchers to move variadic parameters to the
end of parameters list.
To save backward compatibility, old macroses will be still taking `description`
parameter as the last one. But they will use INTERNAL macro that takes
`description` as the second parameter.
PiperOrigin-RevId: 291724469
|
|
|
|
|
|
| |
Adds missing `#define` guard around `TEST_F(...)`
PiperOrigin-RevId: 291703056
|
|
|
|
|
|
|
|
| |
Move part of functionality of Matcher* class to the base one. Reduce copypaste.
Make constructor and conversion operator of Matcher* class independent of pump.
PiperOrigin-RevId: 291405510
|
|
|
|
|
|
|
|
| |
Deleted an orphaned duplicate file and exclude another that shouldn't be part of :gtest_all_test.
This showed up while trying to debug the presubmit failure for: https://github.com/google/googletest/pull/2683
PiperOrigin-RevId: 291398123
|
|
|
|
|
|
|
|
|
| |
Add missing explicit keyword for gmock_Impl constructor.
When switching to using GMOCK_PP in ACTION* macroses `explicit` keyword was
missed in gmock_Impl constructor causing ClangTidy warnings in ACTION_P macro.
PiperOrigin-RevId: 291159975
|
|
|
|
|
|
| |
Fix SCOPED_TRACE() message header in example
PiperOrigin-RevId: 290800241
|
|
|
|
|
|
|
|
|
| |
Allow copying of the string in MatchAndExplain.
Otherwise, conversions from std::string_view to std::string will fail as being
explicit
PiperOrigin-RevId: 290301103
|
|\
| |
| |
| |
| |
| | |
bysreg:fix_noshortcircuitfailure_detectsflakyshortcircuit_test
PiperOrigin-RevId: 290256504
|
| |
| |
| |
| | |
gmock-matchers_test.cc
|
| |
| |
| |
| | |
DetectsFlakyShortCircuit when GTEST_HAS_RTTI is 1
|
|\ \
| | |
| | |
| | | |
PiperOrigin-RevId: 290255937
|
| |/
| |
| | |
Removing exclusion of *-main and*-all targets from the library.json used on platformio.
|
| |
| |
| |
| |
| |
| | |
Add extra filtering so that the reported message differentiates between the case where INSTANTIATE_TEST_SUITE_P is missing vs. the case where TEST_P is missing.
PiperOrigin-RevId: 290114508
|
| |
| |
| |
| |
| |
| | |
Correct the spelling of PARAMETERIZED.
PiperOrigin-RevId: 289897278
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Use GMOCK_PP to create GMOCK_INTERNAL_ACTION macro.
Create GMOCK_INTERNAL_ACTION macro that generates ACTION_P* macroses using
GMOCK_PP.
PiperOrigin-RevId: 289815906
|
| |
| |
| |
| |
| |
| | |
Wire up things to support marking a type paramaterized test as allowed to be un-instantiated.
PiperOrigin-RevId: 289699939
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Use GMOCK_PP to generate args boilerplate.
Move common args describing part to separate macroses that uses GMOCK_PP to
generate sequences.
PiperOrigin-RevId: 289655624
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add GTEST_ALLOW_UNINSTANTIATED_PARAMTERIZED_TEST to mark a paramaterized test as allowed to be un-instantiated.
This allows test suites, that are defined in libraries and, for other reasons, get linked in (which should probably be avoided, but isn't always possible) to be marked as allowed to go uninstantiated.
This can also be used to grandfather existing issues and expedite adoption of the checks with regards to new cases before they can be fixed.
PiperOrigin-RevId: 289581573
|
|/
|
|
|
|
| |
Change testing::TempDir() return value for Android
PiperOrigin-RevId: 289102017
|
|
|
|
|
|
|
|
| |
Removing GTEST_API from TrueWithString.
This type is only used in test code on one side of a DLL boundary so it is not
necessary.
PiperOrigin-RevId: 288927929
|
|
|
|
|
|
|
|
| |
Move part of functionality of Action* class to the base one. Reduce copypaste.
Make constructor and conversion operator of Action* class independent of pump.
PiperOrigin-RevId: 288907005
|
|
|
|
|
|
|
| |
Close #2658
Mark test case destrucors as override.
PiperOrigin-RevId: 288507991
|
|
|
|
|
|
|
|
| |
Use C++11 variadic templates for Invoke in gmock-generated-actions.h.
Replace InvokeArgumentAdl with Invoke that uses C++11 variadic templates.
PiperOrigin-RevId: 288449236
|
|
|
|
|
|
|
|
|
|
| |
Explicitly default copy constructor in BoundSecondMatcher
Since C++11, implicit defaulting of copy constructors is deprecated for types
with user-defined copy assignment operators, so we should explicitly default the
copy constructor of BoundSecondMatcher.
PiperOrigin-RevId: 287587847
|
|\
| |
| |
| | |
PiperOrigin-RevId: 287587126
|
| | |
|
| |
| |
| |
| |
| |
| | |
Add missing period.
PiperOrigin-RevId: 287553550
|
| |
| |
| |
| |
| |
| | |
Fix typo in example.
PiperOrigin-RevId: 287212448
|
|\ \
| | |
| | |
| | | |
PiperOrigin-RevId: 286896167
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Disable move operations for TEST() and TEST_F() macros.
Previous implementation disabled only copy ctor and assing operator, but
this was violating rule of 5[1], which was captured by static code analysis tools
like clang-tidy `cppcoreguidelines-special-member-functions`.
[1]: https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c21-if-you-define-or-delete-any-default-operation-define-or-delete-them-all
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add option (default to disabled) to make C++ type parameterized tests (TYPED_TEST_P) fail when they're not instantiated.
When an un-instantiated TYPED_TEST_P is found, a new test will be inserted that emits a suitable message. For now, that is just a notice, but the hope it to flip the bit to make it fail by default.
PiperOrigin-RevId: 286408038
|
|\ \ \
| | | |
| | | |
| | | | |
PiperOrigin-RevId: 286397298
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 20b5b8ecc7a81d23b4716e22a2b35fd53379c8c6.
Reason for revert: Breaks existing applications, such as ANGLE
(angleproject.org), requires adding an extra prefix that needs to be
typed for no reason (when testing from command line) and increases the
logs' sizes by a non-trivial amount due to the very large number of
tests ANGLE runs.
Original commit message:
Add a compile time check to ensure that the parameters to TEST_P and
INSTANTIATE_TEST_SUITE_P are not empty. Some compilers already fail
in that case and, even where it works, it's likely to result in
technically invalid code by virtue of creating reserved identifiers:
https://en.cppreference.com/w/cpp/language/identifiers
First, every project is perfectly capable of adding a prefix if they
want to support such a compiler. This change penalizes every
project.
Second, using a prefix such as `_p` also results in reserved
identifiers, so this change is not really solving the problem. For that
matter, instead of generating `gtest_##prefix##...`, you can generate
`gtest_x##prefix##...` to correctly fix the issue, including when empty
prefixes are used.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 4c25e2b87fcb78abcfdee2739db9ed7a19754cd3.
Reason for revert: Reverting the commit that disallows empty prefixes.
Original commit message:
Remove a test case rendered obsolete by disallowing empty argument for INSTANTIATE_TEST_SUITE_P.
Remove the code that it was testing.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Empty arguments can be passed to macros per C99 and C++11 specs, which
can then be forwarded to other macros.
Visual Studio's compiler has a bug in the following situation:
#define A(x) #x
#define B(x, y) A(x)
B(, b)
In the above case, Visual Studio first expands x to nothing, then
complains that A is not invoked with the right amount of arguments.
However, x in A(x) is still one argument, even if it expands to no
preprocessing tokens. See also https://stackoverflow.com/a/7674214.
|