summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Use GTEST_DISABLE_MSC_WARNINGS macros to disable warningsTom Hughes2023-01-3017-149/+72
| | | | | | | | | Prior to this change we had a mixture of pragmas and GTEST_DISABLE_MSC_WARNINGS; this change consolidates all instances to use the macros. PiperOrigin-RevId: 505786926 Change-Id: I2be8f6304387393995081af42ed32c2ad1bba5a7
* Use explicit short to fix MSVC compiler warningTom Hughes2023-01-301-4/+4
| | | | | | | | warning C4244: 'initializing': conversion from 'int' to 'short', possible loss of data PiperOrigin-RevId: 505774670 Change-Id: I3524040334a4b265bae12cfacdd2b615cbb1cfc8
* Merge pull request #4115 from SunBlack:codespellCopybara-Service2023-01-301-2/+2
|\ | | | | | | | | PiperOrigin-RevId: 505740434 Change-Id: I963f6a6b667a030c87f211173f578f7c35733e68
| * Fix typos found by codespellrefs/pull/4115/headSunBlack2023-01-041-2/+2
| |
* | Test current behavior of doubles and floats in RecordPropertyTom Hughes2023-01-273-4/+21
| | | | | | | | | | PiperOrigin-RevId: 505104193 Change-Id: I4c2758f22ee1321ed6b6662ab2668f6c5b6aa661
* | Fix formatting in Python filesTom Hughes2023-01-265-84/+158
| | | | | | | | | | PiperOrigin-RevId: 504890435 Change-Id: Ia9a89d0d7a07fe70c12f7f0202c8256c94d2f118
* | Fix Python docstrings to match style guideTom Hughes2023-01-267-33/+88
| | | | | | | | | | | | | | https://google.github.io/styleguide/pyguide.html#s3.8.3-functions-and-methods PiperOrigin-RevId: 504857416 Change-Id: I7815ce27e454a120b3974ae7e2bea952108b836c
* | Make document and example code more clear in the caveat section for ↵Abseil Team2023-01-261-5/+11
| | | | | | | | | | | | | | potential memory leak with `SetUpTestSuite`. PiperOrigin-RevId: 504706717 Change-Id: I5842a4569f81f6c0d636099b5cdaabe778996949
* | Use more specific assertLess instead of assertTrueTom Hughes2023-01-251-2/+1
| | | | | | | | | | PiperOrigin-RevId: 504670738 Change-Id: Ib68b676403204098e89f536f9b8317f9f717c24d
* | Fix pylint warningTom Hughes2023-01-251-15/+23
| | | | | | | | | | | | | | | | | | Possible unbalanced tuple unpacking with sequence defined at line N: left side has 1 label(s), right side has 0 value(s) [unbalanced-tuple-unpacking] PiperOrigin-RevId: 504640001 Change-Id: If8d6038a9acf74a409cb6b6ee30cea7745b4b303
* | Remove pylint disable comments that no longer trigger warningsTom Hughes2023-01-253-12/+3
| | | | | | | | | | PiperOrigin-RevId: 504633130 Change-Id: I3fdbc83975fea97aa53f7325d323adead0a30e24
* | Mention `DescribeMatcher` in matchers.mdAbseil Team2023-01-251-0/+12
| | | | | | | | | | PiperOrigin-RevId: 504591836 Change-Id: I48c93490d0c3b7c6bfaceceb1cef5eedeacfe6c6
* | Fix formatting in subset of Python filesTom Hughes2023-01-2524-1349/+1481
| | | | | | | | | | | | | | | | These files were formatted with automated tools. The remaining Python files require some manual fix ups, so they will be fixed separately. PiperOrigin-RevId: 504579820 Change-Id: I3923bd414bffe3ded6163ec496cd09ace3951928
* | Replace numeric lints with their string equivalentTom Hughes2023-01-252-6/+6
| | | | | | | | | | PiperOrigin-RevId: 504570278 Change-Id: Iab9c988b3a781eaafbdd97c924a74c2269125799
* | Fix formatting of C++ filesTom Hughes2023-01-2415-85/+84
| | | | | | | | | | PiperOrigin-RevId: 504325204 Change-Id: Iaa1d6d0ab1dccaaeef26f9cb109d530835499240
* | Fix formatting of Markdown filesTom Hughes2023-01-242-15/+39
| | | | | | | | | | PiperOrigin-RevId: 504308485 Change-Id: Ia4ae97b2173b44b89aa5d987ddefd6e0c1488386
* | Remove FloatingPoint::Max() in favor of std::numeric_limits::max()Derek Mauro2023-01-242-15/+3
| | | | | | | | | | | | | | | | | | | | | | In #4113 a user says Max clashes with a macro. Since it is only used in a test, use std::numeric_limits::max() instead. Note that in headers, the macro issue can be mitigated with parenthesis like this: `(std::numeric_limits<T>::max)()` PiperOrigin-RevId: 504284906 Change-Id: Ibf430caec1a6afdf6b303534fec6a4fd00a6373f
* | Mention using MockFunction as a way to mock free functions.Abseil Team2023-01-181-0/+4
| | | | | | | | | | PiperOrigin-RevId: 502901538 Change-Id: I0cf351b9ad1411ae9c45e09550c24e006a24e179
* | Replace deprecated python callsTom Hughes2023-01-1715-186/+272
| | | | | | | | | | | | | | | | assert_ -> assertTrue/assertFalse/assertIn/assertNotIn assertEquals -> assertEqual PiperOrigin-RevId: 502654909 Change-Id: I25d30095a83c3806606cb80d676b3c979495e6bd
* | Announce that GitHub actions are not GoogleTest's canonical CIDino Radakovic2023-01-171-0/+7
| | | | | | | | | | PiperOrigin-RevId: 502654465 Change-Id: I51269e8c389ad63f3737132feec1b6d20dc4c314
* | Fix -Wimplicit-int-float-conversion warningTom Hughes2023-01-171-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're intentionally losing precision in this case, so add a cast. googletest/googletest/include/gtest/gtest-printers.h:532:9: error: implicit conversion from 'int32_t' (aka 'int') to 'float' may lose precision [-Werror,-Wimplicit-int-float-conversion] if (static_cast<int32_t>(val * mulfor6 + 0.5) / mulfor6 == val) return 6; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~ googletest/googletest/include/gtest/gtest-printers.h:544:9: error: implicit conversion from 'int32_t' (aka 'int') to 'float' may lose precision [-Werror,-Wimplicit-int-float-conversion] if (static_cast<int32_t>(val / divfor6 + 0.5) * divfor6 == val) return 6; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~ PiperOrigin-RevId: 502646042 Change-Id: I05989ee42675b531a9907616c9582a5a7c77bed6
* | Update documentation for v1.13.0Derek Mauro2023-01-172-6/+5
| | | | | | | | | | PiperOrigin-RevId: 502644180 Change-Id: Id20b5e4eec22035da278f1767002657f66dbe79c
* | Bump version to 1.13.0 in preparation for releasev1.13.0-prev1.13.0v1.13.xDerek Mauro2023-01-171-1/+1
| | | | | | | | | | PiperOrigin-RevId: 502626077 Change-Id: I3aad27a8b725cf73163e52ef2e28e6cdfc13082b
* | gmock_output_test: normalize golden file output to unix line endingsAbseil Team2023-01-171-0/+3
| | | | | | | | | | | | | | | | When checked out on Windows, the repo might use \r\n line endings, and so the golden output has them. Adjust for that. PiperOrigin-RevId: 502577222 Change-Id: Iabfe537f6d95a49bf6bdcb934e855d28c65f6f89
* | Fix -Wshadow warningsTom Hughes2023-01-121-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ../googlemock/test/gmock-actions_test.cc:687:36: warning: declaration of ‘v’ shadows a member of ‘testing::{anonymous}::ReturnTest_SupportsReferenceLikeReturnType_Test::TestBody()::Result’ [-Wshadow] 687 | Result(const std::vector<int>& v) : v(&v) {} // NOLINT | ~~~~~~~~~~~~~~~~~~~~~~~~^ ../googlemock/test/gmock-actions_test.cc:686:29: note: shadowed declaration is here 686 | const std::vector<int>* v; | ^ ../googlemock/test/gmock-actions_test.cc: In constructor ‘testing::{anonymous}::ReturnTest_PrefersConversionOperator_Test::TestBody()::Out::Out(int)’: ../googlemock/test/gmock-actions_test.cc:720:28: warning: declaration of ‘x’ shadows a member of ‘testing::{anonymous}::ReturnTest_PrefersConversionOperator_Test::TestBody()::Out’ [-Wshadow] 720 | explicit Out(const int x) : x(x) {} | ~~~~~~~~~~^ ../googlemock/test/gmock-actions_test.cc:718:9: note: shadowed declaration is here 718 | int x; | ^ PiperOrigin-RevId: 501580618 Change-Id: I584710fbbe440ec724f88746e51f3be5653c32d5
* | Add an explicit #error that C++ versions less than C++14 are not supportedDerek Mauro2023-01-121-0/+13
| | | | | | | | | | PiperOrigin-RevId: 501568410 Change-Id: I0f78cd96dc9204c8ec97a1cdd09a9d63a613cc5b
* | Update GoogleTest dependenciesDerek Mauro2023-01-111-24/+20
| | | | | | | | | | PiperOrigin-RevId: 501282034 Change-Id: I0314ac566dc5e117db5a06c97d303e5cf8822d61
* | Fix GTEST_OS_ESP8266 checkTom Hughes2023-01-051-1/+1
| | | | | | | | | | | | | | | | Everywhere else in the code, we check the value of GTEST_OS_ESP8266, not just whether it is defined. PiperOrigin-RevId: 499946909 Change-Id: I86f7e8947abb4e928fc24d1416d8237987b27845
* | IWYU: Add missing std includesTom Hughes2023-01-0522-0/+38
| | | | | | | | | | PiperOrigin-RevId: 499893032 Change-Id: I33304802b7c82ae2d008f3ee89df38866e5f57ba
* | Workaround for GCC12 bug illustrated by https://godbolt.org/z/Pe5aE59xGDerek Mauro2023-01-041-1/+2
|/ | | | | | | Fixes #4108 PiperOrigin-RevId: 499556061 Change-Id: I1cb1564f9b77e1825fddc9236965f4a3b661d96a
* Fix _MSC_VER checkTom Hughes2023-01-041-1/+1
| | | | | | | Use "#if defined(_MSC_VER)" instead of "#if _MSC_VER" to be consistent with other usages in the file and to work with the "-Wundef" warning. PiperOrigin-RevId: 499471290 Change-Id: I34a9442eecf266afd74d4332cab7d39766df4ed9
* Use a more recent commit of googletest that uses OS constraints fromAbseil Team2022-12-221-7/+6
| | | | | | | | | | | | | @platforms//os:* instead of from @build_tools//platforms:* See https://github.com/bazelbuild/bazel/issues/8622 Necessary to fix #4096 Also need the fix for #4098 PiperOrigin-RevId: 497182073 Change-Id: Ifd568b088d2f779755dd20264edfd5dad12ca9cc
* Fix a typo in the documentation for "Using Predicates as Matchers".Abseil Team2022-12-201-1/+1
| | | | | PiperOrigin-RevId: 496679950 Change-Id: I2842050902876231d49a142165bcbb88d737505d
* Comment that q0_ in primer should remain emptyDino Radakovic2022-12-201-0/+1
| | | | | PiperOrigin-RevId: 496642643 Change-Id: I178efeda76cbf46e5f4bb91454c205b9a060a4ea
* Specify a name for a `Property` in a code example.Abseil Team2022-12-191-1/+1
| | | | | | | It is good practice to specify a name for the `testing::Property` matcher's use in diagnostics, and we should do so in our examples. PiperOrigin-RevId: 496406309 Change-Id: Ibb4d1ba63771b5d6855442b91564027cda8ddaca
* Shut up a Clang warning.Abseil Team2022-12-151-1/+6
| | | | | | | | | | | | | | | Clang warns on this pattern because it looks like the author might have meant to use the value of the first part of the comma operator, so it warns that it isn't being used. The cast here signals to Clang that this behavior is intentional. This was discovered while updating gmock in Android. Clang's -Wcomma warning is on by default with either -Wall or -Werror, so users of gmock with those on in combination with -Werror are unable to build without this fix. PiperOrigin-RevId: 495655990 Change-Id: Iaf27e2199669f5b6185a877738234e551b6b6556
* Fix a typo in the gMock sample code for Defining a Custom Matcher Class.Abseil Team2022-12-141-1/+1
| | | | | | | EXPECT_CALL doesn't seem to make much sense here. I think the intent was to use EXPECT_THAT instead. PiperOrigin-RevId: 495427663 Change-Id: I39a16ea37282729d34017c6bcd331a60cedf1fbe
* Convert feature requests to a formDerek Mauro2022-12-122-24/+33
| | | | | PiperOrigin-RevId: 494820396 Change-Id: I1aa0a5a0f4796fde8d0424093370fd89ebd2592e
* Refactor matrix verification into VerifyMatchMatrix.refs/pull/4082/headAbseil Team2022-12-122-17/+17
| | | | | PiperOrigin-RevId: 494786543 Change-Id: I7769558dd2ca046d8957bf352dc04cfb48ff7c3a
* Introduces a new porting flag (GTEST_HAS_FILE_SYSTEM) to indicate whether a ↵Abseil Team2022-12-125-40/+115
| | | | | | | platform supports filesystem operations. PiperOrigin-RevId: 494751986 Change-Id: I07f73bdf478a73934b8f1a69c1ab4abda1b231ae
* Fall back to the system clock when building with newlib on a system without ↵Tom Hughes2022-12-081-3/+10
| | | | | | | a monotonic clock. PiperOrigin-RevId: 493917905 Change-Id: I20137cfcda3671ffc8edcda2b6554aa392e3a00a
* Migrate GoogleTest to a bug report template and add a link to the discussionDerek Mauro2022-12-073-43/+57
| | | | | | | forum for non-bugs PiperOrigin-RevId: 493632811 Change-Id: I7e02c3c479c2a925b7971f6a55e1e95a5a6f2d0a
* Remove the unused class TestNameIsDerek Mauro2022-12-061-31/+0
| | | | | | | Fixes #4076 PiperOrigin-RevId: 493158910 Change-Id: Id66c0443a6f5f4d167ae39ac79766b32cf95a383
* Make SizeIsMatcher::Impl conform to the contract of MatcherDescriberInterface.Abseil Team2022-11-302-4/+4
| | | | | | | MatcherDescriberInterface specifies that DescribeTo "should print a verb phrase", but "size ..." is not a verb phrase. Currently, ElementsAre(SizeIs(9)) is described as "has 1 element that size is equal to 9". With this change, it will be described as "has 1 element that has a size that is equal to 9". PiperOrigin-RevId: 492022324 Change-Id: I4083335f2419462464957521c1e033643b53b763
* Disables `-Wunused-member-function` and `-Wused-but-marked-unused` that ↵Abseil Team2022-11-295-3/+59
| | | | | | | | trigger via `MOCK_METHOD()` and `EXPECT_THAT()` macros. Fixes: #4052, #4055 PiperOrigin-RevId: 491647393 Change-Id: I8e2ad838156fa8c7e9dccd1740af797e694992b6
* This commit fixes a minor verb conjugation error in gmock_cook_book.md.Abseil Team2022-11-231-1/+1
| | | | | PiperOrigin-RevId: 490601453 Change-Id: I733b2ed8740b1c809dddb166a42993b869198469
* Merge pull request #4066 from zloylos:doc/make_uniqCopybara-Service2022-11-212-5/+5
|\ | | | | | | | | PiperOrigin-RevId: 490057649 Change-Id: Ia788d55cfbc576e841064b8e907f8671cc46f3bf
| * Change MakeUnique -> std::make_unique in docsrefs/pull/4066/headDenis Hananein2022-11-202-5/+5
|/
* When printing floating-point numbers, print full precision by default.Abseil Team2022-11-162-1/+84
| | | | | | | | | | | To make debug output readable, we still use the faster 6-digit precision sometimes, but only if it will round-trip. This way, when a test fails due to a very small difference in floating-point numbers, users will have enough digits to see the difference. PiperOrigin-RevId: 488958311 Change-Id: Ibcac43f48a97006d89217530c69386cc4fa2735c
* Remove incorrect usage of GTEST_ATTRIBUTE_UNUSED_ on classes.Abseil Team2022-11-154-15/+7
| | | | | | Fixes: #4054 PiperOrigin-RevId: 488721587 Change-Id: I8742d8475376635c83edcf524796a6107042e89b