summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge pull request #4374 from masbug:mainCopybara-Service2023-09-251-4/+5
|\ \ | | | | | | | | | | | | PiperOrigin-RevId: 568317621 Change-Id: Icf7fb519f96f5e88eb0df491eed143134c8ac6eb
| * | Fix compile warnings in gmock-function-mocker.hrefs/pull/4374/headMitja Spes2023-09-211-4/+4
| | | | | | | | | | | | | | | Template type int changed to size_t. This fixes compile warning `conversion to ‘long unsigned int’ from ‘int’ may change the sign of the result` in gmock-function-mocker.h.
* | | Update C++ feature detection in `gtest-port.h` to rely on feature test ↵Abseil Team2023-09-221-24/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | macros where possible. This also avoids conflating C++ language versions with standard library versions, which don't always align. PiperOrigin-RevId: 567662118 Change-Id: I7c023bd043c81c540c9430eaeb7b450feaadb206
* | | Use `absl::HasAbslStringify`, instead of the internal version.Abseil Team2023-09-212-15/+13
| | | | | | | | | | | | | | | PiperOrigin-RevId: 567349341 Change-Id: I35f2679901aecbe9cb90d2e78ff28c5e383e7257
* | | googletest: Update absl to version with HasAbslStringifyDino Radakovic2023-09-211-4/+4
|/ / | | | | | | | | | | | | https://github.com/abseil/abseil-cpp/commit/9e1789ffea47fdeb3133aa42aa9592f3673fb6ed PiperOrigin-RevId: 567324946 Change-Id: I8adc5803a81075a635dad79aa0312d4455e1ad63
* | Update code with IWYU annotations.Abseil Team2023-09-181-7/+7
| | | | | | | | | | PiperOrigin-RevId: 566424331 Change-Id: I0e16d979b9d79643c882c5082e154842983a5317
* | Use the `empty()` method to check for emptiness instead of `length()`Abseil Team2023-09-182-2/+2
| | | | | | | | | | PiperOrigin-RevId: 566247438 Change-Id: I8199ef53310a057abbe23f8f4295507b60d6b707
* | GoogleTest FAQ: minor punctuation fixesrefs/pull/4362/headMichael Hirshleifer2023-09-141-15/+15
| | | | | | | | | | PiperOrigin-RevId: 565411290 Change-Id: I57e94c679183e39eec2a2835f330b52fc9302767
* | Remove Googletest FAQ entry for obsolete `ProtocolMessageEquals` and ↵Michael Hirshleifer2023-09-141-21/+0
| | | | | | | | | | | | | | | | | | | | `ProtocolMessageEquiv` * These long-dead variants of the proto matchers don't exist in the current version of Googletest. * No evidence of external usage: [the only external references I see](https://www.google.com/search?q=%22protocolmessageequals%22+OR+%22protocolmessageequals%22) are copies of this guide. Possibly they were already removed by the time Googletest was publicly released. PiperOrigin-RevId: 565358401 Change-Id: I61379b7333fa8ee19cd5520caedf2c539f54c2d7
* | Merge pull request #4342 from tanzislam:prefer-tmpdir-on-androidCopybara-Service2023-09-141-8/+24
|\ \ | | | | | | | | | | | | PiperOrigin-RevId: 565230380 Change-Id: I6e91eea46d05413d4d87e73a11941786604d9f27
| * | Reuse TempDir() functionrefs/pull/4342/headTanzinul Islam2023-08-261-4/+1
| | |
| * | Prefer $TMPDIR to /data/local/tmp on AndroidTanzinul Islam2023-08-181-1/+7
| | | | | | | | | Newer devices can have the latter location read-only. (I observed this with Termux on a non-rooted Pixel 6.)
* | | Merge pull request #4365 from tanzislam:fix-thread-count-after-thread-creationCopybara-Service2023-09-111-3/+3
|\ \ \ | | | | | | | | | | | | | | | | PiperOrigin-RevId: 564472305 Change-Id: I8db9bc0ba0768e7ab9c67f36d9db87edbbf14f10
| * | | Count threads after thread-creation while still holding mutex lockrefs/pull/4365/headTanzinul Islam2023-09-031-3/+3
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `Mutex` is locked with the `MutexLock` before spawning the thread, so that the thread is prevented from completing (by being blocked on `Mutex`) before the new thread count is obtained. However, the existing bug (introduced in 22e6055) releases `Mutex` before obtaining the new thread count, which allows the thread to run to completion in the meantime. Also, since the `(thread_count_after_create != starting_count + 1)` condition (line 328) skips the remainder of the `for`-loop body on every iteration, `thread_count_after_join` stays uninitialized. I believe this is why [this test failed][1] on the macOS CI with this trace: ``` [----------] 1 test from GetThreadCountTest [ RUN ] GetThreadCountTest.ReturnsCorrectValue googletest/test/googletest-port-test.cc:350: Failure Expected equality of these values: thread_count_after_create Which is: 1 starting_count + 1 Which is: 2 googletest/test/googletest-port-test.cc:351: Failure Expected equality of these values: thread_count_after_join Which is: 140493185949400 starting_count Which is: 1 [ FAILED ] GetThreadCountTest.ReturnsCorrectValue (2 ms) [----------] 1 test from GetThreadCountTest (2 ms total) ``` [1]: https://github.com/google/googletest/actions/runs/6064919420/job/16453860690?pr=3049
* | | googletest: Add universal printer for `std::span`Dino Radakovic2023-08-253-2/+53
| | | | | | | | | | | | | | | | | | | | | Fixes #4318 PiperOrigin-RevId: 560089120 Change-Id: I9d0d098140033520266747a1689e953ee8307c47
* | | Merge pull request #4349 from sthd:httpToHttpsCopybara-Service2023-08-2311-20/+20
|\ \ \ | | | | | | | | | | | | | | | | PiperOrigin-RevId: 559452348 Change-Id: I6f72001fd6b8e5a739c34121c8847c281d563b0f
| * | | changed http to httpsrefs/pull/4349/headsthd2023-08-2211-21/+21
|/ / /
* | | Merge pull request #4343 from sthd:http-to-httpsCopybara-Service2023-08-223-11/+11
|\ \ \ | | | | | | | | | | | | | | | | PiperOrigin-RevId: 559151399 Change-Id: I8eb2c7c5222d0fd0935db531a0abe5792633fe7e
| * \ \ Merge branch 'google:main' into http-to-httpsrefs/pull/4343/headElior Schneider2023-08-201-1/+2
| |\ \ \
| * | | | Update advanced.mdElior Schneider2023-08-201-1/+1
| | | | | | | | | | | | | | | http to https
| * | | | Merge branch 'google:main' into http-to-httpsElior Schneider2023-08-183-44/+28
| |\ \ \ \ | | | |/ / | | |/| |
| * | | | Changed 2 public links from http to httpssthd2023-08-111-2/+2
| | | | |
| * | | | Changed 3 public links from http to httpssthd2023-08-111-3/+3
| | | | |
| * | | | Changed 2 public links from http to httpssthd2023-08-111-2/+2
| | | | |
| * | | | Changed 3 public links from http to httpssthd2023-08-111-3/+3
| | | | |
* | | | | googletest: Replace http with https in links to docsDino Radakovic2023-08-222-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a prerequisite for #4341 PiperOrigin-RevId: 559132807 Change-Id: Iadc961913e0ff107c5333dae17be5f8638663836
* | | | | CI: Update the Linux hybrid-latest docker container used for testingDerek Mauro2023-08-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following are the major updates * LLVM 17 branch (https://github.com/llvm/llvm-project b744f4c99cf91155c74a3c92db6f1335232ff3d) * GCC 13.2 * CMake 3.27.1 * Bazel 6.2.1 PiperOrigin-RevId: 558818264 Change-Id: Ib08d8331e2a8b2d68a702670451beaaac5d266f4
* | | | | Clean up typos: Exhaused => ExhaustedAbseil Team2023-08-211-1/+1
| |_|/ / |/| | | | | | | | | | | | | | | PiperOrigin-RevId: 558801066 Change-Id: Ia225d12014748db87639414f4c8c28a0d0e9e489
* | | | Merge pull request #4322 from pgawro:ansi_colorsCopybara-Service2023-08-181-1/+2
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | PiperOrigin-RevId: 558224853 Change-Id: Ib2d8ad41fcc4d38f58aa5702b537467d8867d82e
| * | | googletest: ansi color fixrefs/pull/4322/headPatryk Gawroński2023-08-161-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds prevents from returning nullptr by choosing default color. Issue: #4321
* | | | Improve error message for invalid parameterized test names.Abseil Team2023-08-171-1/+3
| | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 557910190 Change-Id: Ia965a6c96e4cc5997d8af2611abc62c42e81653e
* | | | Merge pull request #4333 from ngie-eign:gtest_help_test-fix-FreeBSDCopybara-Service2023-08-151-3/+14
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 557197748 Change-Id: I55b86353f5351bbcbdf8e6bca70e82d7383a5080
| * | | | Fix GTestHelpTest.TestHelpFlag on FreeBSDrefs/pull/4333/headEnji Cooper2023-08-081-3/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test supported a variety of BSDs, including kFreeBSD, but not FreeBSD. Move the BSD checks to a separate function and support checking for FreeBSD, in addition to kFreeBSD. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
* | | | | gtest_help_test: Make method names `snake_case`, conforming with [the style ↵Dino Radakovic2023-08-151-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | guide](https://google.github.io/styleguide/pyguide#316-naming) PiperOrigin-RevId: 557133618 Change-Id: I27202ee91ee81b3d2e4c28102190d2bde8efba05
* | | | | gtest_help_test: Inline test helper functionsDino Radakovic2023-08-151-23/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `TestNonHelpFlag` is only a few asserts with no logic, which is easier to read in line, and helper `TestHelpFlag` is used in a single test case. PiperOrigin-RevId: 557122793 Change-Id: I7367424abfbb883c10c260fae066a2071e5dfa0e
* | | | | Merge pull request #4334 from ngie-eign:fix-RETest-non-ABSLCopybara-Service2023-08-151-2/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 557122083 Change-Id: I77fb7fe99baf9cbf341ad37d4b651a0ac606b549
| * | | | | Fix RETest/1.ImplicitConstructorWorks on non-ABSL platformsrefs/pull/4334/headEnji Cooper2023-08-081-2/+2
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The last regular expression specified in the test is not technically POSIX compatible. Use `[[:alnum:]_]` instead of `\w+`; the latter is a Perl-compatible regular expression. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
* | | | | gtest_help_test: Delete obsolete helper `TestUnknownFlagWithAbseil`Dino Radakovic2023-08-151-13/+0
| |_|/ / |/| | | | | | | | | | | | | | | PiperOrigin-RevId: 557116814 Change-Id: I91e06b0d6001952366c50201b67491475a1f98af
* | | | Specify SetUpTestSuite is required to be public.Abseil Team2023-08-101-4/+4
| | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 555578256 Change-Id: I9366fc99ae953c29e468fcddb4be203c9c05661b
* | | | Merge pull request #4330 from IncludeGuardian:remove-iomanipCopybara-Service2023-08-082-6/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 554867591 Change-Id: Ib32da50384951532419cb54fb70f8ab0920178d7
| * | | | Remove public includes of `<iomanip>`refs/pull/4330/headElliot Goodrich2023-08-032-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit removes `<iomanip>` from public GoogleTest header files. As `<iomanip>` is not a common included file, its content is unlikely to be included in translation units other than through GoogleTest includes. By reducing the number of include directives public headers in GoogleTest, this may reduce the time taken to compile tests as it would reduce the amount of work that the preprocessor and compiler front-end need to do.
* | | | | Merge pull request #4328 from robert-shade:suppress_unreachable_warningCopybara-Service2023-08-071-1/+7
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | PiperOrigin-RevId: 554578443 Change-Id: Ib5b03605c30fc2974b9597860577ff89532eedcd
| * | | | Avoid unreachable code warningrefs/pull/4328/headRobert Shade2023-08-021-1/+7
| | | | |
* | | | | Make references to `#include`s consistent across docsDino Radakovic2023-08-073-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 554561504 Change-Id: Ia02ab6ac646bf6637d6f500a4aaedd14e0a04798
* | | | | Merge pull request #4323 from ↵Copybara-Service2023-08-031-1/+1
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | pgawro:gtest_ExpectThrowTest_DoesNotGenerateUnreachableCodeWarning PiperOrigin-RevId: 553485739 Change-Id: I6581215e6db514397177af39381eea4d121f32bd
| * | | | gtest: Supress warning about set unused variablerefs/pull/4323/headPatryk Gawroński2023-07-261-1/+1
| | |/ / | |/| | | | | | | | | | Modified test ExpectThrowTest.DoesNotGenerateUnreachableCodeWarning
* | | | Update documentation to refer to v1.14Derek Mauro2023-08-022-5/+5
| | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 553172719 Change-Id: Ie09afa3788c8ed5c95913d8ca0b436f1df28241a
* | | | Bump version to v1.14 in preparation for releasev1.14.0-prev1.14.0v1.14.xDerek Mauro2023-08-021-1/+1
| | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 553152072 Change-Id: I0bfbb2da6b3902fc3e41a8e1c4aacb291ffdd098
* | | | Remove the GTEST_HAS_DOWNCAST_ customization point.Derek Mauro2023-08-021-14/+4
| | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 553150809 Change-Id: I10d19a45a85c5f63a5e65dc322413307116e1c25
* | | | Add googletest-message-test to the Bazel testsDerek Mauro2023-08-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It appears to have been unintentionally left out PiperOrigin-RevId: 553141410 Change-Id: I8adac55a3df0ec12d6fe03446f71858fc702e178