| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
while this is not synced with the pkg-config file, it only breaks things
Fix #2174
Signed-off-by: Ayush Joshi <ayush854032@gmail.com>
|
|
|
|
|
|
|
|
|
| |
unifying the behavior between Bazel and CMake
This fixes one of the CI failures on Windows
PiperOrigin-RevId: 417872531
Change-Id: I156989323b7e6d4a4420f4f9691b078829db933d
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove -Werror from the CMake compiler flags
We should not force warnings as errors on users.
Sometimes compilers introduce new warnings which
will break builds.
Instead, we manually turn this flag on in our continuous integration
scripts so we can catch these errors, but not force them on our users.
Fixes #3447
PiperOrigin-RevId: 380241852
|
|\
| |
| |
| | |
PiperOrigin-RevId: 365572439
|
| |
| |
| |
| | |
Fixes #3125
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Print std::u8string, std::u16string, and std::u32string as string literals
Previously, these types were printed as "{ U+123, U+456, U+789 }". However,
printed output in that form is difficult to compare against any literals that
might be defined in code. Instead, just treat these types like std::string
and std::wstring, escaping non-ASCII characters with a hexadecimal escape
sequence.
The tests have also been updated to cover the new functionality: as a bonus,
the tests now also pass with the MSVC toolchain.
Internally, the code has been reorganized to primarily operate in terms of
char32_t, under the assumption that char32_t will always be at least as big
as wchar_t. While that assumption is currently true, perhaps it won't be in
the future...
PiperOrigin-RevId: 364033132
|
|/
|
|
|
|
|
|
|
|
|
| |
This is incompatible with compiler caches such as sccache and
clcache. If a project including Google Test specifies /Z7 instead,
building fails with:
sccache C:\PROGRA~2\MICROS~1\2019\ENTERP~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\cl.exe /nologo /TP -D__SSE2__ -D__SSE__ -I..\lib\googletest-1.10.x\googlemock\include -I..\lib\googletest-1.10.x\googlemock -I..\lib\googletest-1.10.x\googletest\include -I..\lib\googletest-1.10.x\googletest /DWIN32 /D_WINDOWS /W4 /GR /MD /Z7 /O2 /Ob1 /DNDEBUG -GS -W4 -WX -wd4251 -wd4275 -nologo -J -Zi -D_UNICODE -DUNICODE -DWIN32 -D_WIN32 -DSTRICT -DWIN32_LEAN_AND_MEAN -wd4702 -DGTEST_HAS_PTHREAD=0 -EHsc -D_HAS_EXCEPTIONS=1 /Gy /showIncludes /Folib\googletest-1.10.x\googlemock\CMakeFiles\gmock_main.dir\src\gmock-all.cc.obj /Fdbin\gmock_main.pdb /FS -c ..\lib\googletest-1.10.x\googlemock\src\gmock-all.cc
FAILED: lib/googletest-1.10.x/googlemock/CMakeFiles/gmock_main.dir/src/gmock-all.cc.obj
..\lib\googletest-1.10.x\googletest\src\gtest-all.cc: fatal error C1041: cannot open program database 'D:\a\mixxx\mixxx\build\bin\gmock_main.pdb'; if multiple CL.EXE write to the same .PDB file, please use /FS
cl : Command line warning D9025 : overriding '/Z7' with '/Zi'
|
|\
| |
| |
| | |
PiperOrigin-RevId: 342977338
|
| |
| |
| |
| |
| | |
Use `find_package(Python ..)` if available, instead of the deprecated
`find_package(PythonInterp)` CMake module.
|
|/
|
|
|
|
|
|
|
|
|
|
| |
Rollback change from
https://github.com/google/googletest/pull/1836. This change generates
a script on Windows to actually run each test, but the script itself
doesn't correctly report if the test passed.
This change will "break tests" that were already broken on Windows,
but weren't being reported as such.
PiperOrigin-RevId: 341850671
|
|
|
|
|
| |
If target_compile_features is available and cxx_std_11.
This fix compilation with clang and gcc when c++11 isn't specified by user.
|
|
|
|
| |
without interpreting it as a variable.
|
|
|
|
|
|
|
|
|
|
|
| |
Cast some values as their unsigned equivalents or `size_t` to match the
parameter type used for the template object under test. Also, provide
UInt32 equivalent delegate methods for some callers (with
int-equivalents for backwards compatibility).
This closes #2146.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|\
| |
| |
| | |
PiperOrigin-RevId: 242038269
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add `-frtti` to the compiler with the base flags case so that RTTI is
enabled by default with clang. Add its inverse analog,
`cxx_no_rtti_flags` in order to test the case with RTTI off, similar to
gcc.
This reduces the amount of testing/support overhead needed in the
non-RTTI case with clang, as the tests currently fail when these two
features are off with version 1.8.1. This something I used in when
investigating test failures on FreeBSD, as the tests that rely on
RTTI were failing with googletest 1.8.1 on the OS platform.
More investigation is being done to determine how this should be fixed
on FreeBSD 11.2-RELEASE with ports, as the package doesn't currently
compile the tests, and when enabled (based on my WIP diff), the tests
fail in similar ways.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|\
| |
| |
| | |
PiperOrigin-RevId: 235220570
|
| |
| |
| |
| | |
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|/
|
|
|
|
|
|
|
|
| |
clang++ compilation when `-Wsign-conversion` is currently broken and the
issues within the code are varied and widespread. For the time being
ignore `-Wsign-conversion` issues, even though some of them are valid
and bleed over into issues that would be found with
`-Wtautological-compare`, et al.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|
|
|
|
|
| |
It was not compiling any of the code with warnings prior to this.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|
|
|
| |
MD(d)->MT(d) in both C and CXX flags, resolves 2074
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
658c6390a5b363f46c6ad448ad1bce9d6e97e53a
Closes #1893
PiperOrigin-RevId: 216712426
|
|
|
|
|
|
| |
Remove all mention of TR1 tuple and our own implementation of tuple.
PiperOrigin-RevId: 216395043
|
|
|
|
|
|
|
|
| |
e93da23920e5b6887d6a6a291c3a59f83f5b579e
Closes #1836
PiperOrigin-RevId: 215461025
|
|\ |
|
| |
| |
| |
| | |
Rework of the closed pull request #768
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | | |
This prevents warning D9025 (one command-line option overrides
another) on MSVC builds: some test targets are built with
the /EHs-c- which conflicts with /EHsc.
|
| |/
|/|
| |
| |
| |
| |
| |
| | |
nested cmake project,
which breaks my build as gcc does not allow -specs=nosys.specs to be called multiple times.
Removing this fixes it and seems to keep the same compile options, just removing the duplicate definition.
|
|\ \ |
|
| | | |
|
| |/
| |
| |
| |
| | |
This does the same thing to the CMake tests that is done to the
Bazel tests, and now makes the CMake tests pass.
|
| |\ |
|
| | |\ |
|
| | | | |
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
CMAKE_DEBUG_POSTFIX is a global configuration parameter, and
changing it pollutes the configuration space for other projects
that enclose this project.
DEBUG_POSTFIX is better to use since it is a target-specific poperty.
Fixes #1334
Fixes #1268
|
| |/ |
|
| | |
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If the user's cmakelists.txt first look for threads using
find_package(Threads), then set(gtest_disable_pthreads ON),
and then include googletest. GoogleTest will not look for
threads. But since they have already been found before in
user's cmakelists, it will use them regardless.
This helped me fix build issue in darktable-org/rawspeed
on windows/MSYS2, even though there are threads, and they
are usable, googletest build was failing with issues
about AutoHandle. I was first looking for threads, and only
then including googletest, so no matter the value of
gtest_disable_pthreads, it failed.
The other obvious solution is for user to first include
googletest, and only then look for threads by himself.
|
| |/ |
|
| |
| |
| |
| | |
generators
|
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 73d58dd4c83883b46697798e978d576b28b1d24e.
Unfortunately, ${CMAKE_CFG_INTDIR} is set during build only and doesn't
help here.
|
| |
| |
| |
| |
| |
| |
| | |
On single-configuration build systems as Makefile Generators, there is
no subdirectory for the configuration in the build tree - therefore ask
cmake for the subdir by using CMAKE_CFG_INTDIR, which is just '.' on
single-configuration build systems (Linux et al.).
|
| | |
|
| | |
|
|/
|
|
|
| |
Replaced legacy syntax of cmake add_test() with more modern syntax.
This allows running gtests's own tests on remote (cross) systems
using CMAKE_CROSSCOMPILING_EMULATOR with cmake-3.3 or newer.
|
|\
| |
| | |
Fix compilation of googletest with MinGW using Win32 threads
|