| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
The change makes implicit assumptions on the layout of the install
tree, which is going to break in many ways.
The correct solution is to use the `PKG_CONFIG_SYSROOT_DIR` variable
to inject the cross-compiled sysroot into `-I` and `-L` paths.
|
|
|
|
| |
without interpreting it as a variable.
|
|
|
|
|
|
|
|
|
|
|
| |
Cast some values as their unsigned equivalents or `size_t` to match the
parameter type used for the template object under test. Also, provide
UInt32 equivalent delegate methods for some callers (with
int-equivalents for backwards compatibility).
This closes #2146.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|\
| |
| |
| | |
PiperOrigin-RevId: 242038269
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add `-frtti` to the compiler with the base flags case so that RTTI is
enabled by default with clang. Add its inverse analog,
`cxx_no_rtti_flags` in order to test the case with RTTI off, similar to
gcc.
This reduces the amount of testing/support overhead needed in the
non-RTTI case with clang, as the tests currently fail when these two
features are off with version 1.8.1. This something I used in when
investigating test failures on FreeBSD, as the tests that rely on
RTTI were failing with googletest 1.8.1 on the OS platform.
More investigation is being done to determine how this should be fixed
on FreeBSD 11.2-RELEASE with ports, as the package doesn't currently
compile the tests, and when enabled (based on my WIP diff), the tests
fail in similar ways.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|\
| |
| |
| | |
PiperOrigin-RevId: 235220570
|
| |
| |
| |
| | |
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|/
|
|
|
|
|
|
|
|
| |
clang++ compilation when `-Wsign-conversion` is currently broken and the
issues within the code are varied and widespread. For the time being
ignore `-Wsign-conversion` issues, even though some of them are valid
and bleed over into issues that would be found with
`-Wtautological-compare`, et al.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|\
| |
| |
| | |
PiperOrigin-RevId: 233773676
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When building and using googletest from an install tree
we want libtool to generate rpath in the dependent binaries
to allow them to be executed from a build without a need
for LD_LIBRARY_PATH or similar.
For libtool based project this happens automatically
as projects generates .la files and install them.
Provide such a file for gtest as well to allow it to
work smoothly with libtool based projects.
Signed-off-by: Knut Omang <knut.omang@oracle.com>
|
|/
|
|
|
|
| |
It was not compiling any of the code with warnings prior to this.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|
|
|
| |
MD(d)->MT(d) in both C and CXX flags, resolves 2074
|
|
|
|
|
|
| |
Internal Change
PiperOrigin-RevId: 225231727
|
| |
|
|
|
|
|
|
| |
Internal Change
PiperOrigin-RevId: 222123106
|
| |
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
658c6390a5b363f46c6ad448ad1bce9d6e97e53a
Closes #1893
PiperOrigin-RevId: 216712426
|
|/
|
|
|
|
|
| |
Using absolute paths in the pkg-config file makes it not relocatable and
leads to problems, when trying to use it with precompiled cross
toolchains. Setting prefix to relative path based on pcfiledir makes it
more reliable for such cases.
|
|
|
|
|
|
| |
Remove all mention of TR1 tuple and our own implementation of tuple.
PiperOrigin-RevId: 216395043
|
|
|
|
|
|
|
|
| |
e93da23920e5b6887d6a6a291c3a59f83f5b579e
Closes #1836
PiperOrigin-RevId: 215461025
|
|\ |
|
| |
| |
| |
| | |
Rework of the closed pull request #768
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | | |
This prevents warning D9025 (one command-line option overrides
another) on MSVC builds: some test targets are built with
the /EHs-c- which conflicts with /EHsc.
|
| |/
|/|
| |
| |
| |
| |
| |
| | |
nested cmake project,
which breaks my build as gcc does not allow -specs=nosys.specs to be called multiple times.
Removing this fixes it and seems to keep the same compile options, just removing the duplicate definition.
|
|\ \ |
|
| | | |
|
| |/
| |
| |
| |
| | |
This does the same thing to the CMake tests that is done to the
Bazel tests, and now makes the CMake tests pass.
|
| |\ |
|
| | |\ |
|
| | | | |
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
CMAKE_DEBUG_POSTFIX is a global configuration parameter, and
changing it pollutes the configuration space for other projects
that enclose this project.
DEBUG_POSTFIX is better to use since it is a target-specific poperty.
Fixes #1334
Fixes #1268
|
| |/ |
|
| | |
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If the user's cmakelists.txt first look for threads using
find_package(Threads), then set(gtest_disable_pthreads ON),
and then include googletest. GoogleTest will not look for
threads. But since they have already been found before in
user's cmakelists, it will use them regardless.
This helped me fix build issue in darktable-org/rawspeed
on windows/MSYS2, even though there are threads, and they
are usable, googletest build was failing with issues
about AutoHandle. I was first looking for threads, and only
then including googletest, so no matter the value of
gtest_disable_pthreads, it failed.
The other obvious solution is for user to first include
googletest, and only then look for threads by himself.
|
| |/ |
|
| |
| |
| |
| | |
generators
|
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 73d58dd4c83883b46697798e978d576b28b1d24e.
Unfortunately, ${CMAKE_CFG_INTDIR} is set during build only and doesn't
help here.
|
| |
| |
| |
| |
| |
| |
| | |
On single-configuration build systems as Makefile Generators, there is
no subdirectory for the configuration in the build tree - therefore ask
cmake for the subdir by using CMAKE_CFG_INTDIR, which is just '.' on
single-configuration build systems (Linux et al.).
|
| | |
|
| | |
|
|/
|
|
|
| |
Replaced legacy syntax of cmake add_test() with more modern syntax.
This allows running gtests's own tests on remote (cross) systems
using CMAKE_CROSSCOMPILING_EMULATOR with cmake-3.3 or newer.
|
|\
| |
| | |
Fix compilation of googletest with MinGW using Win32 threads
|
| |
| |
| |
| | |
It's not supported, and native Windows threading is available for MinGW
|
|/ |
|
|
|