| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Refactor function GetNextPrime so that the loop precondition is checked before
loop instead of during every loop run. Also by removing the loop condition,
it shows that the only exit from the loop is the return statement.
PiperOrigin-RevId: 293932783
|
|
|
|
|
|
|
|
|
|
| |
Disable warning C4800 for Visual Studio 2019.
The compiler warning C4800 is disabled by default in Visual Studio 2019,
but it can be enabled on the command line. The only version of
Visual Studio that does not support warning C4800 is Visual Studio 2017.
PiperOrigin-RevId: 292624510
|
|
|
|
|
|
| |
Add documentation for ASSERT_DEBUG_DEATH/EXPECT_DEBUG_DEATH
PiperOrigin-RevId: 292138974
|
|
|
|
|
|
| |
Adds missing `#define` guard around `TEST_F(...)`
PiperOrigin-RevId: 291703056
|
|
|
|
|
|
|
|
| |
Deleted an orphaned duplicate file and exclude another that shouldn't be part of :gtest_all_test.
This showed up while trying to debug the presubmit failure for: https://github.com/google/googletest/pull/2683
PiperOrigin-RevId: 291398123
|
|
|
|
|
|
| |
Fix SCOPED_TRACE() message header in example
PiperOrigin-RevId: 290800241
|
|
|
|
|
|
| |
Add extra filtering so that the reported message differentiates between the case where INSTANTIATE_TEST_SUITE_P is missing vs. the case where TEST_P is missing.
PiperOrigin-RevId: 290114508
|
|
|
|
|
|
| |
Correct the spelling of PARAMETERIZED.
PiperOrigin-RevId: 289897278
|
|
|
|
|
|
| |
Wire up things to support marking a type paramaterized test as allowed to be un-instantiated.
PiperOrigin-RevId: 289699939
|
|
|
|
|
|
|
|
|
|
| |
Add GTEST_ALLOW_UNINSTANTIATED_PARAMTERIZED_TEST to mark a paramaterized test as allowed to be un-instantiated.
This allows test suites, that are defined in libraries and, for other reasons, get linked in (which should probably be avoided, but isn't always possible) to be marked as allowed to go uninstantiated.
This can also be used to grandfather existing issues and expedite adoption of the checks with regards to new cases before they can be fixed.
PiperOrigin-RevId: 289581573
|
|
|
|
|
|
| |
Change testing::TempDir() return value for Android
PiperOrigin-RevId: 289102017
|
|
|
|
|
|
|
|
| |
Removing GTEST_API from TrueWithString.
This type is only used in test code on one side of a DLL boundary so it is not
necessary.
PiperOrigin-RevId: 288927929
|
|
|
|
|
|
|
| |
Close #2658
Mark test case destrucors as override.
PiperOrigin-RevId: 288507991
|
|\
| |
| |
| | |
PiperOrigin-RevId: 286896167
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Disable move operations for TEST() and TEST_F() macros.
Previous implementation disabled only copy ctor and assing operator, but
this was violating rule of 5[1], which was captured by static code analysis tools
like clang-tidy `cppcoreguidelines-special-member-functions`.
[1]: https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c21-if-you-define-or-delete-any-default-operation-define-or-delete-them-all
|
| |
| |
| |
| |
| |
| |
| |
| | |
Add option (default to disabled) to make C++ type parameterized tests (TYPED_TEST_P) fail when they're not instantiated.
When an un-instantiated TYPED_TEST_P is found, a new test will be inserted that emits a suitable message. For now, that is just a notice, but the hope it to flip the bit to make it fail by default.
PiperOrigin-RevId: 286408038
|
|\ \
| |/
|/|
| | |
PiperOrigin-RevId: 286397298
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 20b5b8ecc7a81d23b4716e22a2b35fd53379c8c6.
Reason for revert: Breaks existing applications, such as ANGLE
(angleproject.org), requires adding an extra prefix that needs to be
typed for no reason (when testing from command line) and increases the
logs' sizes by a non-trivial amount due to the very large number of
tests ANGLE runs.
Original commit message:
Add a compile time check to ensure that the parameters to TEST_P and
INSTANTIATE_TEST_SUITE_P are not empty. Some compilers already fail
in that case and, even where it works, it's likely to result in
technically invalid code by virtue of creating reserved identifiers:
https://en.cppreference.com/w/cpp/language/identifiers
First, every project is perfectly capable of adding a prefix if they
want to support such a compiler. This change penalizes every
project.
Second, using a prefix such as `_p` also results in reserved
identifiers, so this change is not really solving the problem. For that
matter, instead of generating `gtest_##prefix##...`, you can generate
`gtest_x##prefix##...` to correctly fix the issue, including when empty
prefixes are used.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 4c25e2b87fcb78abcfdee2739db9ed7a19754cd3.
Reason for revert: Reverting the commit that disallows empty prefixes.
Original commit message:
Remove a test case rendered obsolete by disallowing empty argument for INSTANTIATE_TEST_SUITE_P.
Remove the code that it was testing.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Empty arguments can be passed to macros per C99 and C++11 specs, which
can then be forwarded to other macros.
Visual Studio's compiler has a bug in the following situation:
#define A(x) #x
#define B(x, y) A(x)
B(, b)
In the above case, Visual Studio first expands x to nothing, then
complains that A is not invoked with the right amount of arguments.
However, x in A(x) is still one argument, even if it expands to no
preprocessing tokens. See also https://stackoverflow.com/a/7674214.
|
|\ \
| |/
|/|
| | |
PiperOrigin-RevId: 285812343
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | | |
kuzkry:remove-workaround_g++-no-space-after-first-macro-argument
PiperOrigin-RevId: 285255373
|
| |/ |
|
| |
| |
| |
| |
| |
| | |
Add GTEST_API_ to correct a build failure under MSCV.
PiperOrigin-RevId: 285208464
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Detect when C++ parametric tests (TEST_P) are not instantiated.
When an un-instantiated TEST_P is found, a new test will be inserted that will emit a warning message.
This can be made to error with minor code edits.
In the future, that is intended to be the default.
PiperOrigin-RevId: 284901666
|
|\ \
| | |
| | |
| | | |
PiperOrigin-RevId: 284041013
|
| | |
| | |
| | |
| | | |
This reverts commit a909becdc599c46bcb57346b6123cb57cd07d15d.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Change googletest to notice failures during SetUpTestSuite() and TearDownTestSuite().
Previously, errors that occurred during those functions were logged but otherwise ignored. After this change, such failures will cause the test to fail and a brief summary will be printed at the bottom of the test log.
See https://github.com/google/googletest/issues/2330.
PiperOrigin-RevId: 284033342
|
| | |
| | |
| | |
| | |
| | |
| | | |
Update example Environment class destructor annotation
PiperOrigin-RevId: 283986183
|
| | |
| | |
| | |
| | |
| | |
| | | |
Internal change
PiperOrigin-RevId: 283948137
|
|/ / |
|
|\ \
| | |
| | |
| | | |
PiperOrigin-RevId: 282589492
|
| |/ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Wrap call to std::numeric_limits<>::max into round braces to appease MSVC.
Closes #2589
PiperOrigin-RevId: 282581361
|
|\ \
| | |
| | |
| | | |
PiperOrigin-RevId: 282575040
|
| |/ |
|
|\ \
| | |
| | |
| | | |
PiperOrigin-RevId: 282568282
|
| |/ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Make generating goldens work with Python 3
golden_file.write(output) fails with Python 3 with:
TypeError: a bytes-like object is required, not 'str'
PiperOrigin-RevId: 282316101
|
| |
| |
| |
| |
| |
| | |
Fix typo in the predicate assertion table.
PiperOrigin-RevId: 281973457
|
|\ \
| | |
| | |
| | | |
PiperOrigin-RevId: 281971090
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We use "MemoryIsNotDeallocated" to aovid internal expected leak reported
in Windows _Crt report, like:
{
#ifdef _MSC_VER
MemoryIsNotDeallocated memory_is_not_deeallocated;
#endif
static ThreadIdToThreadLocals* map = new
ThreadIdToThreadLocals();
return map;
}
But int the above code, only "new ThreadIdToThreadLocals()" is
protected, if we invoke "insert()" function of the return value,
the memory allocated in "insert()" will be reported to _Crt report
also. This change try to fix this issue.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Use standard C++11 integer types in gtest-port.h.
Remove testing::internal::{Int,Uint}{32,64} in favor of types
guaranteed to be in <cstdint> since C++11.
Tests for built-in integer type coverage are switched from
{Int,Uint}64 to [unsigned] long long, which is guaranteed by
C++11 to exist and be at least 64-bit wide.
PiperOrigin-RevId: 281565263
|
|\ \ \
| | | |
| | | |
| | | | |
PiperOrigin-RevId: 281321427
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
googletest 1.10.0 fails to compile on msvc version 19.00.23917
with one compilation error:
src\googletest\include\gtest\internal\gtest-internal.h(1188) : error C2039:
'FlatTupleBase<testing::internal::FlatTuple<bool,bool>,testing::internal::IndexSequence<0,1> >':
is not a member of 'testing::internal::FlatTuple<bool,bool>'
This PR fixes the compilation error by explicitly specifying the full type that Indices is
located in the base type.
|