From e649993a402d96afe25fbf3413749adf0f2947f6 Mon Sep 17 00:00:00 2001 From: Aaron Jacobs Date: Mon, 30 May 2022 12:46:29 -0700 Subject: gmock-spec-builders: remove the name for an unused parameter. This fixes unused parameter errors under both MSVC and clang (when `-Werror=unused-parameter` is used, as reported [here](https://github.com/google/googletest/commit/9d21db9e0a60a1ea61ec19331c9bc0dd33e907b1#r74769946)). Fixes #3858 PiperOrigin-RevId: 451907906 Change-Id: Ic07da19ea6a547eb1797fbbab19cd57cc2a83fe8 --- googlemock/include/gmock/gmock-spec-builders.h | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/googlemock/include/gmock/gmock-spec-builders.h b/googlemock/include/gmock/gmock-spec-builders.h index fd12a06..b2911bf 100644 --- a/googlemock/include/gmock/gmock-spec-builders.h +++ b/googlemock/include/gmock/gmock-spec-builders.h @@ -1698,10 +1698,6 @@ class FunctionMocker final : public UntypedFunctionMockerBase { return std::forward(result); } - // Disable warnings about an unused parameter (due to SFINAE choosing an - // overload that doesn't use it). - GTEST_DISABLE_MSC_WARNINGS_PUSH_(4100); - // An overload for when it's not possible to print the result. In this case we // simply perform the action. template final : public UntypedFunctionMockerBase { R PerformActionAndPrintResult(const void* const untyped_action, ArgumentTuple&& args, const std::string& call_description, - std::ostream& os) { + std::ostream&) { return PerformAction(untyped_action, std::move(args), call_description); } - GTEST_DISABLE_MSC_WARNINGS_POP_(); - // Returns the result of invoking this mock function with the given // arguments. This function can be safely called from multiple // threads concurrently. -- cgit v0.12