diff options
| author | Dana Robinson <43805+derobins@users.noreply.github.com> | 2023-10-04 16:10:57 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-10-04 16:10:57 (GMT) |
| commit | fc550202c28cea0ac2fd4a4182a6585fa01a0eca (patch) | |
| tree | 194fdb2f815c67ca53565fdc12c8f92f8e03088f /.github | |
| parent | 069688c3faf01607a9a7a1ddb8f26961d8b993a7 (diff) | |
| download | hdf5-fc550202c28cea0ac2fd4a4182a6585fa01a0eca.zip hdf5-fc550202c28cea0ac2fd4a4182a6585fa01a0eca.tar.gz hdf5-fc550202c28cea0ac2fd4a4182a6585fa01a0eca.tar.bz2 | |
Disable static + thread-safe on Windows w/ CMake (#3622) (#3631)
* Disable static + thread-safe on Windows w/ CMake (#3622)
The thread-safety feature on Windows requires a hook in DllMain() and thus
is only available when HDF5 is built as a shared library.
This was previously a warning, but has now been elevated to a fatal error
that cannot be overridden with ALLOW_UNSUPPORTED.
Fixes GitHub #3613
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/main.yml | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 10b3a9c..031783b 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -455,6 +455,7 @@ jobs: if: (matrix.generator != 'autogen') && ! (matrix.thread_safety.enabled) + # NOTE: Windows does not support static + thread-safe - name: CMake Configure (Thread-Safe) run: | mkdir "${{ runner.workspace }}/build" @@ -464,6 +465,7 @@ jobs: -DCMAKE_BUILD_TYPE=${{ matrix.build_mode.cmake }} \ -DCMAKE_TOOLCHAIN_FILE=${{ matrix.toolchain }} \ -DBUILD_SHARED_LIBS=ON \ + -DBUILD_STATIC_LIBS=OFF \ -DHDF5_ENABLE_ALL_WARNINGS=ON \ -DHDF5_ENABLE_THREADSAFE:BOOL=ON \ -DHDF5_ENABLE_PARALLEL:BOOL=${{ matrix.parallel }} \ |