diff options
| author | jhendersonHDF <jhenderson@hdfgroup.org> | 2023-09-01 05:12:40 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-09-01 05:12:40 (GMT) |
| commit | 1b61cba9e7d6eb31a133db0a01d023d07612293d (patch) | |
| tree | 8cf0735fbf6ec35be5a2261e8e3f420373bbfa67 | |
| parent | 00d2ad9664f7bb36c02dd2594017099e38d6e1f8 (diff) | |
| download | hdf5-1b61cba9e7d6eb31a133db0a01d023d07612293d.zip hdf5-1b61cba9e7d6eb31a133db0a01d023d07612293d.tar.gz hdf5-1b61cba9e7d6eb31a133db0a01d023d07612293d.tar.bz2 | |
Fix valgrind warning about write of uninitialized bytes in ScaleOffset filter (#3390) (#3466)
| -rw-r--r-- | src/H5Zscaleoffset.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/src/H5Zscaleoffset.c b/src/H5Zscaleoffset.c index 123c767..c3de6a6 100644 --- a/src/H5Zscaleoffset.c +++ b/src/H5Zscaleoffset.c @@ -1283,6 +1283,9 @@ H5Z__filter_scaleoffset(unsigned flags, size_t cd_nelmts, const unsigned cd_valu } /* output; compress */ else { + size_t used_bytes; + size_t unused_bytes; + assert(nbytes == d_nelmts * p.size); /* before preprocess, convert to memory endianness order if needed */ @@ -1334,7 +1337,10 @@ H5Z__filter_scaleoffset(unsigned flags, size_t cd_nelmts, const unsigned cd_valu /* (Looks like an error in the original determination of how many * bytes would be needed for parameters. - QAK, 2010/08/19) */ - memset(outbuf + 13, 0, (size_t)8); + used_bytes = 4 + 1 + sizeof(unsigned long long); + assert(used_bytes <= size_out); + unused_bytes = size_out - used_bytes; + memset(outbuf + 13, 0, unused_bytes); /* special case: minbits equal to full precision */ if (minbits == p.size * 8) { |