diff options
author | Albert Cheng <acheng@hdfgroup.org> | 2005-08-23 22:41:42 (GMT) |
---|---|---|
committer | Albert Cheng <acheng@hdfgroup.org> | 2005-08-23 22:41:42 (GMT) |
commit | 9c4dd70e36e36535a403ab6bfffb49ba342f7098 (patch) | |
tree | f98f299258d41eb78faf16ad0cd98e00f4d5e2fe | |
parent | 208436bfc4dc923e5908bf5933e4174c35f05633 (diff) | |
download | hdf5-9c4dd70e36e36535a403ab6bfffb49ba342f7098.zip hdf5-9c4dd70e36e36535a403ab6bfffb49ba342f7098.tar.gz hdf5-9c4dd70e36e36535a403ab6bfffb49ba342f7098.tar.bz2 |
[svn-r11292] Purpose:
"bug fix"
Description:
The test_mpio_derived_dtype() often hangs when fails. So it was
not run by default to avoid hanging the daily tests or confusing
users. But then new system or new codes in collective chunk fails
while one can't tell for sure if it is because of the complicated
derived type failures or something else.
Solution:
Changed the logic so it is skipped only if it is known that
the complicated MPI derived type does not work. (This is
indicated by macro H5_MPI_COMPLEX_DERIVED_DATATYPE_WORKS NOT
defined.
Platforms tested:
heping pp (where it is tested by default).
Modi4 pp (where it is SKIPPED by default.)
I also forced modi4 to test it and modi4 said it actually
is working and should change the setting of
H5_MPI_COMPLEX_DERIVED_DATATYPE_WORKS to working?!!
Misc. update:
-rw-r--r-- | testpar/t_mpi.c | 16 |
1 files changed, 13 insertions, 3 deletions
diff --git a/testpar/t_mpi.c b/testpar/t_mpi.c index 0bf6d05..06ccf4f 100644 --- a/testpar/t_mpi.c +++ b/testpar/t_mpi.c @@ -943,10 +943,19 @@ main(int argc, char **argv) fapl = H5Pcreate (H5P_FILE_ACCESS); H5Pset_fapl_mpio(fapl, MPI_COMM_WORLD, MPI_INFO_NULL); - /* The derived datatype test hangs when it fails. This blocks - * daily test or automatic build. Run it only when hi verbose mode - * is used. + /* test_mpio_derived_dtype often hangs when fails. + * Do not run it if it is known NOT working unless ask to + * run explicitly by high verbose mode. */ +#ifdef H5_MPI_COMPLEX_DERIVED_DATATYPE_WORKS + MPI_BANNER("MPIO complicated derived datatype test..."); + ret_code = test_mpio_derived_dtype(filenames[0]); + ret_code = errors_sum(ret_code); + if (mpi_rank==0 && ret_code > 0){ + printf("***FAILED with %d total errors\n", ret_code); + nerrors += ret_code; + } +#else if (!VERBOSE_HI){ MPI_BANNER("MPIO complicated derived datatype test SKIPPED."); }else{ @@ -958,6 +967,7 @@ main(int argc, char **argv) nerrors += ret_code; } } +#endif MPI_BANNER("MPIO 1 write Many read test..."); ret_code = test_mpio_1wMr(filenames[0], USENONE); |