summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjhendersonHDF <jhenderson@hdfgroup.org>2023-04-13 16:17:27 (GMT)
committerGitHub <noreply@github.com>2023-04-13 16:17:27 (GMT)
commit9fff85d7e63d58a49dc6031b64bf965ab8f426b9 (patch)
tree3ad77bbf6306964eb88f9811a603dca7a549e405
parent5b4df7b2cd08bdef177ee092d7e57097f8dc96f8 (diff)
downloadhdf5-9fff85d7e63d58a49dc6031b64bf965ab8f426b9.zip
hdf5-9fff85d7e63d58a49dc6031b64bf965ab8f426b9.tar.gz
hdf5-9fff85d7e63d58a49dc6031b64bf965ab8f426b9.tar.bz2
CMake - Match Autotools behavior for library instrumentation (#2648) (#2674)
Enable library instrumentation by default for parallel debug builds
-rw-r--r--CMakeLists.txt8
-rw-r--r--release_docs/RELEASE.txt10
2 files changed, 17 insertions, 1 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt
index c418f34..69f891d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -611,9 +611,15 @@ option (HDF5_BUILD_GENERATORS "Build Test Generators" OFF)
#-----------------------------------------------------------------------------
option (HDF5_ENABLE_TRACE "Enable API tracing capability" OFF)
mark_as_advanced (HDF5_ENABLE_TRACE)
-if (${HDF_CFG_NAME} MATCHES "Debug")
+if (${HDF_CFG_NAME} MATCHES "Debug" OR ${HDF_CFG_NAME} MATCHES "Developer")
# Enable instrumenting of the library's internal operations
option (HDF5_ENABLE_INSTRUMENT "Instrument The library" OFF)
+
+ # Instrumenting is enabled by default for parallel debug builds
+ if (HDF5_ENABLE_PARALLEL)
+ set (HDF5_ENABLE_INSTRUMENT ON CACHE BOOL "Instrument The library" FORCE)
+ endif ()
+
if (HDF5_ENABLE_INSTRUMENT)
set (H5_HAVE_INSTRUMENTED_LIBRARY 1)
endif ()
diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt
index 81b1a94..e36372a 100644
--- a/release_docs/RELEASE.txt
+++ b/release_docs/RELEASE.txt
@@ -47,6 +47,16 @@ New Features
Configuration:
-------------
+ - Enabled instrumentation of the library by default in CMake for parallel
+ debug builds
+
+ HDF5 can be configured to instrument portions of the parallel library to
+ aid in debugging. Autotools builds of HDF5 turn this capability on by
+ default for parallel debug builds and off by default for other build types.
+ CMake has been updated to match this behavior.
+
+ (JTH - 2023/03/29)
+
- Added new option to build libaec and zlib inline with CMake.
Using the CMake FetchContent module, the external filters can populate