diff options
author | Albert Cheng <acheng@hdfgroup.org> | 2002-02-15 14:55:38 (GMT) |
---|---|---|
committer | Albert Cheng <acheng@hdfgroup.org> | 2002-02-15 14:55:38 (GMT) |
commit | f28193d92c629b8f6b311c55a02d3672b30fe7ec (patch) | |
tree | a3c2fb737934905ca1bc4a6abd826dcac0b646b9 | |
parent | 86557389dacbc08571276543cb644e8dba48c0f2 (diff) | |
download | hdf5-f28193d92c629b8f6b311c55a02d3672b30fe7ec.zip hdf5-f28193d92c629b8f6b311c55a02d3672b30fe7ec.tar.gz hdf5-f28193d92c629b8f6b311c55a02d3672b30fe7ec.tar.bz2 |
[svn-r4975] Description:
Users were alarmed by the OFFSET overflow and GB file size tests.
Those tests only checks the limits of the MPI implementation, not
really as an error.
Solution:
Changed the VRFY macro to indicate it is an "ERROR".
Modified the INFO macro to print messages as "REMARK (not an error)"
so that users would not be alarmed.
Added an explanation string in the GB file size write/read.
Platforms tested:
eirene and modi4 (parallel)
-rw-r--r-- | testpar/t_mpi.c | 4 | ||||
-rw-r--r-- | testpar/testphdf5.h | 6 |
2 files changed, 6 insertions, 4 deletions
diff --git a/testpar/t_mpi.c b/testpar/t_mpi.c index d0e6b9d..02e406e 100644 --- a/testpar/t_mpi.c +++ b/testpar/t_mpi.c @@ -273,7 +273,7 @@ test_mpio_gb_file(char *filename) printf("proc %d: writing %d bytes at offset %lld\n", mpi_rank, MB, mpi_off); mrc = MPI_File_write_at(fh, mpi_off, buf, MB, MPI_BYTE, &mpi_stat); - INFO((mrc==MPI_SUCCESS), ""); + INFO((mrc==MPI_SUCCESS), "GB size file write"); if (mrc!=MPI_SUCCESS) writerrs++; } @@ -306,7 +306,7 @@ test_mpio_gb_file(char *filename) printf("proc %d: read from mpi_off=%016llx, %lld\n", mpi_rank, mpi_off, mpi_off); mrc = MPI_File_read_at(fh, mpi_off, buf, MB, MPI_BYTE, &mpi_stat); - INFO((mrc==MPI_SUCCESS), ""); + INFO((mrc==MPI_SUCCESS), "GB size file read"); expected = i*mpi_size + (mpi_size - mpi_rank - 1); vrfyerrs=0; for (j=0; j<MB; j++){ diff --git a/testpar/testphdf5.h b/testpar/testphdf5.h index f990b28..fb613bf 100644 --- a/testpar/testphdf5.h +++ b/testpar/testphdf5.h @@ -23,7 +23,8 @@ } \ else{ \ printf("Proc %d: ", mpi_rank); \ - printf("*** PHDF5 Assertion failed (%s) at line %4d in %s\n", \ + printf("*** PHDF5 ERROR ***\n"); \ + printf(" Assertion (%s) failed at line %4d in %s\n", \ mesg, (int)__LINE__, __FILE__); \ nerrors++; \ fflush(stdout); \ @@ -48,7 +49,8 @@ } \ else{ \ printf("Proc %d: ", mpi_rank); \ - printf("*** PHDF5 Assertion failed (%s) at line %4d in %s\n", \ + printf("*** PHDF5 REMARK (not an error) ***\n"); \ + printf(" Condition (%s) failed at line %4d in %s\n", \ mesg, (int)__LINE__, __FILE__); \ fflush(stdout); \ } \ |