diff options
| author | Dana Robinson <43805+derobins@users.noreply.github.com> | 2023-11-13 19:09:43 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-11-13 19:09:43 (GMT) |
| commit | 8b3ffdef3099d2699ec71a5f855966132b3d3c25 (patch) | |
| tree | 5c513b962a30798e10dd4bbd05d67263e3ac56bc | |
| parent | 0bf85494c1487a1e9292128d09ac4bc9848543d9 (diff) | |
| download | hdf5-8b3ffdef3099d2699ec71a5f855966132b3d3c25.zip hdf5-8b3ffdef3099d2699ec71a5f855966132b3d3c25.tar.gz hdf5-8b3ffdef3099d2699ec71a5f855966132b3d3c25.tar.bz2 | |
Remove Autotools sed hack (#3848)
configure.ac contains a sed line that cleans up incorrect library
flags which was added to paper over some bugs in earlier versions
of the Autotools. These issues are not a problem with the current
versions of the Autootols.
The sed line causes problems on MacOS, so it has been removed.
Fixes #3843
| -rw-r--r-- | configure.ac | 6 | ||||
| -rw-r--r-- | release_docs/RELEASE.txt | 10 |
2 files changed, 10 insertions, 6 deletions
diff --git a/configure.ac b/configure.ac index 30f5d2c..eace890 100644 --- a/configure.ac +++ b/configure.ac @@ -4285,11 +4285,5 @@ if test "X$HDF_FORTRAN" = "Xyes"; then esac fi -## HDF5 configure code created by autotools with gcc 4.9.2 is adding problematic -## linker flags: -l with no library name; -l <libname>, specifically gfortran or m. -## This sed script corrects "-l <libname>" first and then "-l " with no library name. -## If the order is not preserved, all instances of "-l " will be removed. -sed -e '/^postdeps/ s/-l \([a-zA-Z]\)/-l\1/g' -e '/^postdeps/ s/-l //g' -i libtool - ## show the configure settings cat src/libhdf5.settings diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt index 1454574..66355a0 100644 --- a/release_docs/RELEASE.txt +++ b/release_docs/RELEASE.txt @@ -835,6 +835,16 @@ Bug Fixes since HDF5-1.14.0 release Configuration ------------- + - Removed an Autotools configure hack that causes problems on MacOS + + A sed line in configure.ac was added in the past to paper over some + problems with older versions of the Autotools that would add incorrect + linker flags. This hack is not needed with recent versions of the + Autotools and the sed line errors on MacOS (though this was a silent + error that didn't break the build) so the hack has been removed. + + Fixes GitHub issue #3843 + - Fixed an issue where the h5tools_test_utils test program was being installed on the system for Autotools builds of HDF5 |