diff options
| author | Larry Knox <lrknox@hdfgroup.org> | 2023-09-29 01:19:45 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-09-29 01:19:45 (GMT) |
| commit | 42549af4c83f4db09461dac6b500daa7e33752c6 (patch) | |
| tree | 5a0e91be02534d9c4c6e2b89f0d5393ddeb5c9b7 | |
| parent | 8235132a26fb771dbe0158e1df7dee549bdcd7a2 (diff) | |
| download | hdf5-42549af4c83f4db09461dac6b500daa7e33752c6.zip hdf5-42549af4c83f4db09461dac6b500daa7e33752c6.tar.gz hdf5-42549af4c83f4db09461dac6b500daa7e33752c6.tar.bz2 | |
Removed the use of -commons linking option on Darwin (#3581) (#3616)
Removed the use of -commons linking option on Darwin as COMMON and EQUIVALENCE is no long used
| -rw-r--r-- | configure.ac | 8 | ||||
| -rw-r--r-- | fortran/src/H5_ff.F90 | 2 | ||||
| -rw-r--r-- | release_docs/RELEASE.txt | 5 |
3 files changed, 5 insertions, 10 deletions
diff --git a/configure.ac b/configure.ac index 706e256..06ba0dd 100644 --- a/configure.ac +++ b/configure.ac @@ -1070,14 +1070,6 @@ H5_FORTRAN_SHARED="no" if test "X${HDF_FORTRAN}" = "Xyes" && test "X${enable_shared}" != "Xno"; then AC_MSG_CHECKING([if shared Fortran libraries are supported]) H5_FORTRAN_SHARED="yes" - ## tell libtool to do the right thing with COMMON symbols, this fixes - ## corrupt values with COMMON and EQUIVALENCE when building shared - ## Fortran libraries on OSX with gnu and Intel compilers (HDFFV-2772). - case "`uname`" in - Darwin*) - H5_LDFLAGS="$H5_LDFLAGS -Wl,-commons,use_dylibs" - ;; - esac ## Report results of check(s) diff --git a/fortran/src/H5_ff.F90 b/fortran/src/H5_ff.F90 index 42e7058..2196ff8 100644 --- a/fortran/src/H5_ff.F90 +++ b/fortran/src/H5_ff.F90 @@ -12,8 +12,6 @@ ! PURPOSE ! This module is used to pass C stubs for H5 Fortran APIs. The C stubs are ! packed into arrays in H5_f.c and these arrays are then passed to Fortran. -! This module then uses EQUIVALENCE to assign elements of the arrays to -! Fortran equivalent C stubs. ! ! NOTES ! The size of the C arrays in H5_f.c has to match the values of the variables diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt index 0c35f11..a0a5dae 100644 --- a/release_docs/RELEASE.txt +++ b/release_docs/RELEASE.txt @@ -65,6 +65,11 @@ New Features - + - Removed "-commons" linking option on Darwin, as COMMON and EQUIVALENCE + are no longer used in the Fortran source. + + Fixes GitHub issue #3571 + C++ Library: ------------ - |