diff options
| author | Jonathan Kim <jkm@hdfgroup.org> | 2011-05-12 23:12:29 (GMT) |
|---|---|---|
| committer | Jonathan Kim <jkm@hdfgroup.org> | 2011-05-12 23:12:29 (GMT) |
| commit | b9e1b158a547d4b0da6cc2b92b4494cdba58495e (patch) | |
| tree | 6f5e1ad8d427508a43eeab93ece60da6cf72fa99 | |
| parent | f100b8f6bbe63751a01d3ae63ca06234b657ce9b (diff) | |
| download | hdf5-b9e1b158a547d4b0da6cc2b92b4494cdba58495e.zip hdf5-b9e1b158a547d4b0da6cc2b92b4494cdba58495e.tar.gz hdf5-b9e1b158a547d4b0da6cc2b92b4494cdba58495e.tar.bz2 | |
[svn-r20804] Purpose:
HDFFV-7594 - GMQS: h5dump shows wrong values for H5T_STD_I8LE dataset on Blue-gene (ppc64 linux BE +@)
Description:
For the STD_I8 type data, updated to use 'signed char' instead of 'char' as
'char' could be defined as unsigned on a certain system, which cause h5dump
to display data values incorrectly.
Tested:
jam (linux32-LE), koala (linux64-LE), heiwa (linuxppc64-BE), tejeda (mac32-LE)
| -rw-r--r-- | release_docs/RELEASE.txt | 3 | ||||
| -rw-r--r-- | tools/lib/h5tools_str.c | 2 |
2 files changed, 4 insertions, 1 deletions
diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt index fdfe110..976afb4 100644 --- a/release_docs/RELEASE.txt +++ b/release_docs/RELEASE.txt @@ -525,6 +525,9 @@ Bug Fixes since HDF5-1.8.0 release Tools ----- + - Fixed h5dump to display correct value for H5T_STD_I8LE dataset + on a system (ppc64, linux, Big-Endian, clustering). + Bug #HDFFV-7594 (ABERT & JKM 05/12/2011) - Fixed h5diff to compare file itself correctly. Previously h5diff reported either different or not compatible in certain cases even comparing file itself. This fix also improve performance when diff --git a/tools/lib/h5tools_str.c b/tools/lib/h5tools_str.c index 54e2584..af3f7e7 100644 --- a/tools/lib/h5tools_str.c +++ b/tools/lib/h5tools_str.c @@ -814,7 +814,7 @@ h5tools_str_sprint(h5tools_str_t *str, const h5tool_format_t *info, hid_t contai h5tools_str_append(str, OPT(info->fmt_uint, "%u"), tempuint); } else if (H5Tequal(type, H5T_NATIVE_SCHAR)) { - char tempchar; + signed char tempchar; HDmemcpy(&tempchar, cp_vp, sizeof(char)); if(packed_bits_num) { tempchar = (tempchar >> packed_data_offset) & packed_data_mask; |