summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeil Fortner <nfortne2@hdfgroup.org>2008-08-21 22:38:46 (GMT)
committerNeil Fortner <nfortne2@hdfgroup.org>2008-08-21 22:38:46 (GMT)
commite9f3b20b64d3c2ffe2e134a5c4bf974c916472b8 (patch)
treee9d20f2bafb9c9db148ab0f2b8b3a5741209ef64
parentc6e35f6abd381583d3686525b1cd4fdca9eaeded (diff)
downloadhdf5-e9f3b20b64d3c2ffe2e134a5c4bf974c916472b8.zip
hdf5-e9f3b20b64d3c2ffe2e134a5c4bf974c916472b8.tar.gz
hdf5-e9f3b20b64d3c2ffe2e134a5c4bf974c916472b8.tar.bz2
[svn-r15515] Fix faulty error checking in call to H5I_remove().
Add prototype to the top of app_ref.c to suppress warning. Tested: kagiso
-rw-r--r--src/H5E.c2
-rw-r--r--test/app_ref.c2
2 files changed, 3 insertions, 1 deletions
diff --git a/src/H5E.c b/src/H5E.c
index 9365035..7112d6e 100644
--- a/src/H5E.c
+++ b/src/H5E.c
@@ -616,7 +616,7 @@ H5E_close_msg_cb(void *obj_ptr, hid_t obj_id, void *key)
/* Close the message if it is in the class being closed */
if(err_msg->cls == cls)
- if(H5I_remove(obj_id) < 0)
+ if(NULL == H5I_remove(obj_id))
HGOTO_ERROR(H5E_ERROR, H5E_CANTREMOVE, FAIL, "unable to remove error message")
done:
diff --git a/test/app_ref.c b/test/app_ref.c
index 209a909..cb8be6a 100644
--- a/test/app_ref.c
+++ b/test/app_ref.c
@@ -76,6 +76,8 @@ const char *IDNAME[T_NUMCLASSES] = {
int rc[T_NUMCLASSES];
+void Abrt_Handler (int sig);
+
/* Handler for SIGABRT - prints the reference count on each id */
void
Abrt_Handler (int UNUSED sig)