summaryrefslogtreecommitdiffstats
path: root/MANIFEST
diff options
context:
space:
mode:
authorDana Robinson <43805+derobins@users.noreply.github.com>2020-11-17 18:06:39 (GMT)
committerGitHub <noreply@github.com>2020-11-17 18:06:39 (GMT)
commita50d211755cb272b2e468144e7d892a4c90813c4 (patch)
tree5ef471321caab6a2f9d14eef0f9cab462c8d73f5 /MANIFEST
parent0db2d6c21211cc78dbde8e9b1a1588902aec152c (diff)
downloadhdf5-a50d211755cb272b2e468144e7d892a4c90813c4.zip
hdf5-a50d211755cb272b2e468144e7d892a4c90813c4.tar.gz
hdf5-a50d211755cb272b2e468144e7d892a4c90813c4.tar.bz2
Switch ID code to use a hash table instead of a skip list (#52)
* Brings hash table ID code over from Bitbucket branch * Includes reformatting via clang. * Excludes uthash.h from reformatting. * Still has the failing test issue in tid.c. This should only be a problem if a custom ID type is used and its free function deletes other IDs. * Fixes munged H5_GCC_DIAG_ON/OFF macros in H5I.c The H5_GCC_DIAG_ON/OFF macros used to turn off fallthrough warnings in uthash.h (external code) were munged when formatting with clang due to their lack of quotes. e.g.; H5_GCC_DIAG_OFF(implicit-fallthrough) was munged to: H5_GCC_DIAG_OFF(implicit - fallthrough) which compiles, but is useless. So, with quotes, this is now: H5_GCC_DIAG_OFF("implicit-fallthrough") which survives reformatting with clang. * Fixes issues with user callbacks in the ID hash tables The skip lists (previously) used to handle IDs use a mark-and-sweep scheme to deal with user-defined ID delete callbacks which themselves delete other IDs in the list. The uthash hash table implementation used to manage the IDs in this feature branch does not have this ability. This commit restores the skip lists for non-library ID types in lieu of significantly modifying the uthash code. The hash tables are used to manage the library IDs as those do not delete other IDs when they are closed. * Adds uthash.h to MANIFEST * Removes implicit-fallthrough diagnostic disable Removing -Wimplicit-fallthrough=5 means that the uthash code no longer raises warnings so the H5_GCC_DIAG_OFF/ON macros that disabled those warnings have been removed from H5I.c. * Adds a test to ensure you can delete IDs in the H5Iiterate() callback
Diffstat (limited to 'MANIFEST')
-rw-r--r--MANIFEST3
1 files changed, 2 insertions, 1 deletions
diff --git a/MANIFEST b/MANIFEST
index a885f9d..f2947ba 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -1043,10 +1043,11 @@
./src/H5Zshuffle.c
./src/H5Zszip.c
./src/H5Ztrans.c
+./src/H5win32defs.h
./src/Makefile.am
./src/hdf5.h
./src/libhdf5.settings.in
-./src/H5win32defs.h
+./src/uthash.h
./test/AtomicWriterReader.txt
./test/COPYING