[svn-r29769] Purpose: Code improvements

Description:
    - Changed object in catch statements to reference
    - Replaced old-style casts or reinterpret_cast with static_cast
    - Removed unused name H5Library::need_cleanup
    - Removed Exception::printError from documentation
    Merged from trunk r29759 and r29766
Platforms tested:
    Linux/32 2.6 (jam)
    Linux/64 (platypus)
    Darwin (osx1010test)

1 files changed, 18 insertions, 18 deletions

diff --git a/c++/src/H5AbstractDs.cpp b/c++/src/H5AbstractDs.cpp
index 8d88c53..6dee337 100644
--- a/c++/src/H5AbstractDs.cpp
+++ b/c++/src/H5AbstractDs.cpp
@@ -68,10 +68,10 @@ H5T_class_t AbstractDs::getTypeClass() const
    try {
       datatype_id = p_get_type();  // returned value is already validated
    }
-   catch (DataSetIException E) {
+   catch (DataSetIException& E) {
       throw DataTypeIException("DataSet::getTypeClass", E.getDetailMsg());
    }
-   catch (AttributeIException E) {
+   catch (AttributeIException& E) {
       throw DataTypeIException("Attribute::getTypeClass", E.getDetailMsg());
    }
 
@@ -118,10 +118,10 @@ DataType AbstractDs::getDataType() const
 	f_DataType_setId(&datatype, p_get_type());
 	return(datatype);
    }
-   catch (DataSetIException E) {
+   catch (DataSetIException& E) {
       throw DataTypeIException("DataSet::getDataType", E.getDetailMsg());
    }
-   catch (AttributeIException E) {
+   catch (AttributeIException& E) {
       throw DataTypeIException("Attribute::getDataType", E.getDetailMsg());
    }
 }
@@ -148,10 +148,10 @@ ArrayType AbstractDs::getArrayType() const
 	arraytype.setArrayInfo();
 	return(arraytype);
    }
-   catch (DataSetIException E) {
+   catch (DataSetIException& E) {
       throw DataTypeIException("DataSet::getArrayType", E.getDetailMsg());
    }
-   catch (AttributeIException E) {
+   catch (AttributeIException& E) {
       throw DataTypeIException("Attribute::getArrayType", E.getDetailMsg());
    }
 }
@@ -175,10 +175,10 @@ CompType AbstractDs::getCompType() const
 	f_DataType_setId(&comptype, p_get_type());
 	return(comptype);
    }
-   catch (DataSetIException E) {
+   catch (DataSetIException& E) {
       throw DataTypeIException("DataSet::getCompType", E.getDetailMsg());
    }
-   catch (AttributeIException E) {
+   catch (AttributeIException& E) {
       throw DataTypeIException("Attribute::getCompType", E.getDetailMsg());
    }
 }
@@ -202,10 +202,10 @@ EnumType AbstractDs::getEnumType() const
 	f_DataType_setId(&enumtype, p_get_type());
 	return(enumtype);
    }
-   catch (DataSetIException E) {
+   catch (DataSetIException& E) {
       throw DataTypeIException("DataSet::getEnumType", E.getDetailMsg());
    }
-   catch (AttributeIException E) {
+   catch (AttributeIException& E) {
       throw DataTypeIException("Attribute::getEnumType", E.getDetailMsg());
    }
 }
@@ -229,10 +229,10 @@ IntType AbstractDs::getIntType() const
 	f_DataType_setId(&inttype, p_get_type());
 	return(inttype);
    }
-   catch (DataSetIException E) {
+   catch (DataSetIException& E) {
       throw DataTypeIException("DataSet::getIntType", E.getDetailMsg());
    }
-   catch (AttributeIException E) {
+   catch (AttributeIException& E) {
       throw DataTypeIException("Attribute::getIntType", E.getDetailMsg());
    }
 }
@@ -256,10 +256,10 @@ FloatType AbstractDs::getFloatType() const
 	f_DataType_setId(&floatype, p_get_type());
 	return(floatype);
    }
-   catch (DataSetIException E) {
+   catch (DataSetIException& E) {
       throw DataTypeIException("DataSet::getFloatType", E.getDetailMsg());
    }
-   catch (AttributeIException E) {
+   catch (AttributeIException& E) {
       throw DataTypeIException("Attribute::getFloatType", E.getDetailMsg());
    }
 }
@@ -283,10 +283,10 @@ StrType AbstractDs::getStrType() const
 	f_DataType_setId(&strtype, p_get_type());
 	return(strtype);
    }
-   catch (DataSetIException E) {
+   catch (DataSetIException& E) {
       throw DataTypeIException("DataSet::getStrType", E.getDetailMsg());
    }
-   catch (AttributeIException E) {
+   catch (AttributeIException& E) {
       throw DataTypeIException("Attribute::getStrType", E.getDetailMsg());
    }
 }
@@ -310,10 +310,10 @@ VarLenType AbstractDs::getVarLenType() const
 	f_DataType_setId(&varlentype, p_get_type());
 	return(varlentype);
    }
-   catch (DataSetIException E) {
+   catch (DataSetIException& E) {
       throw DataTypeIException("DataSet::getVarLenType", E.getDetailMsg());
    }
-   catch (AttributeIException E) {
+   catch (AttributeIException& E) {
       throw DataTypeIException("Attribute::getVarLenType", E.getDetailMsg());
    }
 }