diff options
author | Binh-Minh Ribler <bmribler@hdfgroup.org> | 2008-07-25 21:51:01 (GMT) |
---|---|---|
committer | Binh-Minh Ribler <bmribler@hdfgroup.org> | 2008-07-25 21:51:01 (GMT) |
commit | 18fb7d1a78ff488c23ed5e3bec583034176f3bb4 (patch) | |
tree | cdf00652c7201807d9fa41feb5bfe357023a695c /c++/src/H5DataSet.cpp | |
parent | bb8bf261eef26e860eaa1ebf2dd24d053a9378ec (diff) | |
download | hdf5-18fb7d1a78ff488c23ed5e3bec583034176f3bb4.zip hdf5-18fb7d1a78ff488c23ed5e3bec583034176f3bb4.tar.gz hdf5-18fb7d1a78ff488c23ed5e3bec583034176f3bb4.tar.bz2 |
[svn-r15407] Purpose: Fix bug
Description:
Changed all subclasses' setId to protected p_setId and put back setId
in IdComponent. p_setId is used in the library where the id provided
by a C API passed on to user's application in the form of a C++ API
object, which will be destroyed properly, and so p_setId does not
call incRefCount. On the other hand, the public version setId is
used by other applications, in which the id passed to setId needs
to be closed properly by the application, so setId must call incRefCount
for the new object to prevent prematurely closing of the id.
Platforms tested:
Linux 2.6 (kagiso)
SunOS 5.10 (linew)
FreeBSD (duty)
Diffstat (limited to 'c++/src/H5DataSet.cpp')
-rw-r--r-- | c++/src/H5DataSet.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/c++/src/H5DataSet.cpp b/c++/src/H5DataSet.cpp index 5ee84b1..3051e08 100644 --- a/c++/src/H5DataSet.cpp +++ b/c++/src/H5DataSet.cpp @@ -534,7 +534,7 @@ hid_t DataSet::getId() const } //-------------------------------------------------------------------------- -// Function: DataSet::setId +// Function: DataSet::p_setId ///\brief Sets the identifier of this object to a new value. /// ///\exception H5::IdComponentException when the attempt to close the HDF5 @@ -545,14 +545,14 @@ hid_t DataSet::getId() const // Then the object's id is reset to the new id. // Programmer Binh-Minh Ribler - 2000 //-------------------------------------------------------------------------- -void DataSet::setId(const hid_t new_id) +void DataSet::p_setId(const hid_t new_id) { // handling references to this old id try { close(); } catch (Exception close_error) { - throw DataSetIException(inMemFunc("setId"), close_error.getDetailMsg()); + throw DataSetIException(inMemFunc("p_setId"), close_error.getDetailMsg()); } // reset object's id to the given id id = new_id; |