diff options
| author | Binh-Minh Ribler <bmribler@hdfgroup.org> | 2005-07-25 03:37:21 (GMT) |
|---|---|---|
| committer | Binh-Minh Ribler <bmribler@hdfgroup.org> | 2005-07-25 03:37:21 (GMT) |
| commit | fab172d704065dba31fbf34d3fe7e56c3e63fe36 (patch) | |
| tree | 59a35e3b906d509134ed4d581e134054359e999e /c++/src/H5File.cpp | |
| parent | f208550696646adcc6e59e339745b0433e28f770 (diff) | |
| download | hdf5-fab172d704065dba31fbf34d3fe7e56c3e63fe36.zip hdf5-fab172d704065dba31fbf34d3fe7e56c3e63fe36.tar.gz hdf5-fab172d704065dba31fbf34d3fe7e56c3e63fe36.tar.bz2 | |
[svn-r11151] Purpose: Fix bugzilla #407 and #408
Description:
PropList::copyProp has incorrect prototype; although it works,
it does cause users inconvenience.
Solution:
Added another overloaded function with correct prototype. The
old version will be removed in a future release. In the meantime,
"Obsolete" will be displayed in its RM page.
Also, changed several checks on the returned value of a C API from
non-positive to negative because id = 0 is no longer significant,
now that the C++ reference counting had been removed.
Platforms tested:
Linux 2.4 (heping)
IRIX64 with -n32 (modi4)
Linux 2.4 w/PGI (colonelk)
Diffstat (limited to 'c++/src/H5File.cpp')
| -rw-r--r-- | c++/src/H5File.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/c++/src/H5File.cpp b/c++/src/H5File.cpp index b9adbca..985fc72 100644 --- a/c++/src/H5File.cpp +++ b/c++/src/H5File.cpp @@ -111,7 +111,7 @@ void H5File::p_get_file(const char* name, unsigned int flags, const FileCreatPro hid_t create_plist_id = create_plist.getId(); hid_t access_plist_id = access_plist.getId(); id = H5Fcreate( name, flags, create_plist_id, access_plist_id ); - if( id <= 0 ) // throw an exception when open/create fail + if( id < 0 ) // throw an exception when open/create fail { throw FileIException("H5File constructor", "H5Fcreate failed"); } @@ -121,7 +121,7 @@ void H5File::p_get_file(const char* name, unsigned int flags, const FileCreatPro { hid_t access_plist_id = access_plist.getId(); id = H5Fopen( name, flags, access_plist_id ); - if( id <= 0 ) // throw an exception when open/create fail + if( id < 0 ) // throw an exception when open/create fail { throw FileIException("H5File constructor", "H5Fopen failed"); } @@ -201,7 +201,7 @@ void H5File::reOpen() // call C routine to reopen the file - Note: not sure about this // does id need to be closed later? which id to be the parameter? id = H5Freopen( id ); - if( id <= 0 ) // Raise exception when H5Freopen returns a neg value + if( id < 0 ) // Raise exception when H5Freopen returns a neg value throw FileIException("H5File::reOpen", "H5Freopen failed"); } |