diff options
author | Binh-Minh Ribler <bmribler@hdfgroup.org> | 2015-10-13 15:15:01 (GMT) |
---|---|---|
committer | Binh-Minh Ribler <bmribler@hdfgroup.org> | 2015-10-13 15:15:01 (GMT) |
commit | faf35f2d4c9a74eed3e9b34f5b9b334870ee8783 (patch) | |
tree | c5dea3acd87cffea2c3122a8ec789a90f46081b0 /c++/src/H5IdComponent.cpp | |
parent | ab8d3b1db99c7579ba21a9bdb3b7c9a4d0461fa9 (diff) | |
download | hdf5-faf35f2d4c9a74eed3e9b34f5b9b334870ee8783.zip hdf5-faf35f2d4c9a74eed3e9b34f5b9b334870ee8783.tar.gz hdf5-faf35f2d4c9a74eed3e9b34f5b9b334870ee8783.tar.bz2 |
[svn-r28052] Purpose: Fix memory leaks
Description:
- Implemented the friend function
void f_PropList_setId(PropList* plist, hid_t new_id)
to work around the same problem described in trunk r26655, for the
API DataSet::getCreatePlist()
- Cleaned up some comments and obsolete functions
Merged from trunk r28047
Platforms tested:
Linux/32 2.6 (jam)
Darwin (osx1010test)
Diffstat (limited to 'c++/src/H5IdComponent.cpp')
-rw-r--r-- | c++/src/H5IdComponent.cpp | 20 |
1 files changed, 3 insertions, 17 deletions
diff --git a/c++/src/H5IdComponent.cpp b/c++/src/H5IdComponent.cpp index 19d68cf..60735f0 100644 --- a/c++/src/H5IdComponent.cpp +++ b/c++/src/H5IdComponent.cpp @@ -52,20 +52,6 @@ bool IdComponent::H5dontAtexit_called = false; IdComponent::IdComponent(const hid_t h5_id) {} //-------------------------------------------------------------------------- -// Function: IdComponent copy constructor -// Purpose: This noop copy constructor is removed as a result of the data -// member "id" being moved down to sub-classes. (Mar 2015) -// Parameters: original - IN: IdComponent instance to copy -// Programmer Binh-Minh Ribler - 2000 -// -// *** Deprecation warning *** -// This constructor is no longer appropriate because the data member "id" had -// been moved to the sub-classes. It is removed from 1.8.15 because it is -// a noop and it can be generated by the compiler if needed. -//-------------------------------------------------------------------------- -// IdComponent::IdComponent(const IdComponent& original) {} - -//-------------------------------------------------------------------------- // Function: IdComponent::incRefCount ///\brief Increment reference counter for a given id. // Programmer Binh-Minh Ribler - May 2005 @@ -231,7 +217,7 @@ IdComponent& IdComponent::operator=( const IdComponent& rhs ) //-------------------------------------------------------------------------- // Function: IdComponent::setId ///\brief Sets the identifier of this object to a new value. -/// +///\param new_id - IN: New identifier to be set to ///\exception H5::IdComponentException when the attempt to close the HDF5 /// object fails // Description: @@ -246,8 +232,8 @@ IdComponent& IdComponent::operator=( const IdComponent& rhs ) // C++ API object, which will be destroyed properly, and so // p_setId does not call incRefCount. On the other hand, the // public version setId is used by other applications, in which -// the id passed to setId already has a reference count, so setId -// must call incRefCount. +// the id passed to setId is that of another C++ API object, so +// setId must call incRefCount. //-------------------------------------------------------------------------- void IdComponent::setId(const hid_t new_id) { |