[svn-r15407] Purpose: Fix bug

Description:
    Changed all subclasses' setId to protected p_setId and put back setId
    in IdComponent.  p_setId is used in the library where the id provided
    by a C API passed on to user's application in the form of a C++ API
    object, which will be destroyed properly, and so p_setId does not
    call incRefCount.  On the other hand, the public version setId is
    used by other applications, in which the id passed to setId needs
    to be closed properly by the application, so setId must call incRefCount
    for the new object to prevent prematurely closing of the id.

Platforms tested:
    Linux 2.6 (kagiso)
    SunOS 5.10 (linew)
    FreeBSD (duty)

1 files changed, 5 insertions, 1 deletions

diff --git a/c++/src/H5IdComponent.h b/c++/src/H5IdComponent.h
index c34b2da..7f573a1 100644
--- a/c++/src/H5IdComponent.h
+++ b/c++/src/H5IdComponent.h
@@ -51,7 +51,7 @@ class H5_DLLCPP IdComponent {
 	virtual hid_t getId () const = 0;
 
 	// Sets the identifier of this object to a new value.
-	virtual void setId(const hid_t new_id) = 0;
+	void setId(const hid_t new_id);
 
 	// Creates an object to hold an HDF5 identifier.
 	IdComponent( const hid_t h5_id );
@@ -88,6 +88,10 @@ class H5_DLLCPP IdComponent {
 	// Verifies that the given id is valid.
 	static bool p_valid_id(const hid_t obj_id);
 
+	// Sets the identifier of this object to a new value. - this one
+	// doesn't increment reference count
+	virtual void p_setId(const hid_t new_id) = 0;
+
 #endif // DOXYGEN_SHOULD_SKIP_THIS
 
 }; // end class IdComponent