diff options
| author | Sean McBride <sean@rogue-research.com> | 2021-02-25 18:15:02 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-02-25 18:15:02 (GMT) |
| commit | c29e1b9fdfcba9ca276600b1bad4ec2cf17bb01e (patch) | |
| tree | 59c16ade26ea62e2ffc89506e1a245b4f296b82e /c++/src/H5StrType.cpp | |
| parent | c17b4b93d680340af2b3f2c026f2c03c3baeb33a (diff) | |
| download | hdf5-c29e1b9fdfcba9ca276600b1bad4ec2cf17bb01e.zip hdf5-c29e1b9fdfcba9ca276600b1bad4ec2cf17bb01e.tar.gz hdf5-c29e1b9fdfcba9ca276600b1bad4ec2cf17bb01e.tar.bz2 | |
Patches from vtk (#358)
* Drop the export attribute on forward declaration
They don't mean anything on forward declarations anyways.
* Fixed -Wunused-parameter warnings in some C++ files
Allowed all the attribute #defines to work in C++ also.
* Fixed -Wunused-variable warnings by removing dead code
* Fixed all -Wshorten-64-to-32 warnings by adjusting casts
There was no truncation in fact, since the unsigned result was upcast to size_t then implicitly downcast to uint32_t.
* Fixed all -Wcomma warnings by spliting statements onto own lines
* Fixed all -Wself-assign warnings with different unused param suppression
* Fixed all -Wextra-semi warnings
* Fixed all -Wswitch-enum warnings
Just added new explicit cases with the existing default case.
* Fixed all -Wmissing-prototypes warnings
Just made functions static. Moved them into an extern "C" block.
* Reformatted source with bin/format_source using clang version 10.0.1
Co-authored-by: Larry Knox <lrknox@hdfgroup.org>
Diffstat (limited to 'c++/src/H5StrType.cpp')
| -rw-r--r-- | c++/src/H5StrType.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/c++/src/H5StrType.cpp b/c++/src/H5StrType.cpp index 7bbe3ab..473cab3 100644 --- a/c++/src/H5StrType.cpp +++ b/c++/src/H5StrType.cpp @@ -32,6 +32,7 @@ #include "H5StrType.h" #include "H5DataSet.h" #include "H5PredType.h" +#include "H5private.h" namespace H5 { @@ -102,7 +103,7 @@ StrType::StrType(const PredType &pred_type, const size_t &size) : AtomType() // This constructor replaced the previous one. // Programmer Binh-Minh Ribler - Nov 28, 2005 //-------------------------------------------------------------------------- -StrType::StrType(const int dummy, const size_t &size) : AtomType() +StrType::StrType(H5_ATTR_UNUSED const int dummy, const size_t &size) : AtomType() { // use DataType::copy to make a copy of the string predefined type // then set its length |