diff options
| author | Sean McBride <sean@rogue-research.com> | 2021-08-23 21:14:53 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-08-23 21:14:53 (GMT) |
| commit | f6c49fe8911a39810b236f7babf09a70fcc76c7b (patch) | |
| tree | 4ee702ab548adf8e619525e14716dde7d26bb331 /c++/src | |
| parent | b5f5c59f297be19096051282068cdcc14275eb34 (diff) | |
| download | hdf5-f6c49fe8911a39810b236f7babf09a70fcc76c7b.zip hdf5-f6c49fe8911a39810b236f7babf09a70fcc76c7b.tar.gz hdf5-f6c49fe8911a39810b236f7babf09a70fcc76c7b.tar.bz2 | |
More clang tidy (#908)
* Pacify clang-analyzer-unix.cstring.NullArg
* Apply some bugprone-suspicious-string-compare
* Apply some readability-simplify-boolean-expr
* Apply some readability-make-member-function-const
* Apple some bugprone-macro-parentheses
* Changed an f suffix to L for `long double`
* Applied some readability-uppercase-literal-suffix automatically
* Committing clang-format changes
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Diffstat (limited to 'c++/src')
| -rw-r--r-- | c++/src/H5DataType.cpp | 5 | ||||
| -rw-r--r-- | c++/src/H5IdComponent.cpp | 5 |
2 files changed, 2 insertions, 8 deletions
diff --git a/c++/src/H5DataType.cpp b/c++/src/H5DataType.cpp index b00a526..af58a90 100644 --- a/c++/src/H5DataType.cpp +++ b/c++/src/H5DataType.cpp @@ -338,10 +338,7 @@ DataType::encode() bool DataType::hasBinaryDesc() const { - if (encoded_buf != NULL) - return true; - else - return false; + return encoded_buf != NULL; } //-------------------------------------------------------------------------- diff --git a/c++/src/H5IdComponent.cpp b/c++/src/H5IdComponent.cpp index d546d32..e1fc687 100644 --- a/c++/src/H5IdComponent.cpp +++ b/c++/src/H5IdComponent.cpp @@ -432,10 +432,7 @@ IdComponent::p_valid_id(const hid_t obj_id) return false; H5I_type_t id_type = H5Iget_type(obj_id); - if (id_type <= H5I_BADID || id_type >= H5I_NTYPES) - return false; - else - return true; + return (id_type > H5I_BADID && id_type < H5I_NTYPES); } // Notes about IdComponent::id |