diff options
author | Sean McBride <sean@rogue-research.com> | 2021-03-10 18:41:34 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-03-10 18:41:34 (GMT) |
commit | a7a013782f0af93f511142b5d167c2bc8ca8505d (patch) | |
tree | 5c13dc35b15c30315bcae04aa6971d73acabd9fc /c++/test/dsets.cpp | |
parent | 7501f96ab9605e11c58bc0c9e6412e4db30ba7db (diff) | |
download | hdf5-a7a013782f0af93f511142b5d167c2bc8ca8505d.zip hdf5-a7a013782f0af93f511142b5d167c2bc8ca8505d.tar.gz hdf5-a7a013782f0af93f511142b5d167c2bc8ca8505d.tar.bz2 |
Various clang tidy warning fixes (#448)
* Fixed clang-tidy bugprone-reserved-identifier warnings
* Fixed clang-tidy bugprone-assert-side-effect warnings
* Fixed clang-tidy bugprone-copy-constructor-init warning
* Fixed clang-tidy readability-redundant-preprocessor warning
For error_test.c the removed code was already dead, because it was in the else of an `#if H5_USE_16_API` block.
Based on H5Location.h, I think p_get_ref_obj_type was meant to be in `#ifndef DOXYGEN_SHOULD_SKIP_THIS` and an `#endif` was missing. Similarly, in the header, getObjTypeByIdx is only in H5_NO_DEPRECATED_SYMBOLS, not DOXYGEN_SHOULD_SKIP_THIS.
* Fixed clang-tidy readability-redundant-string-init warnings
* Fixed some clang-tidy performance-type-promotion-in-math-fn warnings
* Fixed clang-tidy performance-unnecessary-value-param warnings
* Reformat source with clang v10.0.1.
Co-authored-by: Larry Knox <lrknox@hdfgroup.org>
Diffstat (limited to 'c++/test/dsets.cpp')
-rw-r--r-- | c++/test/dsets.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/c++/test/dsets.cpp b/c++/test/dsets.cpp index 93c266f..0faf457 100644 --- a/c++/test/dsets.cpp +++ b/c++/test/dsets.cpp @@ -1157,7 +1157,7 @@ const int RANK1 = 1; const H5std_string FILE_ACCPLIST("test_accplist.h5"); static herr_t -test_chunk_cache(FileAccPropList fapl) +test_chunk_cache(const FileAccPropList &fapl) { SUBTEST("DSetAccPropList::set/getChunkCache"); |