Merge pull request #209 in HDFFV/hdf5 from ~BMRIBLER/hdf5_bmr_cpp:develop to develop

- Replacing openXxxType with individual type constructors
- Put back CommonFG
- Removed overloaded constructors that take an Attribute where there is one that takes an H5Location

* commit 'e05da1b533d5eb9527a5b67ba2683379f8e1e7ac':
  Description:     Removed commented out code and fixed miscellaneous typos. Platforms tested:     Linux/32 2.6 (jam) (very minor)
  Purpose: Improvement for HDFFV-10004 Description:     When adding wrappers for H5Lexists, a new class, LinkAccPropList, was     added to the C++ API, triggered complicated circular dependencies.  Thus,     some improvement was made to resolve the problems.     - Replaced existing functions openXxxType with individual type constructors       + Added individual XxxType constructors to replace the existing functions         openXxxType because it's rather awkward to use these functions.       + Moved openXxxType from H5Location back to CommonFG       + Put back CommonFG as a baseclass of Group for openXxxType functions.       + This replacement should improve usability and prevent the problem of         circular dependencies.     - Removed overloaded constructor that takes an Attribute when there is         already one that takes H5Location because Attribute inherits from         H5Location now. Platforms tested:     Linux/32 2.6 (jam)     Darwin (osx1010test)     Linux/64 (platypus)

1 files changed, 15 insertions, 1 deletions

diff --git a/c++/test/tarray.cpp b/c++/test/tarray.cpp
index 7fe2e6b..f10016f 100644
--- a/c++/test/tarray.cpp
+++ b/c++/test/tarray.cpp
@@ -34,6 +34,7 @@ using namespace H5;
 #include "h5cpputil.h"  // C++ utilility header file
 
 const H5std_string    FILENAME("tarray.h5");
+const H5std_string    ARRAYTYPE_NAME("/Array type 1");
 const int SPACE1_RANK = 1;
 const hsize_t SPACE1_DIM1 = 4;
 const int ARRAY1_RANK = 1;
@@ -130,9 +131,22 @@ static void test_array_compound_array()
 	// Write dataset to disk
 	dataset.write(wdata, arrtype);
 
+	// Test opening ArrayType with opening constructor (Dec 2016)
+
+	// Commit the arrtype to give it a name
+	arrtype.commit(file1, ARRAYTYPE_NAME);
+
+	// Close it, then re-open with the opening constructor
+	arrtype.close();
+	ArrayType named_type(file1, ARRAYTYPE_NAME);
+
+	// Get and verify the type's name
+	H5std_string type_name = named_type.getObjName();
+	verify_val(type_name, ARRAYTYPE_NAME, "DataType::getObjName tests constructor", __LINE__, __FILE__);
+	named_type.close();
+
 	// Close all
 	dataset.close();
-	arrtype.close();
 	space.close();
 	file1.close();