diff options
author | Binh-Minh Ribler <bmribler@hdfgroup.org> | 2013-03-22 17:56:05 (GMT) |
---|---|---|
committer | Binh-Minh Ribler <bmribler@hdfgroup.org> | 2013-03-22 17:56:05 (GMT) |
commit | c8018386da2165a16f5e2d0cb5a391dca07b4ed5 (patch) | |
tree | bd9af146bf98c667e9237afc21bb5f108eb81dbc /c++/test/tfilter.cpp | |
parent | 030a17ca60905ef90cabaa147ee84febb064fc42 (diff) | |
download | hdf5-c8018386da2165a16f5e2d0cb5a391dca07b4ed5.zip hdf5-c8018386da2165a16f5e2d0cb5a391dca07b4ed5.tar.gz hdf5-c8018386da2165a16f5e2d0cb5a391dca07b4ed5.tar.bz2 |
[svn-r23427] Purpose: Fix bug HDFFV-8067
Description:
+ The C++ test failed with the new PGI compilers versions 12.4 and 12.5
+ An exception thrown by an internal function, which was called by
a constructor, was not propagating to the test program during the stack
unwinding, so it couldn't be caught by the test and the program terminated.
+ Various trials and errors indicated that the problem is where an STD string
converted to a char* being passed to the internal function, but confirmation
has not been found yet. It could be a compiler bug.
Solution:
+ Added a try/catch in the constructor around the internal function and
re-throw the exception when it is caught. This is a workaround.
+ Unrelated minor fixes: removed unused variables and MESSAGE's; commented
out tvlstr.cpp/test_read_vl_string_attribute because it may be redundant,
and commented out H5Tpkg.h inclusion because TEST_ALIGNMENT is not added
yet and probably not necessary in the C++ API.
Platforms tested:
Linux/32 2.6 (jam) with PGI compilers
Linux/32 2.6 (jam) with GNU compilers
Linux/64 2.6 (koala)
Diffstat (limited to 'c++/test/tfilter.cpp')
-rw-r--r-- | c++/test/tfilter.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/c++/test/tfilter.cpp b/c++/test/tfilter.cpp index 0dbdf00..9e60655 100644 --- a/c++/test/tfilter.cpp +++ b/c++/test/tfilter.cpp @@ -47,12 +47,14 @@ #define FILTER_CHUNK_DIM2 25 // will do this function later or use it as guideline - BMR - 2007/01/26 +#if 0 static herr_t test_filter_internal(hid_t fid, const char *name, hid_t dcpl, int if_fletcher32, int corrupted, hsize_t *dset_size) { cerr << "do nothing right now" << endl; return(0); } +#endif /* Temporary filter IDs used for testing */ #define H5Z_FILTER_BOGUS 305 @@ -254,13 +256,11 @@ extern "C" void test_filters() { // Output message about test being performed - //MESSAGE("Testing Various Filters\n"); MESSAGE(5, ("Testing Various Filters\n")); hid_t fapl_id; fapl_id = h5_fileaccess(); // in h5test.c, returns a file access template - int nerrors=0; // keep track of number of failures occurr try { // Use the file access template id to create a file access prop. list |