diff options
author | Mike McGreevy <mamcgree@hdfgroup.org> | 2009-10-08 15:17:30 (GMT) |
---|---|---|
committer | Mike McGreevy <mamcgree@hdfgroup.org> | 2009-10-08 15:17:30 (GMT) |
commit | 7ec079a5152761d3e972b2f52c3542f5ec38f89e (patch) | |
tree | 4f9693427882de9fda9a36512637a7a569b57a89 /config/BlankForm | |
parent | 047ac8f136c58c373dbb0bf04963382ed8930334 (diff) | |
download | hdf5-7ec079a5152761d3e972b2f52c3542f5ec38f89e.zip hdf5-7ec079a5152761d3e972b2f52c3542f5ec38f89e.tar.gz hdf5-7ec079a5152761d3e972b2f52c3542f5ec38f89e.tar.bz2 |
[svn-r17616] Purpose:
CFLAGS overhaul
Description:
Modified the way configure handles CFLAGS.
(note: all changes also apply to FCFLAGS, CXXFLAGS, CPPFLAGS, and LDFLAGS).
1. The configure process will now always preserve a user's CFLAGS
environment variable setup. Any additional flags necessary for compilation
added at configure time will be passed into the Makefiles as AM_CFLAGS,
which is an automake construct to be used in addition to CFLAGS.
This will allow a user to have the final say, as CFLAGS will always appear
later in the compile line than AM_CFLAGS. Additionally, setting CFLAGS
during make will no longer completely erase all flags set by configure,
since they're maintained in AM_CFLAGS.
2. Additionally, where possible, flags previously being assigned directly
into CFLAGS (and thus propagating into h5cc) have now been redirected into
H5_CFLAGS, so they're used ONLY for compiling hdf5, and not embedded into
the h5cc wrapper script as well.
*Note that H5_CFLAGS ultimately is assigned into AM_CFLAGS for use in the
Makefiles. Complete description of changes and build process will be
included in a Configure Document that Elena and I are working on.
3. Removed unsupported config files. This includes:
config/dec-osf*
config/hpux11.00
config/irix5.x
config/powerpc-ibm-aix4.x
config/rs6000-ibm-aix5.x
config/unicos*
4. Modified configure summary to display additional values. Specifically,
appropriate AM_* variables are being shown, as well as H5_FCFLAGS and
H5_CXXFLAGS, which were for some reason not already present.
Tested:
- H5committest
- Tested on all THG / NCSA machines, using several combinations of the more
prominent configure options (c++, fortran, szip, threadsafe, parallel,
et cetera). (Thanks to Quincey for rysnc testing setup!)
- With regards to new automated testing, anything *necessary* for
compilation will be caught by the daily tests as it stands now. (i.e.,
if LDFLAGS is not properly set when szip is used, linking will fail).
Additionally, with regards to which flags get into h5cc, if any
*necessary* flags have been improperly removed, then daily tests should
fail during make installcheck. Additional machine-specific desired
behaviors and/or checks may have to be set up separately within the
daily tests, so this is something to work on.
Diffstat (limited to 'config/BlankForm')
-rw-r--r-- | config/BlankForm | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/config/BlankForm b/config/BlankForm index a70762c..31116bf 100644 --- a/config/BlankForm +++ b/config/BlankForm @@ -72,7 +72,7 @@ fi # `-pg'). This may or may not include debugging # or production flags. # -# CFLAGS Flags can be added to this variable which +# H5_CFLAGS Flags can be added to this variable which # might already be partially initialized. These # flags will always be passed to the compiler # and should include switches to turn on full @@ -81,16 +81,14 @@ fi # practices resulting in few if any # warnings. # -# Warning flags do not have to be added to CFLAGS +# Warning flags do not have to be added to H5_CFLAGS # variable if the compiler is the GNU gcc # compiler or a descendent of gcc such as EGCS or PGCC. # -# The CFLAGS should contains *something* or else -# configure will probably add `-g'. For most -# systems this isn't a problem but some systems -# will disable optimizations in favor of the -# `-g'. -# +# AM_CFLAGS Flags added directly into this variable will +# be propogated to the compiler wrapper scripts (h5cc, +# h5c++, et cetera) in addition to being used to compile +# the library. # # These flags should be set according to the compiler being used. # There are two ways to check the compiler. You can try using `-v' or @@ -101,7 +99,7 @@ fi case $CC_BASENAME in gcc) - CFLAGS="$CFLAGS -Wsign-compare" #Only works for some versions + H5_CFLAGS="$H5_CFLAGS -Wsign-compare" #Only works for some versions DEBUG_CFLAGS="-g -fverbose-asm" DEBUG_CPPFLAGS= PROD_CFLAGS="-O3 -fomit-frame-pointer" @@ -111,7 +109,7 @@ case $CC_BASENAME in ;; *) - CFLAGS="$CFLAGS -ansi" + H5_CFLAGS="$H5_CFLAGS -ansi" DEBUG_CFLAGS="-g" DEBUG_CPPFLAGS= PROD_CFLAGS="-O" |