diff options
| author | David Young <dyoung@hdfgroup.org> | 2022-05-06 23:26:48 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-06 23:26:48 (GMT) |
| commit | 779ab44aa03aa351f01bddbfc4a565aebdcc15ae (patch) | |
| tree | e92d760f5517d171c0689195910bfbc27d3a1786 /config/cmake/HDFCompilerFlags.cmake | |
| parent | ca737ece9acd8168d9df4a08c9907a294053a883 (diff) | |
| download | hdf5-779ab44aa03aa351f01bddbfc4a565aebdcc15ae.zip hdf5-779ab44aa03aa351f01bddbfc4a565aebdcc15ae.tar.gz hdf5-779ab44aa03aa351f01bddbfc4a565aebdcc15ae.tar.bz2 | |
Re-promote some GNU warnings to errors (#1508)
* Promote some GCC warnings back to errors and deal with build breakage.
I tested configuring and building with GCC 8.3.0 with
`.../configure --prefix=$HOME/wrk/install/manydsets --enable-build-mode=production --enable-symbols=-gdwarf-4 --enable-warnings-as-errors --enable-java --enable-hl --enable-fortran --enable-cxx --enable-mirror-vfd --enable-ros3-vfd --enable-direct-vfd`
and with the same options but `--enable-build-mode=debug`.
* Promote -Wrestrict to -Werror=restrict to help catch overlapping
arguments to strcpy, memcpy, et cetera, at compile time.
* NFCI: sort lines.
* Committing clang-format changes
* NFCI: remove whitespace at EOL.
* Re-use temporary variable `shared`.
* Remove merge oopsie.
* Mention that no op codes are understood per review comment.
* Change this back to the develop branch's way, since this change isn't
integral to the PR.
* Committing clang-format changes
* NFCI: reduce differences with `develop` branch in the hope that that
also kicks off CI.
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>
Diffstat (limited to 'config/cmake/HDFCompilerFlags.cmake')
| -rw-r--r-- | config/cmake/HDFCompilerFlags.cmake | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/config/cmake/HDFCompilerFlags.cmake b/config/cmake/HDFCompilerFlags.cmake index eb43b73..61218dc 100644 --- a/config/cmake/HDFCompilerFlags.cmake +++ b/config/cmake/HDFCompilerFlags.cmake @@ -231,6 +231,7 @@ if (CMAKE_C_COMPILER_ID STREQUAL "GNU") # Append more extra warning flags that only gcc 7.x+ knows about if (NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 7.0) ADD_H5_FLAGS (H5_CFLAGS "${HDF5_SOURCE_DIR}/config/gnu-warnings/7") + ADD_H5_FLAGS (H5_CFLAGS "${HDF5_SOURCE_DIR}/config/gnu-warnings/error-7") if (HDF5_ENABLE_DEV_WARNINGS) ADD_H5_FLAGS (H5_CFLAGS "${HDF5_SOURCE_DIR}/config/gnu-warnings/developer-7") #else () |