Various warning fixes (#1812)

* Fixed -Wreserved-id-macro warnings from header include guards

* Removed all __int64 and LL suffix stuff now that C99 is minimum requirement

* Rename `H5FD_CTL__` to `H5FD_CTL_` to fix -Wreserved-id-macro warnings

Double underscore is reserved in C++ and this public header should be C++ compatible.

* Never define __STDC_FORMAT_MACROS anymore

Defining it causes a -Wreserved-id-macro.

Happily, according to the C++11 standard:

"The macros defined by <stdint> are provided unconditionally. In particular, the symbols __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS (mentioned in C99 footnotes 219, 220, and 222) play no role in C++."

https://cplusplus.github.io/LWG/issue984

So looks like it's not necessary to define it with reasonably new toolchains.

* Fixed some -Wunused-macros warnings, removed dead code

* Fixed all -Wdouble-promotion warnings in C++ files

* Fixed remaining -Wsuggest-destructor-override warnings

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

1 files changed, 0 insertions, 48 deletions

diff --git a/config/cmake_ext_mod/HDFTests.c b/config/cmake_ext_mod/HDFTests.c
index 2b2a202..16686ba 100644
--- a/config/cmake_ext_mod/HDFTests.c
+++ b/config/cmake_ext_mod/HDFTests.c
@@ -80,54 +80,6 @@ SIMPLE_TEST(timezone=0);
 
 #endif /* HAVE_TIMEZONE */
 
-#ifdef PRINTF_LL_WIDTH
-
-#ifdef HAVE_LONG_LONG
-#  define LL_TYPE long long
-#else /* HAVE_LONG_LONG */
-#  define LL_TYPE __int64
-#endif /* HAVE_LONG_LONG */
-
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-
-#if defined(_MSC_VER) && defined(_DEBUG)
-# include <crtdbg.h>
-int DebugReport(int reportType, char* message, int* returnValue)
-{
-  (void)reportType;
-  (void)message;
-  (void)returnValue;
-  return 1; /* no further handling required */
-}
-#endif
-
-int main(void)
-{
-  char *llwidthArgs[] = { "I64", "l64", "ll", "l", "L", "q", NULL };
-  char *s = malloc(128);
-  char **currentArg = NULL;
-  LL_TYPE x = (LL_TYPE)1048576 * (LL_TYPE)1048576;
-  #if defined(_MSC_VER) && defined(_DEBUG)
-    _CrtSetReportHook(DebugReport);
-  #endif
-  for (currentArg = llwidthArgs; *currentArg != NULL; currentArg++)
-    {
-    char formatString[64];
-    snprintf(formatString, sizeof(formatString), "%%%sd", *currentArg);
-    snprintf(s, 128, formatString, x);
-    if (strcmp(s, "1099511627776") == 0)
-      {
-      printf("PRINTF_LL_WIDTH=[%s]\n", *currentArg);
-      return 0;
-      }
-    }
-  return 1;
-}
-
-#endif /* PRINTF_LL_WIDTH */
-
 #ifdef SYSTEM_SCOPE_THREADS
 #include <stdlib.h>
 #include <pthread.h>