diff options
author | Dana Robinson <43805+derobins@users.noreply.github.com> | 2024-03-09 07:17:13 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-03-09 07:17:13 (GMT) |
commit | 3d09a7d5f6dd0f602a8f343809384ed00cd13f5c (patch) | |
tree | 00ea6998f2c44ae9d0e6460bc617b0639abc2734 /config | |
parent | d8af09dd8f064c97c4120b2a5d1cfd1103526d07 (diff) | |
download | hdf5-3d09a7d5f6dd0f602a8f343809384ed00cd13f5c.zip hdf5-3d09a7d5f6dd0f602a8f343809384ed00cd13f5c.tar.gz hdf5-3d09a7d5f6dd0f602a8f343809384ed00cd13f5c.tar.bz2 |
Remove H5B debug checks (#4089)
The H5B (version 1 B-tree) package would add some computationally
expensive integrity checks when H5B_DEBUG was defined. Due to their
negative effects on performance, this option was rarely turned on,
making the H5B__assert() check function stale, if not dead, code.
This change:
* Builds H5B__assert() when NDEBUG is not defined (the function
relies on assert()) so it gets compiled more often.
* Removes some printf debugging statements in the B-tree code
* Removes all H5B "extra debug" checks that are leftover from
past debugging sessions. Maintainers can add H5B__assert()
selectively to perform integrity checks when debugging.
* Removes the HDF5_ENABLE_DEBUG_H5B CMake option
H5B_DEBUG now has no effect
Diffstat (limited to 'config')
-rw-r--r-- | config/cmake/HDF5DeveloperBuild.cmake | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/config/cmake/HDF5DeveloperBuild.cmake b/config/cmake/HDF5DeveloperBuild.cmake index 40efb0e..f8ccc2f 100644 --- a/config/cmake/HDF5DeveloperBuild.cmake +++ b/config/cmake/HDF5DeveloperBuild.cmake @@ -139,16 +139,6 @@ if (HDF5_ENABLE_DEBUG_H5T_REF) list (APPEND HDF5_DEBUG_APIS H5T_REF_DEBUG) endif () -# HDF5 module debug definitions for debug code which may add -# considerable amounts of overhead when enabled and is usually -# only useful for specific circumstances rather than general -# developer use. -option (HDF5_ENABLE_DEBUG_H5B "Enable debugging of H5B module" OFF) -mark_as_advanced (HDF5_ENABLE_DEBUG_H5B) -if (HDF5_ENABLE_DEBUG_H5B) - list (APPEND HDF5_DEBUG_APIS H5B_DEBUG) -endif () - option (HDF5_ENABLE_DEBUG_H5B2 "Enable debugging of H5B2 module" OFF) mark_as_advanced (HDF5_ENABLE_DEBUG_H5B2) if (HDF5_ENABLE_DEBUG_H5B2) |