summaryrefslogtreecommitdiffstats
path: root/doc
diff options
context:
space:
mode:
authorDavid Young <dyoung@hdfgroup.org>2019-11-19 21:52:38 (GMT)
committerDavid Young <dyoung@hdfgroup.org>2019-11-19 21:52:38 (GMT)
commit898871545d22253b1e932ae86887403197a23b24 (patch)
tree73ef111400f83c12b9431395a4fc5f96d316a6b3 /doc
parentd84343004e74dbe1435a8e8ec151a3ffd3b2ad84 (diff)
downloadhdf5-898871545d22253b1e932ae86887403197a23b24.zip
hdf5-898871545d22253b1e932ae86887403197a23b24.tar.gz
hdf5-898871545d22253b1e932ae86887403197a23b24.tar.bz2
Add some notes about what's done and what I'm working on.
Diffstat (limited to 'doc')
-rw-r--r--doc/VFD_SWMR_Punch_List.md28
1 files changed, 25 insertions, 3 deletions
diff --git a/doc/VFD_SWMR_Punch_List.md b/doc/VFD_SWMR_Punch_List.md
index 6e9e021..60f13b0 100644
--- a/doc/VFD_SWMR_Punch_List.md
+++ b/doc/VFD_SWMR_Punch_List.md
@@ -79,10 +79,20 @@ This document lives at [https://bitbucket.hdfgroup.org/users/dyoung/repos/vchoi_
18. Flesh out designs for unit, integration and performance tests suites
as outlined in the RFC. Implement same.
-19. Fix memory leak in sparse-reader test.
+19. *in-progress* Fix memory leak in sparse-reader test.
-20. Test John's patch that repairs the superblock flags mismatch that
- crashes the reader.
+ David found that the shadow index was leaked by VFD SWMR readers
+ and plugged the leak. Now the sparse reader tests do not use up
+ all of the memory on `jelly`. David fixed the bug on his branch
+ `vfd_swmr-merge-attempt-2`, which as of 19 Nov 2019 has not been
+ merged to `feature/vfd_swmr`.
+
+20. *in-progress* Test John's patch that repairs the superblock flags
+ mismatch that crashes the reader.
+
+ David found that the patch fixed the demo crashes. He applied the
+ patch to his branch `vfd_swmr-merge-attempt-2`, which has not yet
+ been merged to `feature/vfd_swmr` as of 19 Nov 2019.
21. Investigate a potential time-of-check, time-of-use race condition
involving EOA/EOF and the skip\_read variable in some of the H5PB
@@ -102,3 +112,15 @@ This document lives at [https://bitbucket.hdfgroup.org/users/dyoung/repos/vchoi_
the global heap is modified/replaced as currently planned, then VFD
SWMR does not have to deal with it. However, if the global heap
overhaul does not take place, then we have more work to do.
+
+26. Fix the expand/shrink test.
+
+ The test *probably* fails because the dataset extent is enlarged
+ before the data is written, so arbitrary data is present until the
+ data appears. If a tick sneaks in between the `H5Dset_extent` and
+ the `H5Dwrite`, then the reader may read the arbitrary data.
+
+ In the `gaussian` test, I have a heuristic that avoids reading
+ arbitrary data. I may replicate that in the expand/shrink test.
+
+ Ultimately, we should suspend ticks over the H5Dset_extent/H5Dwrite.