diff options
| author | Sean McBride <sean@rogue-research.com> | 2023-06-19 05:13:38 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-19 05:13:38 (GMT) |
| commit | 65d8c9347010771473b53c91adcec2f281772213 (patch) | |
| tree | 487567dae0dc005de896f616b90e67744239a5e2 /hl/tools | |
| parent | 1f20354ee6cdfa9fd157ac9cdfff9acdf320a32d (diff) | |
| download | hdf5-65d8c9347010771473b53c91adcec2f281772213.zip hdf5-65d8c9347010771473b53c91adcec2f281772213.tar.gz hdf5-65d8c9347010771473b53c91adcec2f281772213.tar.bz2 | |
Many fixes to various compiler warnings (#3124)
* Fixed various -Wmissing-variable-declarations by adding static keyword
* In a few cases, renamed the variable suffix from _g to _s.
* Fixed some -Wmissing-variable-declarations by using different declaration macros
* Fixed various -Wconditional-uninitialized warnings by just initializing variable to zero
* Fixed various -Wcomma warnings
* Fixed clang -Wstrict-prototypes warnings
* Fixed various -Wunused-variable warnings
* Updated some casts to fix the only 3 -Wcast-qual warnings
* Fixed the only -Wsometimes-uninitialized warning
Diffstat (limited to 'hl/tools')
| -rw-r--r-- | hl/tools/gif2h5/decompress.c | 4 | ||||
| -rw-r--r-- | hl/tools/gif2h5/hdf2gif.c | 2 | ||||
| -rw-r--r-- | hl/tools/h5watch/h5watch.c | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/hl/tools/gif2h5/decompress.c b/hl/tools/gif2h5/decompress.c index dabadf5..e87a60c 100644 --- a/hl/tools/gif2h5/decompress.c +++ b/hl/tools/gif2h5/decompress.c @@ -54,8 +54,8 @@ GIFBYTE *Raster; /* The raster data stream, unblocked */ /* The hash table used by the decompressor */ -int *Prefix; -int *Suffix; +static int *Prefix; +static int *Suffix; /* An output array used by the decompressor */ diff --git a/hl/tools/gif2h5/hdf2gif.c b/hl/tools/gif2h5/hdf2gif.c index 2fd9756..8805c80 100644 --- a/hl/tools/gif2h5/hdf2gif.c +++ b/hl/tools/gif2h5/hdf2gif.c @@ -49,7 +49,7 @@ leave(int ret) HDexit(ret); } -FILE *fpGif = NULL; +static FILE *fpGif = NULL; int main(int argc, char **argv) { diff --git a/hl/tools/h5watch/h5watch.c b/hl/tools/h5watch/h5watch.c index 248fb90..102ff93 100644 --- a/hl/tools/h5watch/h5watch.c +++ b/hl/tools/h5watch/h5watch.c @@ -27,7 +27,7 @@ * This tool uses H5LD_memb_t data structure declared in H5LDprivate.h */ -const char *progname = "h5watch"; /* tool name */ +static const char *progname = "h5watch"; /* tool name */ static char *g_list_of_fields = NULL; /* command line input for "list_of_fields" */ static char *g_dup_fields = NULL; /* copy of "list_of_fields" */ static H5LD_memb_t **g_listv = NULL; /* vector info for "list_of_fields" */ |