Primary change is HDFFV-11212 - new refs and JNI (#372)

* OESS-98 convert plugin option to FetchContent, add tests

* Fixes for pkcfg files because of plugin option

* OESS-98 fix tools test for plugins

* Keep doxygen comments under 100 chars long - format hint

* Whitespace

* HDFFV-11144 - Reclassify CMake messages

* HDFFV-11099/11100 added help text

* Reworked switch statement to compare string instead

* Fix typo

* Update CDash mode

* Correct name of threadsafe

* Correct option name

* Undo accidental commit

* Note LLVM 10 to 11 format default changes

* Update format plugin

* Undo clang-format version 11 changes

* One more correction

* Update supported platforms

* Revert whitespace changes

* Correct whitespace

* Changes from PR#3

* HDFFV-11213 added option to control gcc10 warnings diagnostics

* HDFFV-11212 Use the new references correctly in JNI utility and tests

* format source

* Fix typo

* Add new test file

* HDFFV-11212 - update test and remove unused arg

* Minor non-space formatting changes

* Use H5I_INVALID_ID instead of "-1"

* source formatting

* add missing testfile, update jni function

* Undo commit of debug code

* remove mislocated file

* Fix h5repack test for handling of fapls and id close

* Update h5diff test files usage text

* HDFFV-11212 add new ref tests for JNI export dataset

* src format update

* Remove blank line typo

* src format typo

* long double requires %Lg

* Another long double foramt specifer S.B. %Lg

* issue with t128bit test

* Windows issue with h5dump and type.

* Fix review issues

* refactor function nesting and fix error checks

* format fixes

* Remove untested functions and javadoc quiet comments

* Restore TRY block.

* Change string append errors to memory exception

* revert to H5_JNI_FATAL_ERROR - support functions need work

* Add assertion error for h5util functions

* remove duplicate function

* format fix

* Revert HD function error handling

* Update copyright comments

1 files changed, 8 insertions, 8 deletions

diff --git a/java/test/TestH5Gbasic.java b/java/test/TestH5Gbasic.java
index aea417e..539b336 100644
--- a/java/test/TestH5Gbasic.java
+++ b/java/test/TestH5Gbasic.java
@@ -33,10 +33,10 @@ import org.junit.rules.TestName;
 public class TestH5Gbasic {
     @Rule public TestName testname = new TestName();
     private static final String H5_FILE = "testGb.h5";
-    long H5fid = -1;
+    long H5fid = HDF5Constants.H5I_INVALID_HID;
 
     private final long _createGroup(long fid, String name) {
-        long gid = -1;
+        long gid = HDF5Constants.H5I_INVALID_HID;
         try {
             gid = H5.H5Gcreate(fid, name, HDF5Constants.H5P_DEFAULT,
                         HDF5Constants.H5P_DEFAULT, HDF5Constants.H5P_DEFAULT);
@@ -85,7 +85,7 @@ public class TestH5Gbasic {
 
     @Test(expected = NullPointerException.class)
     public void testH5Gcreate_null() throws Throwable {
-        long gid = -1;
+        long gid = HDF5Constants.H5I_INVALID_HID;
 
         // it should fail because the group name is null
         gid = H5.H5Gcreate(H5fid, null, HDF5Constants.H5P_DEFAULT,
@@ -102,7 +102,7 @@ public class TestH5Gbasic {
 
     @Test
     public void testH5Gcreate() {
-        long gid = -1;
+        long gid = HDF5Constants.H5I_INVALID_HID;
         try {
             gid = H5.H5Gcreate(H5fid, "/testH5Gcreate",
                         HDF5Constants.H5P_DEFAULT, HDF5Constants.H5P_DEFAULT,
@@ -145,7 +145,7 @@ public class TestH5Gbasic {
 
     @Test
     public void testH5Gcreate_anon() {
-        long gid = -1;
+        long gid = HDF5Constants.H5I_INVALID_HID;
         try {
             gid = H5.H5Gcreate_anon(H5fid, HDF5Constants.H5P_DEFAULT,
                     HDF5Constants.H5P_DEFAULT);
@@ -161,7 +161,7 @@ public class TestH5Gbasic {
 
     @Test(expected = NullPointerException.class)
     public void testH5Gopen_null() throws Throwable {
-        long gid = -1;
+        long gid = HDF5Constants.H5I_INVALID_HID;
 
         gid = H5.H5Gopen(H5fid, null, HDF5Constants.H5P_DEFAULT);
 
@@ -175,7 +175,7 @@ public class TestH5Gbasic {
 
     @Test(expected = HDF5LibraryException.class)
     public void testH5Gopen_not_exists() throws Throwable {
-        long gid = -1;
+        long gid = HDF5Constants.H5I_INVALID_HID;
 
          gid = H5.H5Gopen(H5fid, "Never_created", HDF5Constants.H5P_DEFAULT);
 
@@ -209,7 +209,7 @@ public class TestH5Gbasic {
 
     @Test
     public void testH5Gget_create_plist() {
-        long pid = -1;
+        long pid = HDF5Constants.H5I_INVALID_HID;
         long gid = _createGroup(H5fid, "/testH5Gcreate");
         assertTrue(gid > 0);