Merge branch 'develop' into feature/coding_standardsfeature/coding_standards

1 files changed, 200 insertions, 137 deletions

diff --git a/java/test/TestH5Ocopy.java b/java/test/TestH5Ocopy.java
index e730b9f..821cad3 100644
--- a/java/test/TestH5Ocopy.java
+++ b/java/test/TestH5Ocopy.java
@@ -1,12 +1,11 @@
 /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
  * Copyright by The HDF Group.                                               *
- * Copyright by the Board of Trustees of the University of Illinois.         *
  * All rights reserved.                                                      *
  *                                                                           *
  * This file is part of HDF5.  The full HDF5 copyright notice, including     *
  * terms governing use, modification, and redistribution, is contained in    *
  * the COPYING file, which can be found at the root of the source code       *
- * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases.  *
+ * distribution tree, or in https://www.hdfgroup.org/licenses.               *
  * If you do not have access to either file, you may request a copy from     *
  * help@hdfgroup.org.                                                        *
  * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
@@ -36,13 +35,13 @@ public class TestH5Ocopy {
     private static final String FILENAME = "testRefsattribute.h5";
     private static final int DIM_X = 4;
     private static final int DIM_Y = 6;
-    long H5fid = -1;
-    long H5dsid = -1;
-    long H5did1 = -1;
-    long H5did2 = -1;
-    long H5gcpl = -1;
-    long H5gid = -1;
-    long H5dsid2 = -1;
+    long H5fid = HDF5Constants.H5I_INVALID_HID;
+    long H5dsid = HDF5Constants.H5I_INVALID_HID;
+    long H5did1 = HDF5Constants.H5I_INVALID_HID;
+    long H5did2 = HDF5Constants.H5I_INVALID_HID;
+    long H5gcpl = HDF5Constants.H5I_INVALID_HID;
+    long H5gid = HDF5Constants.H5I_INVALID_HID;
+    long H5dsid2 = HDF5Constants.H5I_INVALID_HID;
     long[] dims = { 2 };
 
     private final void _deleteFile(String filename) {
@@ -59,7 +58,7 @@ public class TestH5Ocopy {
     }
 
     private final long _createDataset(long fid, long dsid, String name, long dapl) {
-        long did = -1;
+        long did = HDF5Constants.H5I_INVALID_HID;
         try {
             did = H5.H5Dcreate(fid, name,
                         HDF5Constants.H5T_STD_I32BE, dsid,
@@ -75,7 +74,7 @@ public class TestH5Ocopy {
     }
 
     private final long _createGroup(long fid, String name) {
-        long gid = -1;
+        long gid = HDF5Constants.H5I_INVALID_HID;
         try {
             H5gcpl = HDF5Constants.H5P_DEFAULT;
             gid = H5.H5Gcreate(fid, name, HDF5Constants.H5P_DEFAULT,
@@ -136,34 +135,47 @@ public class TestH5Ocopy {
 
     @Test
     public void testH5OcopyRefsAttr() {
-        long ocp_plist_id = -1;
-        byte rbuf0[]=null , rbuf1[] = null;
-        byte[] dset_data = new byte[16];
-        long attribute_id = -1;
-
-
-        try {
-            rbuf0 = H5.H5Rcreate(H5fid, "/G1", HDF5Constants.H5R_OBJECT, -1);
-            rbuf1 = H5.H5Rcreate(H5fid, "DS2", HDF5Constants.H5R_OBJECT, -1);
-            //System.arraycopy(rbuf0, 0, dset_data, 0, 8);
-            System.arraycopy(rbuf1, 0, dset_data, 8, 8);
-        }
-        catch (Exception ex) {
-            fail("testH5OcopyRefsAttr: H5Rcreate failed");
-        }
+        long ocp_plist_id = HDF5Constants.H5I_INVALID_HID;
+        byte[][] dset_data = new byte[2][HDF5Constants.H5R_REF_BUF_SIZE];
+        long attribute_id = HDF5Constants.H5I_INVALID_HID;
 
         try {
-            attribute_id = H5.H5Acreate(H5did2, "A1", HDF5Constants.H5T_STD_REF_OBJ, H5dsid, HDF5Constants.H5P_DEFAULT, HDF5Constants.H5P_DEFAULT);
-            assertTrue("testH5OcopyRefsAttr.H5Acreate: ", attribute_id >= 0);
-            H5.H5Awrite(attribute_id, HDF5Constants.H5T_STD_REF_OBJ, dset_data);
-
-            H5.H5Aclose(attribute_id);
+            try {
+                dset_data[0] = H5.H5Rcreate_object(H5fid, "/G1", HDF5Constants.H5P_DEFAULT);
+            }
+            catch (Throwable err) {
+                err.printStackTrace();
+                fail("testH5OcopyRefsAttr: H5Rcreate_object " + err);
+            }
+    
+            try {
+                dset_data[1] = H5.H5Rcreate_object(H5fid, "DS2", HDF5Constants.H5P_DEFAULT);
+            }
+            catch (Throwable err) {
+                err.printStackTrace();
+                fail("testH5OcopyRefsAttr: H5Rcreate_object " + err);
+            }
+    
+            try {
+                attribute_id = H5.H5Acreate(H5did2, "A1", HDF5Constants.H5T_STD_REF, H5dsid, HDF5Constants.H5P_DEFAULT, HDF5Constants.H5P_DEFAULT);
+                assertTrue("testH5OcopyRefsAttr.H5Acreate: ", attribute_id >= 0);
+                H5.H5Awrite(attribute_id, HDF5Constants.H5T_STD_REF, dset_data);
+    
+                H5.H5Aclose(attribute_id);
+            }
+            catch (Exception ex) {
+                fail("testH5OcopyRefsAttr: H5Awrite failed");
+            }
+            finally {
+                try {H5.H5Aclose(attribute_id);} catch (Exception exx) {}
+            }
         }
         catch (Exception ex) {
-            fail("testH5OcopyRefsAttr: H5Awrite failed");
+            ex.printStackTrace();
         }
         finally {
-            try {H5.H5Aclose(attribute_id);} catch (Exception exx) {}
+            try {H5.H5Rdestroy(dset_data[1]);} catch (Exception ex) {}
+            try {H5.H5Rdestroy(dset_data[0]);} catch (Exception ex) {}
         }
 
         try {
@@ -182,30 +194,50 @@ public class TestH5Ocopy {
 
     @Test
     public void testH5OcopyRefsDatasettodiffFile() {
-        byte rbuf1[] = null;
-        byte[] dset_data = new byte[16];
-        long ocp_plist_id = -1;
-        long dataset_id = -1;
-        long H5fid2 = -1;
+        byte[][] dset_data = new byte[2][HDF5Constants.H5R_REF_BUF_SIZE];
+        long ocp_plist_id = HDF5Constants.H5I_INVALID_HID;
+        long dataset_id = HDF5Constants.H5I_INVALID_HID;
+        long H5fid2 = HDF5Constants.H5I_INVALID_HID;
 
         try {
-            rbuf1 = H5.H5Rcreate(H5fid, "DS2", HDF5Constants.H5R_OBJECT, -1);
-            System.arraycopy(rbuf1, 0, dset_data, 8, 8);
-
-            dataset_id = H5.H5Dcreate(H5fid, "DSREF",
-                    HDF5Constants.H5T_STD_REF_OBJ, H5dsid,
-                    HDF5Constants.H5P_DEFAULT, HDF5Constants.H5P_DEFAULT, HDF5Constants.H5P_DEFAULT);
-            assertTrue("testH5OcopyRefsDatasettodiffFile.H5Dcreate: ", dataset_id >= 0);
-            H5.H5Dwrite(dataset_id, HDF5Constants.H5T_STD_REF_OBJ,
-                    HDF5Constants.H5S_ALL, HDF5Constants.H5S_ALL,
-                    HDF5Constants.H5P_DEFAULT, dset_data);
-            H5.H5Dclose(dataset_id);
+            try {
+                dset_data[0] = H5.H5Rcreate_object(H5fid, "/G1", HDF5Constants.H5P_DEFAULT);
+            }
+            catch (Throwable err) {
+                err.printStackTrace();
+                fail("testH5OcopyRefsDatasettodiffFile: H5Rcreate_object " + err);
+            }
+            try {
+                dset_data[1] = H5.H5Rcreate_object(H5fid, "DS2", HDF5Constants.H5P_DEFAULT);
+            }
+            catch (Throwable err) {
+                err.printStackTrace();
+                fail("testH5OcopyRefsDatasettodiffFile: H5Rcreate_object " + err);
+            }
+    
+            try {
+                dataset_id = H5.H5Dcreate(H5fid, "DSREF",
+                        HDF5Constants.H5T_STD_REF, H5dsid,
+                        HDF5Constants.H5P_DEFAULT, HDF5Constants.H5P_DEFAULT, HDF5Constants.H5P_DEFAULT);
+                assertTrue("testH5OcopyRefsDatasettodiffFile.H5Dcreate: ", dataset_id >= 0);
+                H5.H5Dwrite(dataset_id, HDF5Constants.H5T_STD_REF,
+                        HDF5Constants.H5S_ALL, HDF5Constants.H5S_ALL,
+                        HDF5Constants.H5P_DEFAULT, dset_data);
+                H5.H5Dclose(dataset_id);
+            }
+            catch (Exception ex) {
+                fail("testH5OcopyRefsDatasettodiffFile: create dataset failed");
+            }
+            finally {
+                try {H5.H5Dclose(dataset_id);} catch (Exception exx) {}
+            }
         }
         catch (Exception ex) {
-            fail("testH5OcopyRefsDatasettodiffFile: create dataset failed");
+            ex.printStackTrace();
         }
         finally {
-            try {H5.H5Dclose(dataset_id);} catch (Exception exx) {}
+            try {H5.H5Rdestroy(dset_data[0]);} catch (Exception ex) {}
+            try {H5.H5Rdestroy(dset_data[1]);} catch (Exception ex) {}
         }
 
         try {
@@ -242,123 +274,154 @@ public class TestH5Ocopy {
 
     @Test
     public void testH5OcopyRefsDatasettosameFile() {
-        byte rbuf0[]=null , rbuf1[] = null;
-        byte[] dset_data = new byte[16];
-        long ocp_plist_id = -1;
-        long dataset_id = -1;
-        long did = -1;
+        byte[][] dset_data = new byte[2][HDF5Constants.H5R_REF_BUF_SIZE];
+        byte[][] read_data = new byte[2][HDF5Constants.H5R_REF_BUF_SIZE];
+        long ocp_plist_id = HDF5Constants.H5I_INVALID_HID;
+        long dataset_id = HDF5Constants.H5I_INVALID_HID;
+        long did = HDF5Constants.H5I_INVALID_HID;
         int obj_type = -1;
-        byte[] read_data = new byte[16];
 
         try {
-            rbuf0 = H5.H5Rcreate(H5fid, "/G1", HDF5Constants.H5R_OBJECT, -1);
-            rbuf1 = H5.H5Rcreate(H5fid, "DS2", HDF5Constants.H5R_OBJECT, -1);
-            System.arraycopy(rbuf0, 0, dset_data, 0, 8);
-            System.arraycopy(rbuf1, 0, dset_data, 8, 8);
-
-            //Create a dataset and write object references to it.
-            dataset_id = H5.H5Dcreate(H5fid, "DSREF",
-                    HDF5Constants.H5T_STD_REF_OBJ, H5dsid,
-                    HDF5Constants.H5P_DEFAULT, HDF5Constants.H5P_DEFAULT, HDF5Constants.H5P_DEFAULT);
-            assertTrue("testH5OcopyRefsDatasettosameFile.H5Dcreate: ", dataset_id >= 0);
-            H5.H5Dwrite(dataset_id, HDF5Constants.H5T_STD_REF_OBJ,
-                    HDF5Constants.H5S_ALL, HDF5Constants.H5S_ALL,
-                    HDF5Constants.H5P_DEFAULT, dset_data);
-            //Close the dataset.
-            H5.H5Dclose(dataset_id);
+            try {
+                dset_data[0] = H5.H5Rcreate_object(H5fid, "/G1", HDF5Constants.H5P_DEFAULT);
+            }
+            catch (Throwable err) {
+                err.printStackTrace();
+                fail("testH5OcopyRefsDatasettosameFile: H5Rcreate_object " + err);
+            }
+    
+            try {
+                dset_data[1] = H5.H5Rcreate_object(H5fid, "DS2", HDF5Constants.H5P_DEFAULT);
+            }
+            catch (Throwable err) {
+                err.printStackTrace();
+                fail("testH5OcopyRefsDatasettosameFile: H5Rcreate_object " + err);
+            }
+    
+            try {
+                //Create a dataset and write object references to it.
+                dataset_id = H5.H5Dcreate(H5fid, "DSREF",
+                        HDF5Constants.H5T_STD_REF, H5dsid,
+                        HDF5Constants.H5P_DEFAULT, HDF5Constants.H5P_DEFAULT, HDF5Constants.H5P_DEFAULT);
+                assertTrue("testH5OcopyRefsDatasettosameFile.H5Dcreate: ", dataset_id >= 0);
+                H5.H5Dwrite(dataset_id, HDF5Constants.H5T_STD_REF,
+                        HDF5Constants.H5S_ALL, HDF5Constants.H5S_ALL,
+                        HDF5Constants.H5P_DEFAULT, dset_data);
+                //Close the dataset.
+                H5.H5Dclose(dataset_id);
+            }
+            catch (Exception ex) {
+                fail("testH5OcopyRefsDatasettosameFile: create dataset failed");
+            }
+            finally {
+                try {H5.H5Dclose(dataset_id);} catch (Exception exx) {}
+            }
         }
         catch (Exception ex) {
-            try {H5.H5Dclose(dataset_id);} catch (Exception exx) {}
-            fail("testH5OcopyRefsDatasettosameFile: create dataset failed");
+            ex.printStackTrace();
+        }
+        finally {
+            try {H5.H5Rdestroy(dset_data[1]);} catch (Exception ex) {}
+            try {H5.H5Rdestroy(dset_data[0]);} catch (Exception ex) {}
         }
 
         try {
             ocp_plist_id = H5.H5Pcreate(HDF5Constants.H5P_OBJECT_COPY);
             assertTrue("testH5OcopyRefsDatasettosameFile.H5Pcreate: ", ocp_plist_id >= 0);
             H5.H5Pset_copy_object(ocp_plist_id, HDF5Constants.H5O_COPY_EXPAND_REFERENCE_FLAG);
+            //Perform copy function.
+            try {
+                H5.H5Ocopy(H5fid, "DSREF", H5fid, "CPYREFD", ocp_plist_id, HDF5Constants.H5P_DEFAULT);
+            }
+            catch(Exception ex) {
+                fail("testH5OcopyRefsDatasettosameFile: H5Ocopy failed");
+            }
         }
         catch (Exception ex) {
-            try {H5.H5Pclose(ocp_plist_id);} catch (Exception exx) {}
             fail("testH5OcopyRefsDatasettosameFile: H5Pset_copy_object failed");
         }
-
-        //Perform copy function.
-        try {
-            H5.H5Ocopy(H5fid, "DSREF", H5fid, "CPYREFD", ocp_plist_id, HDF5Constants.H5P_DEFAULT);
-        }
-        catch(Exception ex) {
+        finally {
             try {H5.H5Pclose(ocp_plist_id);} catch (Exception exx) {}
-            fail("testH5OcopyRefsDatasettosameFile: H5Ocopy failed");
         }
 
-        //Open the dataset that has been copied
         try {
-            did = H5.H5Dopen(H5fid, "DSREF", HDF5Constants.H5P_DEFAULT);
-            assertTrue("testH5OcopyRefsDatasettosameFile.H5Dopen: ", did >= 0);
+            //Open the dataset that has been copied
+            try {
+                did = H5.H5Dopen(H5fid, "DSREF", HDF5Constants.H5P_DEFAULT);
+                assertTrue("testH5OcopyRefsDatasettosameFile.H5Dopen: ", did >= 0);
+            }
+            catch (Exception e) {
+                e.printStackTrace();
+                fail("testH5OcopyRefsDatasettosameFile: H5Dopen failed");
+            }
+
+            //Read the dataset object references in the read_data buffer.
+            try {
+                H5.H5Dread(did, HDF5Constants.H5T_STD_REF, HDF5Constants.H5S_ALL,HDF5Constants.H5S_ALL, HDF5Constants.H5P_DEFAULT, read_data);
+            }
+            catch (Exception e) {
+                e.printStackTrace();
+                fail("testH5OcopyRefsDatasettosameFile: H5Dread failed");
+            }
         }
-        catch (Exception e) {
-            try {H5.H5Dclose(did);} catch (Exception exx) {}
-            e.printStackTrace();
-            fail("testH5OcopyRefsDatasettosameFile: H5Dopen failed");
+        catch (Exception ex) {
+            ex.printStackTrace();
+            fail("testH5OcopyRefsDatasettosameFile: open and read dataset failed");
+        }
+        finally {
+            try {H5.H5Dclose(did);} catch (Exception ex) {}
         }
 
         try {
-            //Read the dataset object references in the read_data buffer.
-            H5.H5Dread(did, HDF5Constants.H5T_STD_REF_OBJ, HDF5Constants.H5S_ALL,HDF5Constants.H5S_ALL, HDF5Constants.H5P_DEFAULT, read_data);
-            System.arraycopy(read_data, 0, rbuf0, 0, 8);
-            System.arraycopy(read_data, 8, rbuf1, 0, 8);
-
             //Get the type of object the reference points to.
-            obj_type = H5.H5Rget_obj_type(H5fid, HDF5Constants.H5R_OBJECT, rbuf1);
+            obj_type = H5.H5Rget_obj_type3(read_data[1], HDF5Constants.H5R_OBJECT);
             assertEquals(obj_type, HDF5Constants.H5O_TYPE_DATASET);
-
-            obj_type = H5.H5Rget_obj_type(H5fid, HDF5Constants.H5R_OBJECT, rbuf0);
+    
+            obj_type = H5.H5Rget_obj_type3(read_data[0], HDF5Constants.H5R_OBJECT);
             assertEquals(obj_type, HDF5Constants.H5O_TYPE_GROUP);
         }
         catch (Exception ex) {
             ex.printStackTrace();
         }
         finally {
-            try {H5.H5Dclose(did);} catch (Exception ex) {}
-            try {H5.H5Pclose(ocp_plist_id);} catch (Exception ex) {}
+            try {H5.H5Rdestroy(read_data[1]);} catch (Exception ex) {}
+            try {H5.H5Rdestroy(read_data[0]);} catch (Exception ex) {}
+        }
+    }
+    
+    @Test
+    public void testH5OcopyNullRef() throws Throwable {
+        final long _pid_ = HDF5Constants.H5P_DEFAULT;
+        long sid = HDF5Constants.H5I_INVALID_HID;
+        long did = HDF5Constants.H5I_INVALID_HID;
+        long aid = HDF5Constants.H5I_INVALID_HID;
+
+        try {
+            sid = H5.H5Screate_simple(1, new long[] {1}, null);
+            assertTrue("testH5OcopyNullRef.H5Screate_simple: ", sid >= 0);
+            did = H5.H5Dcreate(H5fid, "Dataset_with_null_Ref", HDF5Constants.H5T_NATIVE_INT, sid, _pid_, _pid_, _pid_);
+            assertTrue("testH5OcopyNullRef.H5Dcreate: ", did > 0);
+            aid = H5.H5Acreate(did, "Null_Ref", HDF5Constants.H5T_STD_REF, sid, _pid_, _pid_);
+            assertTrue("testH5OcopyNullRef.H5Acreate: ", aid > 0);
         }
-     }
-
-//    @Ignore because of JIRA HDF5-9547
-//    @Test(expected = HDF5LibraryException.class)
-//    public void testH5OcopyInvalidRef() throws Throwable {
-//        final long _pid_ = HDF5Constants.H5P_DEFAULT;
-//        long sid = -1;
-//        long did = -1;
-//        long aid = -1;
-//
-//        try {
-//            sid = H5.H5Screate_simple(1, new long[] {1}, null);
-//            assertTrue("testH5OcopyInvalidRef.H5Screate_simple: ", sid >= 0);
-//            did = H5.H5Dcreate(H5fid, "Dataset_with_invalid_Ref", HDF5Constants.H5T_NATIVE_INT, sid, _pid_, _pid_, _pid_);
-//            assertTrue("testH5OcopyInvalidRef.H5Dcreate: ", did > 0);
-//            aid = H5.H5Acreate(did, "Invalid_Ref", HDF5Constants.H5T_STD_REF_OBJ, sid, _pid_, _pid_);
-//            assertTrue("testH5OcopyInvalidRef.H5Acreate: ", aid > 0);
-//            H5.H5Awrite(aid, HDF5Constants.H5T_STD_REF_OBJ, new long[]{-1});
-//        }
-//        catch (Exception ex) {
-//            ex.printStackTrace();
-//        }
-//        finally {
-//            try {H5.H5Dclose(did);} catch (Exception exx) {}
-//            try {H5.H5Aclose(aid);} catch (Exception exx) {}
-//            try {H5.H5Sclose(sid);} catch (Exception exx) {}
-//        }
-//
-//        long ocp_plist_id = H5.H5Pcreate(HDF5Constants.H5P_OBJECT_COPY);
-//        assertTrue("testH5OcopyInvalidRef.H5Pcreate: ", ocp_plist_id >= 0);
-//        H5.H5Pset_copy_object(ocp_plist_id, HDF5Constants.H5O_COPY_EXPAND_REFERENCE_FLAG);
-//        try {
-//            H5.H5Ocopy(H5fid, "/Dataset_with_invalid_Ref", H5fid, "/Dataset_with_invalid_Ref_cp", ocp_plist_id, _pid_);
-//        }
-//        finally {
-//            try {H5.H5Pclose(ocp_plist_id);} catch (Exception exx) {}
-//        }
-//    }
+        catch (Exception ex) {
+            ex.printStackTrace();
+        }
+        finally {
+            try {H5.H5Dclose(did);} catch (Exception exx) {}
+            try {H5.H5Aclose(aid);} catch (Exception exx) {}
+            try {H5.H5Sclose(sid);} catch (Exception exx) {}
+        }
+
+        long ocp_plist_id = H5.H5Pcreate(HDF5Constants.H5P_OBJECT_COPY);
+        assertTrue("testH5OcopyNullRef.H5Pcreate: ", ocp_plist_id >= 0);
+        H5.H5Pset_copy_object(ocp_plist_id, HDF5Constants.H5O_COPY_EXPAND_REFERENCE_FLAG);
+        try {
+            H5.H5Ocopy(H5fid, "/Dataset_with_null_Ref", H5fid, "/Dataset_with_null_Ref_cp", ocp_plist_id, _pid_);
+        }
+        finally {
+            try {H5.H5Pclose(ocp_plist_id);} catch (Exception exx) {}
+        }
+    }
 
 }