Primary change is HDFFV-11212 - new refs and JNI (#372)

* OESS-98 convert plugin option to FetchContent, add tests

* Fixes for pkcfg files because of plugin option

* OESS-98 fix tools test for plugins

* Keep doxygen comments under 100 chars long - format hint

* Whitespace

* HDFFV-11144 - Reclassify CMake messages

* HDFFV-11099/11100 added help text

* Reworked switch statement to compare string instead

* Fix typo

* Update CDash mode

* Correct name of threadsafe

* Correct option name

* Undo accidental commit

* Note LLVM 10 to 11 format default changes

* Update format plugin

* Undo clang-format version 11 changes

* One more correction

* Update supported platforms

* Revert whitespace changes

* Correct whitespace

* Changes from PR#3

* HDFFV-11213 added option to control gcc10 warnings diagnostics

* HDFFV-11212 Use the new references correctly in JNI utility and tests

* format source

* Fix typo

* Add new test file

* HDFFV-11212 - update test and remove unused arg

* Minor non-space formatting changes

* Use H5I_INVALID_ID instead of "-1"

* source formatting

* add missing testfile, update jni function

* Undo commit of debug code

* remove mislocated file

* Fix h5repack test for handling of fapls and id close

* Update h5diff test files usage text

* HDFFV-11212 add new ref tests for JNI export dataset

* src format update

* Remove blank line typo

* src format typo

* long double requires %Lg

* Another long double foramt specifer S.B. %Lg

* issue with t128bit test

* Windows issue with h5dump and type.

* Fix review issues

* refactor function nesting and fix error checks

* format fixes

* Remove untested functions and javadoc quiet comments

* Restore TRY block.

* Change string append errors to memory exception

* revert to H5_JNI_FATAL_ERROR - support functions need work

* Add assertion error for h5util functions

* remove duplicate function

* format fix

* Revert HD function error handling

* Update copyright comments

1 files changed, 16 insertions, 16 deletions

diff --git a/java/test/TestH5Plist.java b/java/test/TestH5Plist.java
index 7c43693..825eeb4 100644
--- a/java/test/TestH5Plist.java
+++ b/java/test/TestH5Plist.java
@@ -85,7 +85,7 @@ public class TestH5Plist {
             PROP3_NAME,
             PROP4_NAME};
 
-    long plist_class_id = -1;
+    long plist_class_id = HDF5Constants.H5I_INVALID_HID;
 
     @Before
     public void createPropClass()throws NullPointerException, HDF5Exception
@@ -114,9 +114,9 @@ public class TestH5Plist {
     @Test
     public void testH5P_genprop_basic_class() {
         int         status = -1;
-        long        cid1 = -1;        // Generic Property class ID
-        long        cid2 = -1;        // Generic Property class ID
-        long        cid3 = -1;        // Generic Property class ID
+        long        cid1 = HDF5Constants.H5I_INVALID_HID;        // Generic Property class ID
+        long        cid2 = HDF5Constants.H5I_INVALID_HID;        // Generic Property class ID
+        long        cid3 = HDF5Constants.H5I_INVALID_HID;        // Generic Property class ID
         String      name = null;       // Name of class
 
         try {
@@ -162,7 +162,7 @@ public class TestH5Plist {
             // Close parent class
             try {
                 H5.H5Pclose_class(cid2);
-                cid2 = -1;
+                cid2 = HDF5Constants.H5I_INVALID_HID;
             }
             catch (Throwable err) {
                 err.printStackTrace();
@@ -172,7 +172,7 @@ public class TestH5Plist {
             // Close class
             try {
                 H5.H5Pclose_class(plist_class_id);
-                plist_class_id = -1;
+                plist_class_id = HDF5Constants.H5I_INVALID_HID;
             }
             catch (Throwable err) {
                 err.printStackTrace();
@@ -242,7 +242,7 @@ public class TestH5Plist {
             // Close parent class's parent
             try {
                 H5.H5Pclose_class(cid3);
-                cid3 = -1;
+                cid3 = HDF5Constants.H5I_INVALID_HID;
             }
             catch (Throwable err) {
                 err.printStackTrace();
@@ -252,7 +252,7 @@ public class TestH5Plist {
             // Close parent class's parent
             try {
                 H5.H5Pclose_class(cid2);
-                cid2 = -1;
+                cid2 = HDF5Constants.H5I_INVALID_HID;
             }
             catch (Throwable err) {
                 err.printStackTrace();
@@ -262,7 +262,7 @@ public class TestH5Plist {
             // Close parent class's parent
             try {
                 H5.H5Pclose_class(cid1);
-                cid1 = -1;
+                cid1 = HDF5Constants.H5I_INVALID_HID;
             }
             catch (Throwable err) {
                 err.printStackTrace();
@@ -634,7 +634,7 @@ public class TestH5Plist {
     @Test
     public void testH5P_genprop_basic_list_prop() {
         boolean     status = false;
-        long        lid1 = -1;        // Generic Property list ID
+        long        lid1 = HDF5Constants.H5I_INVALID_HID;        // Generic Property list ID
         long        nprops = -1;      // Number of properties in class
 
         try {
@@ -760,7 +760,7 @@ public class TestH5Plist {
 //    @Test
 //    public void testH5P_genprop_class_callback() {
 //        class cdata {
-//            public long cls_id = -1;
+//            public long cls_id = HDF5Constants.H5I_INVALID_HID;
 //            public int cls_count = -1;
 //            cdata(long id, int count) {
 //                this.cls_id = id;
@@ -813,11 +813,11 @@ public class TestH5Plist {
 //        }
 //        H5P_cls_close_func_cb cls_close_cb = new H5P_cls_close_callback();
 //
-//        long    cid1 = -1;        // Generic Property class ID
-//        long    cid2 = -1;        // Generic Property class ID
-//        long    lid1 = -1;        // Generic Property list ID
-//        long    lid2 = -1;        // Generic Property list ID
-//        long    lid3 = -1;        // Generic Property list ID
+//        long    cid1 = HDF5Constants.H5I_INVALID_HID;        // Generic Property class ID
+//        long    cid2 = HDF5Constants.H5I_INVALID_HID;        // Generic Property class ID
+//        long    lid1 = HDF5Constants.H5I_INVALID_HID;        // Generic Property list ID
+//        long    lid2 = HDF5Constants.H5I_INVALID_HID;        // Generic Property list ID
+//        long    lid3 = HDF5Constants.H5I_INVALID_HID;        // Generic Property list ID
 //        long    nprops = -1;    // Number of properties in class
 //
 //        try {