Primary change is HDFFV-11212 - new refs and JNI (#372)

* OESS-98 convert plugin option to FetchContent, add tests

* Fixes for pkcfg files because of plugin option

* OESS-98 fix tools test for plugins

* Keep doxygen comments under 100 chars long - format hint

* Whitespace

* HDFFV-11144 - Reclassify CMake messages

* HDFFV-11099/11100 added help text

* Reworked switch statement to compare string instead

* Fix typo

* Update CDash mode

* Correct name of threadsafe

* Correct option name

* Undo accidental commit

* Note LLVM 10 to 11 format default changes

* Update format plugin

* Undo clang-format version 11 changes

* One more correction

* Update supported platforms

* Revert whitespace changes

* Correct whitespace

* Changes from PR#3

* HDFFV-11213 added option to control gcc10 warnings diagnostics

* HDFFV-11212 Use the new references correctly in JNI utility and tests

* format source

* Fix typo

* Add new test file

* HDFFV-11212 - update test and remove unused arg

* Minor non-space formatting changes

* Use H5I_INVALID_ID instead of "-1"

* source formatting

* add missing testfile, update jni function

* Undo commit of debug code

* remove mislocated file

* Fix h5repack test for handling of fapls and id close

* Update h5diff test files usage text

* HDFFV-11212 add new ref tests for JNI export dataset

* src format update

* Remove blank line typo

* src format typo

* long double requires %Lg

* Another long double foramt specifer S.B. %Lg

* issue with t128bit test

* Windows issue with h5dump and type.

* Fix review issues

* refactor function nesting and fix error checks

* format fixes

* Remove untested functions and javadoc quiet comments

* Restore TRY block.

* Change string append errors to memory exception

* revert to H5_JNI_FATAL_ERROR - support functions need work

* Add assertion error for h5util functions

* remove duplicate function

* format fix

* Revert HD function error handling

* Update copyright comments

1 files changed, 13 insertions, 13 deletions

diff --git a/java/test/TestH5Pvirtual.java b/java/test/TestH5Pvirtual.java
index 4c9a763..30e761d 100644
--- a/java/test/TestH5Pvirtual.java
+++ b/java/test/TestH5Pvirtual.java
@@ -52,13 +52,13 @@ public class TestH5Pvirtual {
     private static final int fill_value = -1;
     long[] H5dims = { DIM_Y };
     long[] VDSH5dims = { VDSDIM_X, VDSDIM_Y };
-    long H5fid = -1;
-    long H5dsid = -1;
-    long H5dssid = -1;
-    long H5dvsid = -1;
-    long H5did = -1;
-    long H5dcplid = -1;
-    long H5dapl_id = -1;
+    long H5fid = HDF5Constants.H5I_INVALID_HID;
+    long H5dsid = HDF5Constants.H5I_INVALID_HID;
+    long H5dssid = HDF5Constants.H5I_INVALID_HID;
+    long H5dvsid = HDF5Constants.H5I_INVALID_HID;
+    long H5did = HDF5Constants.H5I_INVALID_HID;
+    long H5dcplid = HDF5Constants.H5I_INVALID_HID;
+    long H5dapl_id = HDF5Constants.H5I_INVALID_HID;
 
     private final void _deleteFile(String filename) {
         File file = new File(filename);
@@ -69,8 +69,8 @@ public class TestH5Pvirtual {
     }
 
     private final long _createDataset(long fid, long dsid, String name, long dcpl, long dapl) {
-        long did = -1;
-        long space_id = -1;
+        long did = HDF5Constants.H5I_INVALID_HID;
+        long space_id = HDF5Constants.H5I_INVALID_HID;
         long[] start = {0, 0};
         long[] stride = null;
         long[] count = {1, 1};
@@ -100,9 +100,9 @@ public class TestH5Pvirtual {
         int[] dset_data = new int[DIM_Y];
         // Create source files and datasets
         for (int i=0; i < 3; i++) {
-            long space_id = -1;
-            long dset_id = -1;
-            long file_id = -1;
+            long space_id = HDF5Constants.H5I_INVALID_HID;
+            long dset_id = HDF5Constants.H5I_INVALID_HID;
+            long file_id = HDF5Constants.H5I_INVALID_HID;
             for (int j = 0; j < DIM_Y; j++) dset_data[j] = i+1;
 
             try {
@@ -265,7 +265,7 @@ public class TestH5Pvirtual {
 
     @Test
     public void testH5Pget_selection_source_dataset() throws Throwable {
-        long src_space = -1;
+        long src_space = HDF5Constants.H5I_INVALID_HID;
         long src_selection = -1;
 
         H5did = _createDataset(H5fid, H5dsid, "VDS", H5dcplid, H5dapl_id);