Primary change is HDFFV-11212 - new refs and JNI (#372)

* OESS-98 convert plugin option to FetchContent, add tests

* Fixes for pkcfg files because of plugin option

* OESS-98 fix tools test for plugins

* Keep doxygen comments under 100 chars long - format hint

* Whitespace

* HDFFV-11144 - Reclassify CMake messages

* HDFFV-11099/11100 added help text

* Reworked switch statement to compare string instead

* Fix typo

* Update CDash mode

* Correct name of threadsafe

* Correct option name

* Undo accidental commit

* Note LLVM 10 to 11 format default changes

* Update format plugin

* Undo clang-format version 11 changes

* One more correction

* Update supported platforms

* Revert whitespace changes

* Correct whitespace

* Changes from PR#3

* HDFFV-11213 added option to control gcc10 warnings diagnostics

* HDFFV-11212 Use the new references correctly in JNI utility and tests

* format source

* Fix typo

* Add new test file

* HDFFV-11212 - update test and remove unused arg

* Minor non-space formatting changes

* Use H5I_INVALID_ID instead of "-1"

* source formatting

* add missing testfile, update jni function

* Undo commit of debug code

* remove mislocated file

* Fix h5repack test for handling of fapls and id close

* Update h5diff test files usage text

* HDFFV-11212 add new ref tests for JNI export dataset

* src format update

* Remove blank line typo

* src format typo

* long double requires %Lg

* Another long double foramt specifer S.B. %Lg

* issue with t128bit test

* Windows issue with h5dump and type.

* Fix review issues

* refactor function nesting and fix error checks

* format fixes

* Remove untested functions and javadoc quiet comments

* Restore TRY block.

* Change string append errors to memory exception

* revert to H5_JNI_FATAL_ERROR - support functions need work

* Add assertion error for h5util functions

* remove duplicate function

* format fix

* Revert HD function error handling

* Update copyright comments

1 files changed, 12 insertions, 12 deletions

diff --git a/java/test/TestH5Sbasic.java b/java/test/TestH5Sbasic.java
index e6698c6..5bcdc61 100644
--- a/java/test/TestH5Sbasic.java
+++ b/java/test/TestH5Sbasic.java
@@ -56,7 +56,7 @@ public class TestH5Sbasic {
 
     @Test
     public void testH5Screate_scalar() {
-        long sid = -1;
+        long sid = HDF5Constants.H5I_INVALID_HID;
         int class_type = -1;
         try {
             sid = H5.H5Screate(HDF5Constants.H5S_SCALAR);
@@ -75,7 +75,7 @@ public class TestH5Sbasic {
 
     @Test
     public void testH5Screate_null() {
-        long sid = -1;
+        long sid = HDF5Constants.H5I_INVALID_HID;
         int class_type = -1;
         try {
             sid = H5.H5Screate(HDF5Constants.H5S_NULL);
@@ -125,7 +125,7 @@ public class TestH5Sbasic {
 
     @Test
     public void testH5Screate_simple() {
-        long sid = -1;
+        long sid = HDF5Constants.H5I_INVALID_HID;
         int class_type = -1;
         int rank = 2;
         long dims[] = {5, 5};
@@ -148,7 +148,7 @@ public class TestH5Sbasic {
 
     @Test
     public void testH5Screate_simple_unlimted() {
-        long sid = -1;
+        long sid = HDF5Constants.H5I_INVALID_HID;
         int class_type = -1;
         int rank = 2;
         long dims[] = {5, 5};
@@ -171,7 +171,7 @@ public class TestH5Sbasic {
 
     @Test
     public void testH5Screate_simple_unlimted_1d() {
-        long sid = -1;
+        long sid = HDF5Constants.H5I_INVALID_HID;
         int class_type = -1;
         int rank = 1;
         long dims[] = {5};
@@ -194,7 +194,7 @@ public class TestH5Sbasic {
 
     @Test
     public void testH5Screate_simple_max_default() {
-        long sid = -1;
+        long sid = HDF5Constants.H5I_INVALID_HID;
         int rank = 2;
         long dims[] = {5, 5};
 
@@ -213,7 +213,7 @@ public class TestH5Sbasic {
 
     @Test
     public void testH5Screate_simple_extent() {
-        long sid = -1;
+        long sid = HDF5Constants.H5I_INVALID_HID;
         int rank = 2;
         long dims[] = {5, 5};
         long maxdims[] = {10, 10};
@@ -270,7 +270,7 @@ public class TestH5Sbasic {
 
     @Test(expected = IllegalArgumentException.class)
     public void testH5Sselect_adjust_rank_offset() throws Throwable {
-        long sid = -1;
+        long sid = HDF5Constants.H5I_INVALID_HID;
         long offset[][] = {{0,1},{2,4},{5,6}};
 
         try {
@@ -292,7 +292,7 @@ public class TestH5Sbasic {
 
     @Test(expected = IllegalArgumentException.class)
     public void testH5Sselect_intersect_block_rank_start() throws Throwable {
-        long sid = -1;
+        long sid = HDF5Constants.H5I_INVALID_HID;
         long start[] = new long[2];
         long end[] = null;
 
@@ -308,7 +308,7 @@ public class TestH5Sbasic {
 
     @Test(expected = IllegalArgumentException.class)
     public void testH5Sselect_intersect_block_rank_end() throws Throwable {
-        long sid = -1;
+        long sid = HDF5Constants.H5I_INVALID_HID;
         long start[] = null;
         long end[] = new long[2];
 
@@ -336,7 +336,7 @@ public class TestH5Sbasic {
 
     @Test(expected = NullPointerException.class)
     public void testH5Scombine_hyperslab_null_start() throws Throwable {
-        long sid = -1;
+        long sid = HDF5Constants.H5I_INVALID_HID;
         long start[] = null;
         long stride[] = null;
         long count[] = new long[2];
@@ -354,7 +354,7 @@ public class TestH5Sbasic {
 
     @Test(expected = NullPointerException.class)
     public void testH5Scombine_hyperslab_null_count() throws Throwable {
-        long sid = -1;
+        long sid = HDF5Constants.H5I_INVALID_HID;
         long start[] = new long[2];
         long stride[] = null;
         long count[] = null;