summaryrefslogtreecommitdiffstats
path: root/perform/overhead.c
diff options
context:
space:
mode:
authorQuincey Koziol <koziol@hdfgroup.org>2011-05-20 22:04:03 (GMT)
committerQuincey Koziol <koziol@hdfgroup.org>2011-05-20 22:04:03 (GMT)
commit1d9307bd91d51e15e408a584b4c761cacf916b96 (patch)
treee9e1e7a3b5c0e627e28985917f2e6412f17384a9 /perform/overhead.c
parent3f11adaec28a55a5772d702752b433aa0289adaf (diff)
downloadhdf5-1d9307bd91d51e15e408a584b4c761cacf916b96.zip
hdf5-1d9307bd91d51e15e408a584b4c761cacf916b96.tar.gz
hdf5-1d9307bd91d51e15e408a584b4c761cacf916b96.tar.bz2
[svn-r20885] Description:
Bring Coverity changes back to trunk: r20340: Address coverity issue 248. Set freed pointer to NULL if realloc fails, then check for NULL before attempting to close array of handles stored in memory addressed by pointer. r20341: Added initialization udata.path = NULL; udata.visited = NULL; to prevent unintialized use after done: label. Do C-style initialization AFTER all variable definitions. r20342: Fix valgrind error in H5DUMP-XML-tall.h5 r20343: Addressed Coverity issue 591 - check the return value of H5S_SELECT_ITER_RELEASE. r20344: Added initialization udata.path = NULL; to prevent uninitialized used after done: label r20347: Purpose: Fix memory leak in overhead.c Description: Fixed leak in test() in overhead.c where array "had" was never freed. r20348: Addressed Coverity issue 705 - added prototype for resize_configs_are_equal to cache_common.h. r20392: Purpose: Fix coverity issues 1677 and 1678 Description: Added return value checking for 4 funciton calls in H5tools_get_symlink_info(). r20394: Purpose: Fix coverity issues 1674 and 1675 Description: Modified H5Epush2() and H5E_printf_stack() to keep track of whether va_start() has been called, and to call va_end() at the end if so. r20395: Should be H5MM_calloc(count * sizeof(void*)). Fixed --gh r20396: Should be H5MM_calloc(count * sizeof(void*)). Fixed. --gh Tested on: Mac OSX/32 10.6.7 (amazon) w/debug & production (h5committested on branch)
Diffstat (limited to 'perform/overhead.c')
-rw-r--r--perform/overhead.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/perform/overhead.c b/perform/overhead.c
index 0c8e0ed..0b40721 100644
--- a/perform/overhead.c
+++ b/perform/overhead.c
@@ -243,7 +243,8 @@ test(fill_t fill_style, const double splits[],
hs_start[0] = j%2 ? j/2 : (hssize_t)cur_size[0]-j/2;
break;
case FILL_RANDOM:
- for (j=HDrand()%(int)cur_size[0]; had[j]; j=(j+1)%(int)cur_size[0]) /*void*/;
+ for (j=HDrand()%(int)cur_size[0]; had[j]; j=(j+1)%(int)cur_size[0])
+ /*void*/;
hs_start[0] = j;
had[j] = 1;
break;
@@ -273,8 +274,10 @@ test(fill_t fill_style, const double splits[],
}
}
- if(had)
+ if(had) {
free(had);
+ had = NULL;
+ } /* end if */
H5Dclose(dset);
H5Sclose(mspace);