diff options
| author | Dana Robinson <43805+derobins@users.noreply.github.com> | 2021-04-29 11:57:02 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-04-29 11:57:02 (GMT) |
| commit | 138bc52facad0e6be4cfd13a860bb628c1dfd626 (patch) | |
| tree | 8fc9c29e5cfbbbf05293f3a0c34d65e55fe82bcd /release_docs | |
| parent | 00dc456cec2a6820bbb05d8a9a2f1967bf30f7e8 (diff) | |
| download | hdf5-138bc52facad0e6be4cfd13a860bb628c1dfd626.zip hdf5-138bc52facad0e6be4cfd13a860bb628c1dfd626.tar.gz hdf5-138bc52facad0e6be4cfd13a860bb628c1dfd626.tar.bz2 | |
Fix for a segfault when H5Pset_fapl_log is passed an invalid fapl ID (#607)
* Committing clang-format changes
* Fixes an issue where H5Pset_fapl_log sefaults when passed an invalid
fapl ID
This was due to a pointer-containing struct being memset after the first
internal API call. If the first call failed, the error condition would
check if the pointer was not NULL and then attempt to free it if not.
This would lead to the freeing of a wild pointer if an invalid fapl ID
were passed in.
This was fixed by reordering the memset and adding a test to ensure the
problem stays fixed.
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Diffstat (limited to 'release_docs')
| -rw-r--r-- | release_docs/RELEASE.txt | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt index 359f222..f014d72 100644 --- a/release_docs/RELEASE.txt +++ b/release_docs/RELEASE.txt @@ -414,6 +414,19 @@ New Features Library: -------- + - H5Pset_fapl_log() no longer crashes when passed an invalid fapl ID + + When passed an invalid fapl ID, H5Pset_fapl_log() would usually + segfault when attempting to free an uninitialized pointer in the error + handling code. This behavior is more common in release builds or + when the memory sanitization checks were not selected as a build + option. + + The pointer is now correctly initialized and the API call now + produces a normal HDF5 error when fed an invalid fapl ID. + + (DER - 2021/04/28, HDFFV-11240) + - HSYS_GOTO_ERROR now emits the results of GetLastError() on Windows HSYS_GOTO_ERROR is an internal macro that is used to produce error |