[svn-r6823] Purpose:

    Code Improvements/Bug Fixes

Description:
    Comparison of equality of a double/float variable to 0.0 is not
    guaranteed to work and is bad practice.

    In H5Fcontig.c, a warning was given by a statement like:

        x = (++x) % y;

    This could be confusing to a compiler I suppose.

    In H5RS.c, a typedef of a structure was being tagged by the compiler
    as "useless" because it had the form:

        typedef struct foo {
            int var1;
            /* ... */
        }; /* <--- note no name for this typedef */

    The statement "typedef struct foo foo" is already in the header file.

Solution:
    Test that the absolute value of the variable is < a very small
    positive number.

    Changed "x = (++x) % y" to "++x; x %= y;" instead.

    Removed the "typedef" from the structure in the H5RS.c file.

Platforms tested:
    Modi4   (Parallel & Fortran)
    Verbena (C++ & Fortran)
    Arabica (Fortran)

Misc. update:

1 files changed, 4 insertions, 2 deletions

diff --git a/src/H5.c b/src/H5.c
index e40f7ca..e42f0da 100644
--- a/src/H5.c
+++ b/src/H5.c
@@ -1335,7 +1335,8 @@ H5_bandwidth(char *buf/*out*/, double nbytes, double nseconds)
 	HDstrcpy(buf, "       NaN");
     } else {
 	bw = nbytes/nseconds;
-	if (bw==0.0) {
+        if (fabs(bw) < 0.0000000001) {
+            /* That is == 0.0, but direct comparison between floats is bad */
 	    HDstrcpy(buf, "0.000  B/s");
 	} else if (bw<1.0) {
 	    sprintf(buf, "%10.4e", bw);
@@ -1450,7 +1451,8 @@ H5_trace (double *returning, const char *func, const char *type, ...)
     }
 
     /* Get tim for event */
-    if (!first_time.etime)
+    if (fabs(first_time.etime) < 0.0000000001)
+        /* That is == 0.0, but direct comparison between floats is bad */
         H5_timer_begin(&first_time);
     if (H5_debug_g.ttimes) {
         H5_timer_begin(&event_time);