diff options
| author | John Mainzer <mainzer@hdfgroup.org> | 2008-05-20 20:43:50 (GMT) |
|---|---|---|
| committer | John Mainzer <mainzer@hdfgroup.org> | 2008-05-20 20:43:50 (GMT) |
| commit | f9857027e327cac5b356da2c6c3ac94e3a773b29 (patch) | |
| tree | 8c93fd6a30f34c9b2d63acdcf429e1f9a3bf5378 /src/H5AC2.c | |
| parent | 2c84019fcaca9a1cb2a415564d8b88e3dd88479d (diff) | |
| download | hdf5-f9857027e327cac5b356da2c6c3ac94e3a773b29.zip hdf5-f9857027e327cac5b356da2c6c3ac94e3a773b29.tar.gz hdf5-f9857027e327cac5b356da2c6c3ac94e3a773b29.tar.bz2 | |
[svn-r15049] This is an interrim commit of metadata cache journaling mods.
I now have substantial tests for this code -- enough (I hope) for
Mike M. to get started. However, the code is my no means fully tested.
I don't expect any obvious problems, but there are probably quite a few
relatively subtle bugs remaining. I'll be chasing these in the next
week.
For an example of setting up the cache to journal, see
setup_cache_for_journaling() in test/cache2_journal.c
Warnings:
1) For now, only enable journaling at file creation time -- code to
do this after the file is opened exists, but it hasn't been tested.
2) Right now the journal logging code is very inefficient, so expect
things to run slowly until Mike M. checks in his changes to address
this problem.
3) I have not checked in exemplar journal output files pending a fix
another minor bug in the journal logging code. Until then, the
journal tests create exemplars and then test against them -- a poor
way to find errors.
4) The USE_CORE_DRIVER has been moved to cache2_common.h.
5) When USE_CORE_DRIVER is FALSE, cache2_journal runs VERY slowly on
some system (i.e. 4 hours on Phoenix) -- but it runs fast on Kagiso
(~10 minutes). Don't know why, but would guess that the quantity
of RAM on the system has much to do with it.
Tested serial debug on Phonenix, and parallel debug on Kagiso
Diffstat (limited to 'src/H5AC2.c')
| -rw-r--r-- | src/H5AC2.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/H5AC2.c b/src/H5AC2.c index adda9b1..bf5400e 100644 --- a/src/H5AC2.c +++ b/src/H5AC2.c @@ -3003,6 +3003,7 @@ H5AC2_get_cache_auto_resize_config(H5AC2_t * cache_ptr, config_ptr->jbrb_human_readable = FALSE; result = H5C2_get_journal_config(cache_ptr, + NULL, &(config_ptr->enable_journaling), &(config_ptr->journal_file_path[0]), &(config_ptr->jbrb_buf_size), @@ -3345,7 +3346,7 @@ H5AC2_set_cache_auto_resize_config(const H5F_t * f, } result = H5C2_get_journal_config((H5C2_t *)cache_ptr, &mdj_enabled, - NULL, NULL, NULL, NULL, NULL); + NULL, NULL, NULL, NULL, NULL, NULL); if ( result < 0 ) { |