summaryrefslogtreecommitdiffstats
path: root/src/H5Dscatgath.c
diff options
context:
space:
mode:
authorBinh-Minh Ribler <bmribler@hdfgroup.org>2020-10-26 13:36:27 (GMT)
committerBinh-Minh Ribler <bmribler@hdfgroup.org>2020-10-26 13:36:27 (GMT)
commit7bfa10018ecf5efe54b4a699bb684d31468c8b42 (patch)
tree46ae17c8595a0f1ba500b48ec760eac0e6f78bb5 /src/H5Dscatgath.c
parent58d8eae182ac764ef15c3ed040a12a96aa4d16f0 (diff)
downloadhdf5-7bfa10018ecf5efe54b4a699bb684d31468c8b42.zip
hdf5-7bfa10018ecf5efe54b4a699bb684d31468c8b42.tar.gz
hdf5-7bfa10018ecf5efe54b4a699bb684d31468c8b42.tar.bz2
Fix HDFFV-10590
Description This is to fix the CVE issue CVE-2018-17432. h5repack produced a segfault on a corrupted file. This fix modified the dataspace encode and decode functions per Quincey's suggestion to prevent the segfault. h5repack only failed for the corrupted file now. Platforms tested: Linux/64 (jelly)
Diffstat (limited to 'src/H5Dscatgath.c')
-rw-r--r--src/H5Dscatgath.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/H5Dscatgath.c b/src/H5Dscatgath.c
index 1a272d8..75047f6 100644
--- a/src/H5Dscatgath.c
+++ b/src/H5Dscatgath.c
@@ -1026,7 +1026,8 @@ H5Dgather(hid_t src_space_id, const void *src_buf, hid_t type_id, size_t dst_buf
herr_t ret_value = SUCCEED; /* Return value */
FUNC_ENTER_API(FAIL)
- H5TRACE7("e", "i*xiz*xx*x", src_space_id, src_buf, type_id, dst_buf_size, dst_buf, op, op_data);
+ H5TRACE7("e", "i*xiz*xx*x", src_space_id, src_buf, type_id, dst_buf_size,
+ dst_buf, op, op_data);
/* Check args */
if (NULL == (src_space = (H5S_t *)H5I_object_verify(src_space_id, H5I_DATASPACE)))