diff options
| author | Quincey Koziol <koziol@hdfgroup.org> | 2003-02-10 17:26:09 (GMT) |
|---|---|---|
| committer | Quincey Koziol <koziol@hdfgroup.org> | 2003-02-10 17:26:09 (GMT) |
| commit | 24d8506dd564c5cc0fdebb5ebdfaec7bda5a7435 (patch) | |
| tree | 6b2eb3bb1e782c40718204882428e6471b6281ac /src/H5FDlog.c | |
| parent | 738661ab9f409b8d961ba1402d6c4dd5f99ecb43 (diff) | |
| download | hdf5-24d8506dd564c5cc0fdebb5ebdfaec7bda5a7435.zip hdf5-24d8506dd564c5cc0fdebb5ebdfaec7bda5a7435.tar.gz hdf5-24d8506dd564c5cc0fdebb5ebdfaec7bda5a7435.tar.bz2 | |
[svn-r6387] Purpose:
Bug Fix
Description:
Metadata cache in parallel I/O can cause hangs in applications which
perform independent I/O on chunked datasets, because the metadata cache
can attempt to flush out dirty metadata from only a single process, instead
of collectively from all processes.
Solution:
Pass a dataset transfer property list down from every API function which
could possibly trigger metadata I/O.
Then, split the metadata cache into two sets of entries to allow dirty
metadata to be set aside when a hash table collision occurs during
independent I/O.
Platforms tested:
Tested h5committest {arabica (fortran), eirene (fortran, C++)
modi4 (parallel, fortran)}
FreeBSD 4.7 (sleipnir) serial & parallel
Misc. update:
Updated release_docs/RELEASE
Diffstat (limited to 'src/H5FDlog.c')
| -rw-r--r-- | src/H5FDlog.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/src/H5FDlog.c b/src/H5FDlog.c index 736695d..ecf98ce 100644 --- a/src/H5FDlog.c +++ b/src/H5FDlog.c @@ -166,7 +166,7 @@ static H5FD_t *H5FD_log_open(const char *name, unsigned flags, hid_t fapl_id, static herr_t H5FD_log_close(H5FD_t *_file); static int H5FD_log_cmp(const H5FD_t *_f1, const H5FD_t *_f2); static herr_t H5FD_log_query(const H5FD_t *_f1, unsigned long *flags); -static haddr_t H5FD_log_alloc(H5FD_t *_file, H5FD_mem_t type, hsize_t size); +static haddr_t H5FD_log_alloc(H5FD_t *_file, H5FD_mem_t type, hid_t dxpl_id, hsize_t size); static haddr_t H5FD_log_get_eoa(H5FD_t *_file); static herr_t H5FD_log_set_eoa(H5FD_t *_file, haddr_t addr); static haddr_t H5FD_log_get_eof(H5FD_t *_file); @@ -175,7 +175,7 @@ static herr_t H5FD_log_read(H5FD_t *_file, H5FD_mem_t type, hid_t fapl_id, haddr size_t size, void *buf); static herr_t H5FD_log_write(H5FD_t *_file, H5FD_mem_t type, hid_t fapl_id, haddr_t addr, size_t size, const void *buf); -static herr_t H5FD_log_flush(H5FD_t *_file, unsigned closing); +static herr_t H5FD_log_flush(H5FD_t *_file, hid_t dxpl_id, unsigned closing); /* * The free list map which causes each request type to use no free lists @@ -610,9 +610,6 @@ H5FD_log_close(H5FD_t *_file) FUNC_ENTER_NOAPI(H5FD_log_close, FAIL); - if (H5FD_log_flush(_file,TRUE)<0) - HGOTO_ERROR(H5E_IO, H5E_WRITEERROR, FAIL, "unable to flush file"); - #ifdef H5_HAVE_GETTIMEOFDAY if(file->fa.flags&H5FD_LOG_TIME_CLOSE) HDgettimeofday(&timeval_start,NULL); @@ -823,7 +820,7 @@ done: *------------------------------------------------------------------------- */ static haddr_t -H5FD_log_alloc(H5FD_t *_file, H5FD_mem_t type, hsize_t size) +H5FD_log_alloc(H5FD_t *_file, H5FD_mem_t type, hid_t dxpl_id, hsize_t size) { H5FD_log_t *file = (H5FD_log_t*)_file; haddr_t addr; @@ -1299,7 +1296,7 @@ done: *------------------------------------------------------------------------- */ static herr_t -H5FD_log_flush(H5FD_t *_file, unsigned UNUSED closing) +H5FD_log_flush(H5FD_t *_file, hid_t dxpl_id, unsigned UNUSED closing) { H5FD_log_t *file = (H5FD_log_t*)_file; herr_t ret_value=SUCCEED; /* Return value */ |